From: Paul Mackerras <paulus@samba.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Dong Feng <middle.fengdong@gmail.com>,
linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: Unnecessary Relocation Hiding?
Date: Fri, 25 Aug 2006 09:31:52 +1000 [thread overview]
Message-ID: <17646.14056.102017.127644@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0608241125140.4394@schroedinger.engr.sgi.com>
Christoph Lameter writes:
> On Wed, 23 Aug 2006, Dong Feng wrote:
>
> > I have a question. Why shall we need a RELOC_HIDE() macro in the
> > definition of per_cpu()? Maybe the question is actually why we need
> > macro RELOC_HIDE() at all. I changed the following line in
> > include/asm-generic/percpu.h, from
>
> Guess it was copied from IA64 but the semantics were not preserved.
> I think it should either be changed the way you suggest or the
> implementation needs to be fixed to actually do a linker relocation.
No, RELOC_HIDE came from ppc originally. The reason for it is that
gcc assumes that if you add something on to the address of a symbol,
the resulting address is still inside the bounds of the symbol, and do
optimizations based on that. The RELOC_HIDE macro is designed to
prevent gcc knowing that the resulting pointer is obtained by adding
an offset to the address of a symbol. As far as gcc knows, the
resulting pointer could point to anything.
It has nothing to do with linker relocations.
Paul.
next prev parent reply other threads:[~2006-08-24 23:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 12:00 Dong Feng
2006-08-23 12:25 ` Dong Feng
2006-08-24 18:26 ` Christoph Lameter
2006-08-24 19:24 ` Andi Kleen
2006-08-24 23:31 ` Paul Mackerras [this message]
2006-08-25 1:30 ` Dong Feng
2006-08-25 3:49 ` Paul Mackerras
[not found] ` <a2ebde260608242329r12259e0k7e798ee1d8737d68@mail.gmail.com>
2006-08-25 6:39 ` Fwd: " Dong Feng
2006-08-25 6:18 ` Andi Kleen
2006-08-25 7:20 ` Paul Mackerras
2006-08-25 7:38 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17646.14056.102017.127644@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=middle.fengdong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®