From: "tip-bot2 for Josh Poimboeuf" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: objtool/urgent] objtool: Consolidate annotation macros
Date: Wed, 03 Dec 2025 16:40:34 -0000 [thread overview]
Message-ID: <176478003405.498.13298696533128884255.tip-bot2@tip-bot2> (raw)
In-Reply-To: <c05ff40d3383e85c3b59018ef0b3c7aaf993a60d.1764694625.git.jpoimboe@kernel.org>
The following commit has been merged into the objtool/urgent branch of tip:
Commit-ID: 50765fb2746db2ac1d0b4dc9033b077734807689
Gitweb: https://git.kernel.org/tip/50765fb2746db2ac1d0b4dc9033b077734807689
Author: Josh Poimboeuf <jpoimboe@kernel.org>
AuthorDate: Tue, 02 Dec 2025 09:59:38 -08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 03 Dec 2025 16:53:19 +01:00
objtool: Consolidate annotation macros
Consolidate __ASM_ANNOTATE into a single macro which is used by both C
and asm. This also makes the code generation a bit more palatable by
putting it all on a single line.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://patch.msgid.link/c05ff40d3383e85c3b59018ef0b3c7aaf993a60d.1764694625.git.jpoimboe@kernel.org
---
include/linux/annotate.h | 36 +++++++++++++++---------------------
1 file changed, 15 insertions(+), 21 deletions(-)
diff --git a/include/linux/annotate.h b/include/linux/annotate.h
index 7c10d34..996126f 100644
--- a/include/linux/annotate.h
+++ b/include/linux/annotate.h
@@ -6,41 +6,35 @@
#ifdef CONFIG_OBJTOOL
-#ifndef __ASSEMBLY__
-
#define __ASM_ANNOTATE(section, label, type) \
- ".pushsection " section ",\"M\", @progbits, 8\n\t" \
- ".long " __stringify(label) " - .\n\t" \
- ".long " __stringify(type) "\n\t" \
- ".popsection\n\t"
+ .pushsection section, "M", @progbits, 8; \
+ .long label - .; \
+ .long type; \
+ .popsection
+
+#ifndef __ASSEMBLY__
#define ASM_ANNOTATE_LABEL(label, type) \
- __ASM_ANNOTATE(".discard.annotate_insn", label, type)
+ __stringify(__ASM_ANNOTATE(".discard.annotate_insn", label, type)) "\n\t"
#define ASM_ANNOTATE(type) \
- "911:\n\t" \
- ASM_ANNOTATE_LABEL(911b, type)
+ "911: " \
+ __stringify(__ASM_ANNOTATE(".discard.annotate_insn", 911b, type)) "\n\t"
#define ASM_ANNOTATE_DATA(type) \
- "912:\n\t" \
- __ASM_ANNOTATE(".discard.annotate_data", 912b, type)
+ "912: " \
+ __stringify(__ASM_ANNOTATE(".discard.annotate_data", 912b, type)) "\n\t"
#else /* __ASSEMBLY__ */
-.macro __ANNOTATE section, type
-.Lhere_\@:
- .pushsection \section, "M", @progbits, 8
- .long .Lhere_\@ - .
- .long \type
- .popsection
-.endm
-
.macro ANNOTATE type
- __ANNOTATE ".discard.annotate_insn", \type
+.Lhere_\@:
+ __ASM_ANNOTATE(".discard.annotate_insn", .Lhere_\@, \type)
.endm
.macro ANNOTATE_DATA type
- __ANNOTATE ".discard.annotate_data", \type
+.Lhere_\@:
+ __ASM_ANNOTATE(".discard.annotate_data", .Lhere_\@, \type)
.endm
#endif /* __ASSEMBLY__ */
next prev parent reply other threads:[~2025-12-03 16:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 17:59 [PATCH v2 0/4] objtool: Improve code generation for " Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 1/4] x86/alternative: Remove ANNOTATE_DATA_SPECIAL usage Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 2/4] x86/asm: " Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 3/4] objtool: Consolidate annotation macros Josh Poimboeuf
2025-12-03 16:40 ` tip-bot2 for Josh Poimboeuf [this message]
2025-12-03 16:49 ` [tip: objtool/urgent] " Linus Torvalds
2025-12-03 16:57 ` Ingo Molnar
2025-12-03 17:20 ` Josh Poimboeuf
2025-12-03 17:21 ` Linus Torvalds
2025-12-03 17:44 ` Linus Torvalds
2025-12-03 17:51 ` Josh Poimboeuf
2025-12-03 18:07 ` [PATCH] objtool: More annotation code generation tweaks Josh Poimboeuf
2025-12-03 18:48 ` [tip: objtool/urgent] objtool: Simplify .annotate_insn code generation output some more tip-bot2 for Josh Poimboeuf
2025-12-03 17:46 ` [tip: objtool/urgent] objtool: Consolidate annotation macros Josh Poimboeuf
2025-12-03 18:41 ` Linus Torvalds
2025-12-03 19:17 ` Josh Poimboeuf
2025-12-03 19:24 ` Linus Torvalds
2025-12-03 18:48 ` Ingo Molnar
2025-12-03 18:48 ` tip-bot2 for Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 4/4] objtool: Remove newlines and tabs from " Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-03 18:48 ` tip-bot2 for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176478003405.498.13298696533128884255.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®