From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF0532ABE8 for ; Tue, 9 Dec 2025 17:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765300897; cv=none; b=ADMi4mVfb3fTQzTe1487G2BSvb0RrwuNQJ2oXkX2cKYy/whWrDXigN4O7Be8sdc+42gz/ujhokTKkUO8JcV+Ja5CNO1Zfaurj4Ge2W2pljcOBk2ill13Xs4hlsjrgbupltVQ2nPnqknQ7TSAXGCw4Hb08g/O1exVKz8TMztgntM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765300897; c=relaxed/simple; bh=HR70R7VpRgxSmhJlE8cF060Mm3GQkrZMFB4wCLn61Ek=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=dikddxI0+rmP2lBIC2iLF0PQq6gUv06dG+Q18ZFAcpvTG3PnLp6534ulOMmY23C7hyMYsBq+SMYrxJfWh20fD/DUcVHiyyi067135bgHxaqmEeNRFVliNoVdEeGjm1grDkjNRIkdVDTtc6PKjRFfVbSyO0n3uw4lpwvB+v9biNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=yoW9zB+d; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="yoW9zB+d" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7b9c17dd591so5451417b3a.3 for ; Tue, 09 Dec 2025 09:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1765300895; x=1765905695; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cwietJa4Xt1cJ02ixB/T2eOTxw2s3Amg4IrtG+LaYI8=; b=yoW9zB+dHzpVQ0kB76mSCvrsQBeI6pxPDRCGwOM2GibZk/EcYnsYTTYMxvBTjzgd3T 5FYkRUSEwHWutuvbv2/lbfdrTXk8s+0U0SQF3ibtT6wty52BtoWvtRtEzLEsgQvlujQ5 yR3UjNNHvXx7rw9HK0CWYh6Vsgy2lXnBpXj/TXmJ6gP1ijEWCVO92SIQGcv2NNO4O5nm eoRDpjuHBjXBTLnpXxh+f9flQ8kSNMHxL2vi63lxHkfDoUPR8I0n1IYTWd+r54NE5p8N dWTV1iuA9s6NBG+Dx1R5U2B7kJIVJ0u183zSMC+xnsj1EWpMk9Du2hUPLOLG1TENCQgm qyXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765300895; x=1765905695; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cwietJa4Xt1cJ02ixB/T2eOTxw2s3Amg4IrtG+LaYI8=; b=kpv955gzL4qYBQ0xiw++iLd3Ph25xpu25EiJ9EO8qsMVGnyiYjHZaRqXSIf9XZJws8 DSF6iRdV8L0ykoml1YrKQjtDHZXZ+tMxp878YwI3AKKBUNPuLKErB1eE/8iUV1AVDESI V2Z9udR3fWIA2dl8rByDTSBHhg+hnQ0ZTgKoc7XgYOHtsdzQSxR7ACa1TQvh6ml02y8Q cRPl2khCveJqfPQ25Dj6UOQ2MHfFGUgNlmp8T8i2fv0xORIsqO7KhA+iepSppGRjIvic FiD79vMq7yY6c41J0LqUXblI3rHKXee5ykDpz1ydsTxf+s+fXTKIiileEGB4n5vguIti doHA== X-Forwarded-Encrypted: i=1; AJvYcCVvHAeyEslm+w+XXR1SPW0Gshyno0LMjNr/qhQPV90EsNy/0YshsoLrM/HM94gAQznBCFYTGCjgs08HTt4=@vger.kernel.org X-Gm-Message-State: AOJu0YyQpHAtERJ6MfQt+Yqd7t/5WqCSEVoQTnSayvzna8dtqkha1lIU vhUXTi+N2mvQ9mFnSaT0VGML5AHGpZ6QUR43PFM8lYiq2xHl13cmdcnclatM2Ou/02Y= X-Gm-Gg: ASbGncvAZoPYWydf4AP/A/HkcgDMWyxWL5CMEBe5BfvEGSwvzBlk6OmHPnmGecEdsdz SFTjzQ6F3cL2N6gcM5BpjBaZPpK5M43zyNU9Vuf9q9c63rEt39jHUN8n4J0SGAnV2ginOfKWSeI XyfsBNYzoTDD+fd6BBRPslRdziInZ3KNq0FOoJIVfib44W6TJncBHJd4SEGMJZUoY+KtokdEeBw rbBxpcL0D8qO75h2TMB7OjZUGNJh88KW9tuvtBvj+aoEX6btVuoI2+59X9uvTeqI6FlD3eso+a9 Gqhnp80dSbedtgknBLZBUL37Hsg+onb4KJmbIZGqLAWKK3MxakyY/rB4+68e5gOO/cjbguSF8md zNsyWKgC4vQSIEABQYdaWIS/0NkfWPYs0v2XmmnV3FUUxQ0VmPLEG543zym24lIcldpyq+e3QO4 6aBBR7cYDwdAPwHB7mDB6f9drDM/DdAIaDbOKDtJ6VlM2skg== X-Google-Smtp-Source: AGHT+IESJG2Io3EM0m8tS3YIfJuCtzYaGUA6zm6VEFJbV0wTLw7bRCLX9AMXOXA6EVFBVeD1Trp3fg== X-Received: by 2002:a05:7022:418b:b0:11b:923d:7735 with SMTP id a92af1059eb24-11e03165bf6mr7770950c88.1.1765300895349; Tue, 09 Dec 2025 09:21:35 -0800 (PST) Received: from [127.0.0.1] (221x255x142x61.ap221.ftth.ucom.ne.jp. [221.255.142.61]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f283d4733sm994549c88.17.2025.12.09.09.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 09:21:34 -0800 (PST) From: Jens Axboe To: Ming Lei , Caleb Sander Mateos Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20251209031424.3412070-1-csander@purestorage.com> References: <20251209031424.3412070-1-csander@purestorage.com> Subject: Re: [PATCH] ublk: don't mutate struct bio_vec in iteration Message-Id: <176530089382.83150.18335871238893970747.b4-ty@kernel.dk> Date: Tue, 09 Dec 2025 10:21:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Mon, 08 Dec 2025 20:14:23 -0700, Caleb Sander Mateos wrote: > __bio_for_each_segment() uses the returned struct bio_vec's bv_len field > to advance the struct bvec_iter at the end of each loop iteration. So > it's incorrect to modify it during the loop. Don't assign to bv_len (or > bv_offset, for that matter) in ublk_copy_user_pages(). > > Applied, thanks! [1/1] ublk: don't mutate struct bio_vec in iteration commit: db339b4067eccb7fa3d9787d5d3ab5d466fd9efa Best regards, -- Jens Axboe