From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] ASoC: qcom: Fix confusing cleanup.h
Date: Mon, 15 Dec 2025 22:58:24 +0900 [thread overview]
Message-ID: <176580710495.161056.18321549435251092606.b4-ty@kernel.org> (raw)
In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com>
On Sat, 29 Nov 2025 14:17:52 +0100, Krzysztof Kozlowski wrote:
> Please, please stop ending cleanup.h patches for very simple code like:
>
> foo = kzalloc();
> kfree(foo);
> return;
>
> ... *if you do not intend to read cleanup.h*. These changes are making
> simple code not necessarily simpler. But worse, if you do not read
> cleanup.h then you introduce actually undesired, error-prone and wrong
> style of having constructors with redundant values (= NULL).
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/6] ASoC: qcom: q6prm: Fix confusing cleanup.h syntax
commit: bd9e7182e36169cd7e1ea3b25b5c82b1c5698e64
[2/6] ASoC: qcom: q6asm: Fix confusing cleanup.h syntax
commit: c862dc9019f517893eb83096076d7eed4ecbb372
[3/6] ASoC: qcom: q6apm: Fix confusing cleanup.h syntax
commit: 310e6f95eedaae04990072078adbb38beb149811
[4/6] ASoC: qcom: q6afe: Fix confusing cleanup.h syntax
commit: 3c84bfa47ff29ec0c202cb139d365421c6778d65
[5/6] ASoC: qcom: audioreach: Fix confusing cleanup.h syntax
commit: 0e6071d656fb284e003a45ce158831d4d12aac5a
[6/6] ASoC: qcom: Minor readability improve with new lines
commit: 0bb160c92ad400c692984763996b758458adea17
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2025-12-15 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 13:17 Krzysztof Kozlowski
2025-11-29 13:17 ` [PATCH 1/6] ASoC: qcom: q6prm: Fix confusing cleanup.h syntax Krzysztof Kozlowski
2025-11-29 13:17 ` [PATCH 2/6] ASoC: qcom: q6asm: " Krzysztof Kozlowski
2025-11-29 13:17 ` [PATCH 3/6] ASoC: qcom: q6apm: " Krzysztof Kozlowski
2025-11-29 13:17 ` [PATCH 4/6] ASoC: qcom: q6afe: " Krzysztof Kozlowski
2025-11-29 13:17 ` [PATCH 5/6] ASoC: qcom: audioreach: " Krzysztof Kozlowski
2025-11-29 13:17 ` [PATCH 6/6] ASoC: qcom: Minor readability improve with new lines Krzysztof Kozlowski
2025-12-01 15:12 ` [PATCH 0/6] ASoC: qcom: Fix confusing cleanup.h Srinivas Kandagatla
2025-12-03 8:05 ` Krzysztof Kozlowski
2025-12-15 13:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176580710495.161056.18321549435251092606.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®