From: "tip-bot2 for Jens Remus" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Jens Remus <jremus@linux.ibm.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/core] x86/unwind_user: Guard unwind_user_word_size() by UNWIND_USER
Date: Wed, 17 Dec 2025 12:38:03 -0000 [thread overview]
Message-ID: <176597508332.510.16184348850466898187.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20251208160352.1363040-4-jremus@linux.ibm.com>
The following commit has been merged into the perf/core branch of tip:
Commit-ID: aa6047ef7204ea1faa346b9123439abed0546f7e
Gitweb: https://git.kernel.org/tip/aa6047ef7204ea1faa346b9123439abed0546f7e
Author: Jens Remus <jremus@linux.ibm.com>
AuthorDate: Mon, 08 Dec 2025 17:03:51 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 17 Dec 2025 13:31:08 +01:00
x86/unwind_user: Guard unwind_user_word_size() by UNWIND_USER
The unwind user framework in general requires an architecture-specific
implementation of unwind_user_word_size() to be present for any unwind
method, whether that is fp or a future other method, such as potentially
sframe.
Guard unwind_user_word_size() by the availability of the UNWIND_USER
framework instead of the specific HAVE_UNWIND_USER_FP method.
This facilitates to selectively disable HAVE_UNWIND_USER_FP on x86
(e.g. for test purposes) once a new unwind method is added to unwind
user.
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20251208160352.1363040-4-jremus@linux.ibm.com
---
arch/x86/include/asm/unwind_user.h | 30 ++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/arch/x86/include/asm/unwind_user.h b/arch/x86/include/asm/unwind_user.h
index 971ffe9..7f1229b 100644
--- a/arch/x86/include/asm/unwind_user.h
+++ b/arch/x86/include/asm/unwind_user.h
@@ -2,23 +2,11 @@
#ifndef _ASM_X86_UNWIND_USER_H
#define _ASM_X86_UNWIND_USER_H
-#ifdef CONFIG_HAVE_UNWIND_USER_FP
+#ifdef CONFIG_UNWIND_USER
#include <asm/ptrace.h>
#include <asm/uprobes.h>
-#define ARCH_INIT_USER_FP_FRAME(ws) \
- .cfa_off = 2*(ws), \
- .ra_off = -1*(ws), \
- .fp_off = -2*(ws), \
- .use_fp = true,
-
-#define ARCH_INIT_USER_FP_ENTRY_FRAME(ws) \
- .cfa_off = 1*(ws), \
- .ra_off = -1*(ws), \
- .fp_off = 0, \
- .use_fp = false,
-
static inline int unwind_user_word_size(struct pt_regs *regs)
{
/* We can't unwind VM86 stacks */
@@ -31,6 +19,22 @@ static inline int unwind_user_word_size(struct pt_regs *regs)
return sizeof(long);
}
+#endif /* CONFIG_UNWIND_USER */
+
+#ifdef CONFIG_HAVE_UNWIND_USER_FP
+
+#define ARCH_INIT_USER_FP_FRAME(ws) \
+ .cfa_off = 2*(ws), \
+ .ra_off = -1*(ws), \
+ .fp_off = -2*(ws), \
+ .use_fp = true,
+
+#define ARCH_INIT_USER_FP_ENTRY_FRAME(ws) \
+ .cfa_off = 1*(ws), \
+ .ra_off = -1*(ws), \
+ .fp_off = 0, \
+ .use_fp = false,
+
static inline bool unwind_user_at_function_start(struct pt_regs *regs)
{
return is_uprobe_at_func_entry(regs);
next prev parent reply other threads:[~2025-12-17 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 16:03 [PATCH v4 0/4] unwind_user: Cleanups Jens Remus
2025-12-08 16:03 ` [PATCH v4 1/4] unwind_user: Enhance comments on get CFA, FP, and RA Jens Remus
2025-12-17 12:38 ` [tip: perf/core] " tip-bot2 for Jens Remus
2025-12-08 16:03 ` [PATCH v4 2/4] unwind_user/fp: Use dummies instead of ifdef Jens Remus
2025-12-17 12:38 ` [tip: perf/core] " tip-bot2 for Jens Remus
2025-12-08 16:03 ` [PATCH v4 3/4] x86/unwind_user: Guard unwind_user_word_size() by UNWIND_USER Jens Remus
2025-12-17 12:38 ` tip-bot2 for Jens Remus [this message]
2025-12-08 16:03 ` [PATCH v4 4/4] x86/unwind_user: Simplify unwind_user_word_size() Jens Remus
2025-12-17 12:38 ` [tip: perf/core] " tip-bot2 for Jens Remus
2025-12-08 19:36 ` [PATCH v4 0/4] unwind_user: Cleanups Peter Zijlstra
2025-12-09 9:10 ` Jens Remus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176597508332.510.16184348850466898187.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®