From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547F13446B6 for ; Wed, 17 Dec 2025 14:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765982190; cv=none; b=H+xdKPzv/wXoJGHeWx7JE32/omwNQc+K+rCqryKRUi0ye95+09dkw5j196zSdGblH2zuf3bErel1MVeLWpspce0vOGDkurJad3IFBtn+C46MMeHY88IBcOLfVesO2VYrdCfE4cfl6Z9vL+X6I/Llxa0tuUj0pQ+URpIVoiWeRaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765982190; c=relaxed/simple; bh=K0RiY5AfyIg4L6r90U3kXhMr9PutSmMQD4Hxb8eUnA8=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=b5abDauTK/m0kY9lCLnBJMC2qttZ0f+XHfAhnHxkY6fS+wtZaEkEfiZyByzqfhPSoKYLsU/dgztC5egbKW9e1N0buPD96x1CGOLp55gs+3UIM+z/+f8wRmYseaTbwKW+yR3EaQnBjYXQjYDVnQyzndKWRN9DSNdE5/zAgbuYjns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=KPB62hWa; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="KPB62hWa" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-6597b877066so3627667eaf.2 for ; Wed, 17 Dec 2025 06:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1765982177; x=1766586977; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DJZ9aWMriNQy+1BZbcxf7ApYBa/N1P8I6lx3TtaJ4mo=; b=KPB62hWaudJ3fQJoyG67ivvT+LGjK2WBxvZ5e0v3BeYVMqJOwc9hzghRwq7mS/5D2i XGi0fkhi/O/tOVK5ovGr79N870CL0Ve4T/C9D2QvKfl5lJiMOCuRMlpqsYtQlwSuGL7P kJnl8aVPgA+pAfGUiROiOuFbpWPfNB1s8dBPA4Q5noRKdZIMnIsf6kfraN27Duvoayld Ua5GS7vDvOfhI0v9r2c3+mBCIGtvxSRQxfdD52o8AQo2dM4+XhDuGAqr9N+PYstu5V2v EjF9Ka5HAEdk4gk/YdG+GnK8nEh9TISY/kkBoxJos/ShWL8x9hNxHHriS02wsdeeaXBn jCXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765982177; x=1766586977; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DJZ9aWMriNQy+1BZbcxf7ApYBa/N1P8I6lx3TtaJ4mo=; b=jgBKqre8UcdBDdoXTjWLCOj8VFikR13CKETYhmNxEBBZOfeVtdW6DFVB9TTJ+wlZJn +aG/4qecyEF7qeYo5zL5GaNfoOzOKD/vl7EaYewbpQ8JN/igbPUZxgW2ehUFghiaLIYZ he7alTUuTuBk4BReMHvDfas9muguP5aBmk5j1vF7MTXVO95BhDAXsKcTmfunfh4loZeI l6n0EnkB6bRD/7z/wR48oNJROdvHOyNQeSBXWNOJgwx4hhX73v1PWGAeCl9tzpGTZTdI 2fd7aQE1hUreZFzxXUh8HgS6U8tYcfOp5XK6Ulqym/mnTtjqH4IIG6lt8EXgLxRdDQaE ObiA== X-Forwarded-Encrypted: i=1; AJvYcCUtVwM06t6llwexQ0/SkImL5SJo9sGytolHPxU783yL4u6BaqjDCfcfDCQptgJh56URpSzFOCSZYo5hb5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwNikE6L/xvaKnqKkHfiPZ8L8W6SAgE6VZd8clxHvYtWEXQDY+H DO3hDsbhKfcUd5M2NybOjc0cIzHLJFfcv6U3+90r3VbhGEXjI3kg04T/SvM7Jqt5Z1ODocfPL2u YIYYEJGU= X-Gm-Gg: AY/fxX4+kllbIry24OQ8JaOrXUBtkyhKGdxcMSyv1/qTiGZCx4dtUOz2yX5hDNlDAVP fRSZ5UWXkCW30zMIUhrypL8vKkTYSsSVRKCmPoSaTsgyNSc7rd9ZKwQIYxrEGri066Ti0CjG0sy WT+yfVT0cfZWLdPBdV2wI/J/GWMerfTnBSmFlHqyLoIoK5c+QNTHVQj36u4FSt7SbmcKvmIRY4V 0aOj9wcWCMfbf3q48aVma/aBM9RH+M55VGtf895u+FBBLNPg+PMDcnacDnJfQ3avNT72CqSlvEC nbExPjN0k/CSPwPUyT+dZghPOGSF1HVVJ5K/0f2YuH+h1vM310E2lE7+BCvOuz/JDq4D1g3Yhiq hdBPDFQ4htuVX64ceppl04nvGs6lZvKfvw5Yt7hPRByzeA6eNBIl7EgF6/BF2BNi5CKgGtOqo6u NIXKI= X-Google-Smtp-Source: AGHT+IE7whak2dzU39sLk9L0zhKeneNE1PL2Aqh7mvSlD/lOISSawIUVs93E4o897CUL11b8hEKQ8w== X-Received: by 2002:a05:6820:2004:b0:659:9a49:8f8a with SMTP id 006d021491bc7-65b4576fe5emr8028566eaf.79.1765982176991; Wed, 17 Dec 2025 06:36:16 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-65b867ae255sm2141700eaf.1.2025.12.17.06.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 06:36:15 -0800 (PST) From: Jens Axboe To: martin.petersen@oracle.com, stefanha@redhat.com, Deepanshu Kartikey Cc: hare@suse.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+660d079d90f8a1baf54d@syzkaller.appspotmail.com In-Reply-To: <20251217014712.35771-1-kartikey406@gmail.com> References: <20251217014712.35771-1-kartikey406@gmail.com> Subject: Re: [PATCH v3] block: add allocation size check in blkdev_pr_read_keys() Message-Id: <176598217497.7122.17206763785166141358.b4-ty@kernel.dk> Date: Wed, 17 Dec 2025 07:36:14 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Wed, 17 Dec 2025 07:17:12 +0530, Deepanshu Kartikey wrote: > blkdev_pr_read_keys() takes num_keys from userspace and uses it to > calculate the allocation size for keys_info via struct_size(). While > there is a check for SIZE_MAX (integer overflow), there is no upper > bound validation on the allocation size itself. > > A malicious or buggy userspace can pass a large num_keys value that > doesn't trigger overflow but still results in an excessive allocation > attempt, causing a warning in the page allocator when the order exceeds > MAX_PAGE_ORDER. > > [...] Applied, thanks! [1/1] block: add allocation size check in blkdev_pr_read_keys() commit: a58383fa45c706bda3bf4a1955c3a0327dbec7e7 Best regards, -- Jens Axboe