From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com,
kwilczynski@kernel.org, kishon@kernel.org, bhelgaas@google.com,
Haotian Zhang <vulab@iscas.ac.cn>
Cc: ntb@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: endpoint: Add missing NULL check for alloc_workqueue()
Date: Thu, 18 Dec 2025 12:42:14 +0530 [thread overview]
Message-ID: <176604193414.795334.4365952101287468707.b4-ty@kernel.org> (raw)
In-Reply-To: <20251110040446.2065-1-vulab@iscas.ac.cn>
On Mon, 10 Nov 2025 12:04:46 +0800, Haotian Zhang wrote:
> The alloc_workqueue() function can return NULL on memory allocation
> failure. Without proper error checking, this leads to a NULL pointer
> dereference when queue_work() is later called with the NULL workqueue
> pointer in epf_ntb_epc_init().
>
> Add a NULL check immediately after alloc_workqueue() and return -ENOMEM
> on failure to prevent the driver from loading with an invalid workqueue
> pointer.
>
> [...]
Applied, thanks!
[1/1] pci: endpoint: Add missing NULL check for alloc_workqueue()
commit: 0a19a6d9ed65ef7df845c32befa994e45620c12d
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
prev parent reply other threads:[~2025-12-18 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 4:04 Haotian Zhang
2025-11-10 19:51 ` Frank Li
2025-12-18 7:12 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176604193414.795334.4365952101287468707.b4-ty@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ntb@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®