From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 860FF3469F4 for ; Thu, 18 Dec 2025 15:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766070645; cv=none; b=G9fdO/7fyidb1TtlDXGiIy9ZYn2B7fMJFrWSifnGzDT2XKNdniI2nWPjjajZfWT1TPwnsdo8EVmU06f30ZGrsNzI/JoHnaV9y0E6DPHmwXpsDMzRh7LzH1k/fRGo3KmWgroCfadmXVpdy6ipVHcRlyM5Uapbo5bLD6W/8Jxrv5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766070645; c=relaxed/simple; bh=S/QIGpPu9C3+NnksBwVmku6soVmRP/JN1rvbrtdehso=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=tR9hcAV4PkuULlbu5GPp1jrOOW3EM9nSq4UMeEVtGxV+J0BPklpPNhyoyugzDgmdhBGp4S7sHHjHOGYOcONK5OSDactquJqMvPnnNJ++VZT591Dwk6Jzs6KZue8rH9HA57zX0njCWe4C/XPVmxVM+x2k4M+23dqkNOwekpUhah4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=rDssmU7C; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="rDssmU7C" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-3eae4e590a4so358089fac.1 for ; Thu, 18 Dec 2025 07:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1766070642; x=1766675442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WYpV9joBnrWptuU+JqoPkcaViF92PnszrAgFL84I3Qo=; b=rDssmU7COvDddbgaaKWN4+nDjoueH/89Ybf8KzAQPsNdIwlX/GOdyC/e8mGfhsP0/a 90NLM65Iszpspo9+/76HSmDHDPsRtCbGAp4by+7uxP7lGzWAevlD3aiej4mSufzzvJnG Xch1SVQwYy4ovAXEu+RKDvky2Sg+bGyLWe9V6Z+xT3gSLgrNIvlPHQ8wuxtGk1MVG/9w EgdqQnSAfjpQf4nORJcJvEZi6AajP8OfXJWtVKORI6Unscd+aHN+ITTWXCV+ktVfKEqu XlXyy2bAD8kDHImd3PZiQWlQusN5VwIxPr/OJLjzxF3dFzKZ1UUbvrAMSWUDjsC3TvZ/ nr9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766070642; x=1766675442; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WYpV9joBnrWptuU+JqoPkcaViF92PnszrAgFL84I3Qo=; b=jxYk+o2A2w8vxhH1kXt/gsKK8w1FG3TipLZv266+fJ8QMINCCPwsHlPuYorHtDSL5j Mmmjr0kKfmnqSCui0AljBBw+xZxpQM+0N+2CCc/e6Fb8CER32F/K1+xRWHz7iI/mR1DJ uiZ/fzfpcHFo2yBlNaO3TeR39gQW8FMWzAoc/1B8a1/Syz4/ichuhDp3QakOkQp1kuwx MOwcyK1pMKXyaSE46LRpBchR2fkw5McA0pSCCUes+i/z3NYy2620fY1V6ESsoO24j0J4 WBb+99oYWbt8WQewyOjIR0bbLHxVw5uCm+/CzBM8Ll54AmWw9zAAQKASeST3bFjyBLqv vyeA== X-Forwarded-Encrypted: i=1; AJvYcCU++cxNeE1N8mqsl9vrbJzneCulQNeAPEs/YiE9qzc7tIOMHWZ2uZ3OHtgJQ5/FKEgBpo6MNr1erydYMKY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2psxvxz+IlVG0wcvgxOUdzE2fZX+/Pbt7GK5PE/rU6/vM2v+K NK7KFRPQTavyhw3EKGuIFSw0u5NgziTqdlLtDC38DlOfRBVpocw53cS60bb364awVPE= X-Gm-Gg: AY/fxX4LzWWfnPQK7OSLeJC+/+mU/XkM95QBaSxSPLwwp+D94A75ZnriWHDm05gAXUH 9YOTHsqISiOMEH4bnS2KX5rJ+z2HhMGjtphqcDRXx+xcCzroDpixiA1APz/drwB+60Ji3985QcD kCg6TGjFr8BnlqI53kF1RpRFCmcxVN7WwrWZAf9qpJTqGTSq4C7+gRD8sbiBwLo2FHuUVmLdQMv 5NEsXEbZe0Te7JPyFuTrgVPlvkvDGXsawrtwKtmPjTHxr2fYAn/oluwhcUA5ioKBiEuzfRTUjdB rGMyGdJQNz2WNGcEbPXXbekCiqj4/YkDFE1NCsaX2DCBeXcrw0/kcgtsoJKZ0URM0Ijp9PJgH1K dEpGpT7R6Svn+bDLw+UFtEMM3ImEZeFuMg06zeBdREnHrPErlbCsJ4Qtb2EV7zsuDmGpUQNxnf4 wUrQ== X-Google-Smtp-Source: AGHT+IHqscQ8/U5wzi9OX4vEKXhLkkHWPOWkX2TpFVzTbXsE0SzIWqk3KFbD0pAONmEtoFfYsTXeMw== X-Received: by 2002:a05:6871:152:b0:3ec:50d6:4461 with SMTP id 586e51a60fabf-3f5f890eefemr10687875fac.39.1766070642478; Thu, 18 Dec 2025 07:10:42 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3fa17fc418fsm1769192fac.19.2025.12.18.07.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 07:10:41 -0800 (PST) From: Jens Axboe To: Thomas Fourier Cc: "Md. Haris Iqbal" , Jack Wang , Md Haris Iqbal , Lutz Pogrell , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20251217093648.15938-2-fourier.thomas@gmail.com> References: <20251217093648.15938-2-fourier.thomas@gmail.com> Subject: Re: [PATCH v2] block: rnbd-clt: Fix leaked ID in init_dev() Message-Id: <176607064127.251590.3100959244352916450.b4-ty@kernel.dk> Date: Thu, 18 Dec 2025 08:10:41 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Wed, 17 Dec 2025 10:36:48 +0100, Thomas Fourier wrote: > If kstrdup() fails in init_dev(), then the newly allocated ID is lost. > > Applied, thanks! [1/1] block: rnbd-clt: Fix leaked ID in init_dev() commit: c9b5645fd8ca10f310e41b07540f98e6a9720f40 Best regards, -- Jens Axboe