From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 741312F1FD7 for ; Sat, 20 Dec 2025 20:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766262351; cv=none; b=fD9w148kU65KpEs8Uh/y4t5W5C/1k9eQgCax0EOitZ/reorCbNbRLXSc9OB2Jxqc8zWTMyGdXezFz8Qd414Bw/SxmicXonWD4pxQsEC8ummKA+XnlHVovD+AycuQE6l/JhY31m7u8GiD6TQcM+yRlmXwp/kBEDTfUNKZAYUYR/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766262351; c=relaxed/simple; bh=MYVHHDYPJQlGy377kN/D5GQTkJQCWYfxlfGGoipB9Qo=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=RTog+MNWoud8y7G6H6O0XL8YThutv6gz95JD9QJ4C9ziSk5tpG2C8GkVwh6N9luJa2XgHr7AIgqmHoI8sSiOymdnaov0Z3lVxfJ9QAlrzoGOqbcNAh5lyxpuTWVp6syeiighdxVluZ5A9ClzrqurS4EBWQcIZqjq6PAdlhml6iA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=FtvsBmqD; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="FtvsBmqD" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7c6ce4f65f7so2617022a34.0 for ; Sat, 20 Dec 2025 12:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1766262348; x=1766867148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ECS0k4XdVu/LKfu6qgP9Zpz4mmQaxblDFvP7Po9U/iE=; b=FtvsBmqDRdkK/HP39EkHqymXzLOsOnR27hHTXftcSxpm/cTjvu61DKR5H4RG0KYTw1 Oo4MJIBIROvXeJ+BtGDkcvjbRV99vVAel7CLT5inJq19Qv6Kpc76uiWArvG+X5GrU3PT nYM52JVsil1HGpmjXruk6W+ig2TSqYZW7ZkJELpLRKx1S+46yK8ILlCfnxeWaqyYj8jg 0+ZrfIt9mqGTmJ4eOpB6szGkptp5cLTjoZMIpOypILkeIYXI4bW2BAa/8fjIpoeX3KSB SSvF8FYXgyUFddSxFl/1mNmPk/6wRmofTx/6a3f72PB+j4aJrsHktvnGudVSZXJX7FnC yg6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766262348; x=1766867148; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ECS0k4XdVu/LKfu6qgP9Zpz4mmQaxblDFvP7Po9U/iE=; b=tUtDa9b1WnsHq1Tk7nR29GR4hp3+pd/Cf7th1Dk26K9Rx9+Mpu54Wnh395Z2tTo4BZ rOIvgMIGz+rbMCYTDqlw2R38+0AGWBo5RzqIALtm8zifAbSFOfvscgmD/9155mU3ySPO 1YH0wFW1+l907lKnmtwyR7nVIYDCrXXI9K2SCQ4BmKPO18LJ3X6w26xkuB/ifHhvzWb8 PtyzxAS+WZVWNLZ4ARjhOHupa5/T15WkiH1d8fD+k6Vdqoahy8zP3SMdOY/n6GzULTzt pQEn6msJ2kXCerYLMpRjyj4f/PN2gB5/amfkkrI1qP651vAyMHStN+jgDq+HwPZRwp3R atPQ== X-Forwarded-Encrypted: i=1; AJvYcCXoP+QSIPdK0YczHWxAW+keMu+dgzhzUenSEyClRFZvjllPB799wClBjf7SUb2USsBGLZ3cdCIvPfnJqNE=@vger.kernel.org X-Gm-Message-State: AOJu0YzVnDE9Y5JOwQISF++bXotwa2MxEGJzNpLdqttJXcfuPmawhd5W Ie6zpxkxm0XdB2TdHGEzqUi4FkXKkSvkv7N/6hp2zWolzv1mP9CjdTZf8mGT7NTkQNA= X-Gm-Gg: AY/fxX7SKxsyjeAbBl5znbUEFibH80E183TLbRpwyxxSRTE/qmM1n3SoqQ4rpOkbIIZ h/NJTQLhfdonmfCFgfKU3Ni4l+2TK/7v2RvPHpy+M05tAnkjM7ZcZ2WKEYmC5jATqH1nbvwz2EX 1F4Dmeul5mxj3FmukvECtq2F+vfqjtwRcj0NndQmcj960Wl3g32CxV6W/tGAxVE+BzDq9yqaz+v FIAcjLufN1TvD4RbDYgJvJu3akJmm7TImya5obue2+EjTeFjvnOCF8Hkkm6TcSVYBOXIHdDspQ/ J7wGJuOXgtNmoPYqwkfTFWtZLsVxUjHP4gnI2I/GEUN2IcYe4bWIA9RnrJpSmRhZwqimOqYU4cA qh5jaRmwbayuRBnNyQMLbOxT1D2BWPb/DGUjxstcMoBvLmHu0efTQg4aZ4KM1k/+s6YUp59J5FQ G0AME= X-Google-Smtp-Source: AGHT+IGHnqUq6qhMw+8+QOCNGqZfJqkiKdZkMU3QPQCb7RcdfwN5RfqQ27Wgup/3i6q2X+NpNWmxjA== X-Received: by 2002:a05:6830:4c0e:b0:7c7:827f:872f with SMTP id 46e09a7af769-7cc66a5a9d7mr4103333a34.37.1766262348252; Sat, 20 Dec 2025 12:25:48 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc6673ccc2sm4240033a34.12.2025.12.20.12.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Dec 2025 12:25:47 -0800 (PST) From: Jens Axboe To: Thomas Fourier , Dan Carpenter Cc: "Md. Haris Iqbal" , Jack Wang , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH next] block: rnbd-clt: Fix signedness bug in init_dev() Message-Id: <176626234708.413702.6669635606958101937.b4-ty@kernel.dk> Date: Sat, 20 Dec 2025 13:25:47 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Sat, 20 Dec 2025 11:46:10 +0300, Dan Carpenter wrote: > The "dev->clt_device_id" variable is set using ida_alloc_max() which > returns an int and in particular it returns negative error codes. > Change the type from u32 to int to fix the error checking. > > Applied, thanks! [1/1] block: rnbd-clt: Fix signedness bug in init_dev() commit: 1ddb815fdfd45613c32e9bd1f7137428f298e541 Best regards, -- Jens Axboe