From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D87B332EA3 for ; Tue, 23 Dec 2025 12:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766493002; cv=none; b=Y093M51qRSqBgEwpZLOR8CXcvoaGecyHg4ciUoBkXtx6WZFqKVLbcVCAxI9A4jBR8Ewz1ByMkCfp44YBV//om/slx7zKLoM25Pd7G0SxowXb32U1t2SgEktleWhxQJqGQaTb5FvHOLMUiq6HKmeU15Ea/rEaQm2GWlKoMXEzHsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766493002; c=relaxed/simple; bh=DM2K62Tg0CBm/wIOPy2pMRcFMqVhU6v5NSJNGLDojaw=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=awBvCZ3Q8acSIBY7KyLk5H2/lBeIqN9Qu0TKAv5avdKbF1+C/x3b1ODLTjNUl31MYREfp/asuPW0DaVxkxNYCEqKit/6NNDXTWcVX9PVpYNuEQ2a7Ak0A0Ml3+WWTQfMp1054mLhN8oCWt1hBb0gh2BYkrb1ohbI/bxw7Dk0Pf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VG2eCwzS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H2eFGwuJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VG2eCwzS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H2eFGwuJ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BNATPtn1894837 for ; Tue, 23 Dec 2025 12:29:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2ffbG6iJcP+z5d4xqhzCeKpZMxj2hNcge9Gry8DMjRg=; b=VG2eCwzSAuLTBzBS cyN+WFz045WXQcDei+Hdlfd11Hw7mqZxT1oWwtVcCuHA8vsbEcLTYv+q7ppf2K/h 6YEC9QcBH0ZYNrmI6wSS/FEXD+5409iwJliT4Dvb7VBoEJEDFbl0amMUW/lgPPvX vvT6eVy3JXF/vTp92Ef7iElVmcjfNb0gM/6fCeytX8KpKQemA3QRcND5bdvuGoic ObK5am1BqKhMwqgEOhkQXR3CxtCnNbYa8K90a9ZmEKWAa07nff6BuXpEmVWHzRZ3 xWA/B+LWbBcNiwvCQTF2HChDHdDkdvU7kstDDWcClB5EOy+CM1FRInmfKUWrOYvT 8z39yQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b74takvaj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Dec 2025 12:29:59 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7fc82eff4adso4813568b3a.1 for ; Tue, 23 Dec 2025 04:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766492998; x=1767097798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2ffbG6iJcP+z5d4xqhzCeKpZMxj2hNcge9Gry8DMjRg=; b=H2eFGwuJ1NpZemS4lFewkphRTQMfLZagai2Ll4mkHKgS4bak4D69gzUObBn9a4xQvb TdPShWLu1Kzklu8F+jGn6gtH6+eePQiLsqBeX515II9T0LC8Ik5Q45FTOJk27z4uEvdM P6HjUs6vomJpjX51WzJMxAevC51ViIog7i0Z56xXBOf5o+APLAXaYEV2Xs2ZPzFKUu9/ WutgHZ1gu1rRRufyFAVjMPWArIVD7HXW8NsjOGCcYt02oQbHzZf6H5Gsh1UUL1y8ylxY D/0jyaV3LCI9oZT9YMZk+Q+uXX5T7OZ0ojWwMvxAh6bsGzmAanXrbtL8vHjW1JSNfw/G fc7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766492998; x=1767097798; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2ffbG6iJcP+z5d4xqhzCeKpZMxj2hNcge9Gry8DMjRg=; b=fj0GCtyL4RKHYP6j7ukvNZYwvvZ6bbgig2cMAPVSE5GLstZrVg9HHgY9pmceg/BFqs UvLb+W3QsmIFWWtRraKXC5m/cakSx5nwtOrCafQkdd76Orn7AZ2z+CkFe7MfYSyb4FzT REhC9gzP65N6VbYqiLk9eaD2W/UQ7P9kIKc9tzTnT/ZjADGmzcBFUSUmlhKDKZWZHcVx wOUtiMRufpFkCa2i/UPhTyP/7AKRX9WVFs8PwvpaPLyPMD0iKMwF+L9KNb5lrPdw1aGO qy/8IyZaXOZ5p3fjRed69NwZcnryOIV48Zn2wsx9RgSAQwRZlSD58gdlaJUqOGEfrSKf WUJA== X-Forwarded-Encrypted: i=1; AJvYcCW8WBj4nSbnxH5wQ2Xyb3s4WMiabRGUKb+dWHx4rCxsxfI5beZD+75TGfnhG5oP265DawuhUfmDy5MdHCo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2uq69xLfcBQ0HcYAFP6pRKb9FJvmv++CfI+CfZ/CGg64VUqyS ISn5JfxxDtIgtPCi3AmQAPMT+9Pa+hqgbT19RsuPY34W4msWsv5cmI+dhL3reRM5w4odGexV1ft 1shz0bql5QTkJZabgXiWYmvnnETcMDaCfbC6+30+u/bsjWCZ4SJ/Mz9ZoYgpaNDduZcigJepLSs Q= X-Gm-Gg: AY/fxX6tuyLtXFFrlwAYJfH1j9Dz15p6jSRx0ZDJYV0Jrbd6jmhyM4MEkxM7DIjnXzL QlouDVJ++luR9HTnE9Mp9KRODkkmAWd5gM130axaMYyPk0KAZ4BeCrsZ0GYlEgpAqXoO3rcSC2p AM7Rm4BsvkpM1SLpdY2zMIX1NawiY+9U8/5PNHvxGgGJXKd71NldzZ3kW9wu8uKmHlFR/jeaOfR g/0CqmV6JmDEdtbjmUWamI6AqqFrrTzECfSK6bhJx3zR+rL/hzDncYBzZlAS/CZKQ6d6yK7hKJf 7sT/MvDgXP/SBOcOt6aKo3i2zblZbR1QZj7q8rCiZgK2lYA9Wyc07LUJ95AzbAP5Dr9QN+Zcu/v /kSMPefcl X-Received: by 2002:a05:6a00:1d23:b0:7b0:1d84:8634 with SMTP id d2e1a72fcca58-7ff53501207mr12347219b3a.15.1766492998090; Tue, 23 Dec 2025 04:29:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKW+H73D9ksZ7fL/FG16dl2s55ZD5r9HDlncH90Y1SXkZ6xZ0B5TcR1RTF1oMqSDXvIjV3Tw== X-Received: by 2002:a05:6a00:1d23:b0:7b0:1d84:8634 with SMTP id d2e1a72fcca58-7ff53501207mr12347198b3a.15.1766492997644; Tue, 23 Dec 2025 04:29:57 -0800 (PST) Received: from [192.168.1.102] ([120.60.139.28]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e892926sm13647781b3a.66.2025.12.23.04.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 04:29:57 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kwilczynski@kernel.org, Haotian Zhang Cc: robh@kernel.org, bhelgaas@google.com, michal.simek@amd.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20251219021615.965-1-vulab@iscas.ac.cn> References: <20251119033301.518-1-vulab@iscas.ac.cn> <20251219021615.965-1-vulab@iscas.ac.cn> Subject: Re: [PATCH v3] PCI: xilinx: Fix INTx IRQ domain leak in error paths Message-Id: <176649299472.522673.6050154108234112363.b4-ty@kernel.org> Date: Tue, 23 Dec 2025 17:59:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Authority-Analysis: v=2.4 cv=DPiCIiNb c=1 sm=1 tr=0 ts=694a8b47 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=wbxd9xFQoh2bOL7BUxlcyw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=A4LZ0qbstxbIEDcu2eAA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: R8BzOxMDu1fbunPJ_a8Os-fD3mQPHwT4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIzMDEwMSBTYWx0ZWRfX0iv3kkeCuoqP gXzOlRIKT9LvFdptPj3THOvhX6mkLyV/EgqA9ZB5P5xKHvmqmQ114CMJI/1/Vdeibv+fmVMsWFN UYUrg8Hjy3jIfNIe50cKvxEZqYMGc2Iv/hNRVM4bkE2li3/blYAJTUMCLxUp2tB3fuvJpc5U5n+ FtbYxMNcdBKpVA/pjHRaOgBqjbMHQnsS3KPDQRVdBoOLteZeVEJJ7Rh0cRMn8Lm1FCL2Kt8H0Ix w9pk14hP4reUycKYMwbMTGj8ml0fs/DWDHSbVIapnxAUb20uLoAmiRjN2LNkRhE4cSyeFEUKQJO mVrqwuf1971rZuoqzQmb9XnKSlegi2TeTxxkUwAVpR/LWYDKtU1q/cxmDzebiK8FLKLSt9qg1XQ +LzGqmIXS8MNxJjHk3mgnaZ98gvApQ5CuAnFfJ/hNuPyck15qzL9eTKvfuO9LhNB5yuZY1mtA1u Zlb8LA8Dvx72wjdJzGw== X-Proofpoint-ORIG-GUID: R8BzOxMDu1fbunPJ_a8Os-fD3mQPHwT4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512230101 On Fri, 19 Dec 2025 10:16:15 +0800, Haotian Zhang wrote: > In xilinx_pcie_init_irq_domain(), if xilinx_allocate_msi_domains() > fails after pcie->leg_domain has been successfully created via > irq_domain_create_linear(), the function returns directly without > cleaning up the allocated IRQ domain, resulting in a resource leak. > In xilinx_free_msi_domains(), pcie->leg_domain is also neglected. > > Add irq_domain_remove() call in the error path to properly release the > IRQ domain before returning the error. Rename xilinx_free_msi_domains() > to xilinx_free_irq_domains() and add the release of pcie->leg_domain > in the function. > > [...] Applied, thanks! [1/1] PCI: xilinx: Fix INTx IRQ domain leak in error paths commit: f42b3c053b1554d66af6fe45bb1ef357464c0456 Best regards, -- Manivannan Sadhasivam