mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Mateusz Litwin <mateusz.litwin@nokia.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] spi: cadence-quadspi: Prevent indirect read timeouts
Date: Tue, 23 Dec 2025 17:07:17 +0000	[thread overview]
Message-ID: <176650963782.445653.10248419661863551247.b4-ty@kernel.org> (raw)
In-Reply-To: <20251218-cqspi_indirect_read_improve-v2-0-396079972f2a@nokia.com>

On Thu, 18 Dec 2025 22:33:03 +0100, Mateusz Litwin wrote:
> On the Stratix10 platform, indirect reads can become very slow due to lost
> interrupts and/or missed `complete()` calls, causing
> `wait_for_completion_timeout()` to expire.
> 
> Three issues were identified:
> 1) A race condition exists between the read loop and IRQ `complete()`
>    call:
>    An IRQ can call `complete()` after the inner loop ends, but before
>    `reinit_completion()`, losing the completion event and leading to
>    `wait_for_completion_timeout()` expire. This function will not return
>    an error because `bytes_to_read` > 0 (indicating data is already in the
>    FIFO) and the final `ret` value is overwritten by
>    `cqspi_wait_for_bit()` return value (indicating request completion),
>    masking the timeout.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: cadence-quadspi: Prevent lost complete() call during indirect read
      commit: d67396c9d697041b385d70ff2fd59cb07ae167e8
[2/2] spi: cadence-quadspi: Improve CQSPI_SLOW_SRAM quirk if flash is slow
      commit: 5bfbbf0a49ee4b5dcf46a3bfd4cd860d72cc887d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


  parent reply	other threads:[~2025-12-23 17:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18 21:33 Mateusz Litwin via B4 Relay
2025-12-18 21:33 ` [PATCH v2 1/2] spi: cadence-quadspi: Prevent lost complete() call during indirect read Mateusz Litwin via B4 Relay
2025-12-18 21:33 ` [PATCH v2 2/2] spi: cadence-quadspi: Improve CQSPI_SLOW_SRAM quirk if flash is slow Mateusz Litwin via B4 Relay
2025-12-23 17:07 ` Mark Brown [this message]
2025-12-30 10:36   ` [PATCH v2 0/2] spi: cadence-quadspi: Prevent indirect read timeouts Mateusz Litwin (Nokia)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176650963782.445653.10248419661863551247.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mateusz.litwin@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®