From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BA71E885A for ; Thu, 25 Dec 2025 15:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766675336; cv=none; b=AwocudIWWHwxkppqOhGQXHuDywVyaVXg6sJ+AeilwDC13ev/mzzyM39pgOybnuysutmCbxSz5qVbmILLwNLA8uNTGZH24O7W26C0fzlzsf/D3i7qloW3/lzVe3h898Uv3PbN4st6FaigbgVz/RC80+KFhGCUcxzn5M+Q0yyhuCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766675336; c=relaxed/simple; bh=1a8WVK/5R0u2R7uTPPcpwGnVq8+rcROVcLyIqeUBGAE=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=kwWLv+fK7b577EARcigw51RmIzQYMty/6aBljDoVCYmMlLRIXgiTzxBQHG9hw1L0rBEKW1LFFhXYqt7ZyPD0XNKEuHM65n4G9LJjrqWCWDMigDpZU/kOluUQ+p5450lZb53zKiX61lnmW7lW+H/DmIUBuYff34+JfQBIT0oGU38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=y47mcnct; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="y47mcnct" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-44fe903c1d6so1571026b6e.0 for ; Thu, 25 Dec 2025 07:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1766675334; x=1767280134; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4enrxTcJXMNYO4nBPNY3Xlx1Fas4M0tOaGVZ1+UN1kM=; b=y47mcncthDnI769p6rGhLZVqjvRvc+lOVw1hkhnC42UnzCu7Bb9iCYZLMZxbpdFSO9 jI/nlAsiPGZDvdY7g+cy+CJDn9g2mxe/ygo3QpYZwEsQAW7fUygMmJ5HFvqRINeEUThU mUtOXHqHe/erbTMOdVbuQL+X3NHcMoYzH7uWd32jFWiMhc5PGomsc9wOySFTsqn6jHSr M/UQbF6GDyiAPb0lEJ6iqYY/aGaTpGaqrM5BfRclKKgQBlO/ZAV+deKzQUbsoTAVMQbJ MqrgW8UBPenQTFJazvsjrEr/6d5ssotX6MOTbSVS9aDVIBS2Nr1/sknzo9/cHOO5QkWj 9u+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766675334; x=1767280134; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4enrxTcJXMNYO4nBPNY3Xlx1Fas4M0tOaGVZ1+UN1kM=; b=Kgesp74LYIXVNnDFLeBqY0EkXmFeXIHIBZbNA9ArkMSBN/gbif62ePhFwxOAXX3tl0 yhN+dHYggRXFD2RuXkSK/wSURI5/Vk5SAYGuuFZr4DkmTQNzVzgu4e3FCw07pGO6prFS +WUnuqxiIFnb+R5ga2gdcjI8cDhyR29jjgb3iE5IDPYGYWn0Mzq8yjTEffmg7R/K2JdT xwiz1/g6xYsTSTcFAAbbmO6GPzkwkmXqduRA4W+CQ8jCSGvw62VpVBZaSZY1FHf8r0ze qC1JvV03qoSFcH33a2+l/dDTlMozmBhp9CcAbijbk6f1C8+95QFOAnVFWmLsfK3uIPkn O4ZA== X-Forwarded-Encrypted: i=1; AJvYcCWB1z4mkZnZCXrljh768Xl0no3WuHtm5gakdNCBcZV+2HYh0jOUKvZwJsSSi8tUwebk7IxQtyXr4O4SzFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzHuh/8CYFvB2NPhmtLBLhNKAfOAioEHzDk34aQtpGZx9nqtDGN alQaQTAS4krNPEYwTGq62/8I0d5yf/w5KoNgYSOwnyzj392FbSjaq4eiOuOrXBq1n8Y= X-Gm-Gg: AY/fxX6kdt7G2vgJUloUpYGldxRW134CwZtBW/qM8noEfANTO8SWUeK1J6IFDcTKasj fhGf/A98A1T6qRCoYP7bW8i0HmJ+msNpvbRbnU9B74sb3ir67EKhfCkHASu4q4Wl4wM5Ih9CwQl 9KWXErISNfKnodDznUaIHhsOWnESE7WrMb6aLVoEqtUKKitw+WlnPHAx33bK4kU4x2yBBTLvT+c LCdcXC/h0ATw7zR+tPvawzYFW2bnFQDDNxCVGwrtspMVnbwKKNsUFKEBjHoW5VikZemH/6abXfz znDPp4jaN0oEcofpPpS0TMnBX6shDeJb+/vRlgaYHnaNN6XIKgEM+R+uMaPfCxWdLZWUQz4nCok TfSAYiNH7za/H++PwbvOCW2sCt2T/oDeTAfQsBHD1cZaY0PH8sA2n0+gYpNlizjGciXjoZpnW2H 4vNBk= X-Google-Smtp-Source: AGHT+IHvysv98JjOtrG/XeetHHlKyurM7jKSGEnAoF86eGaByvTJgHoycWQr3WJoF84WobCqIy6E9Q== X-Received: by 2002:a05:6808:1b1e:b0:450:c9c3:a249 with SMTP id 5614622812f47-457b21cfc2amr10228559b6e.45.1766675333911; Thu, 25 Dec 2025 07:08:53 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 5614622812f47-457b3edb41fsm9481403b6e.18.2025.12.25.07.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 07:08:52 -0800 (PST) From: Jens Axboe To: Prithvi Tambewagh Cc: io-uring@vger.kernel.org, brauner@kernel.org, jack@suse.cz, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, syzbot+00e61c43eb5e4740438f@syzkaller.appspotmail.com, stable@vger.kernel.org In-Reply-To: <20251225072829.44646-1-activprithvi@gmail.com> References: <20251225072829.44646-1-activprithvi@gmail.com> Subject: Re: [PATCH v2] io_uring: fix filename leak in __io_openat_prep() Message-Id: <176667533028.68806.11770987520631890583.b4-ty@kernel.dk> Date: Thu, 25 Dec 2025 08:08:50 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Thu, 25 Dec 2025 12:58:29 +0530, Prithvi Tambewagh wrote: > __io_openat_prep() allocates a struct filename using getname(). However, > for the condition of the file being installed in the fixed file table as > well as having O_CLOEXEC flag set, the function returns early. At that > point, the request doesn't have REQ_F_NEED_CLEANUP flag set. Due to this, > the memory for the newly allocated struct filename is not cleaned up, > causing a memory leak. > > [...] Applied, thanks! [1/1] io_uring: fix filename leak in __io_openat_prep() commit: b14fad555302a2104948feaff70503b64c80ac01 Best regards, -- Jens Axboe