From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFBC620ED; Sun, 28 Dec 2025 11:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766920733; cv=none; b=LdhPIjCuoQ0fbScSTVlUEmtQlQf492qcxl9e0Wzhn5qEdAnynxbUjbx3mPw8VG2eHI6EI0JqH2XytaRl00PX2D659Pj5MC8Kihv0w4YbVPTqJiTqNlGFgvjwvId7aKIQf+J9cxBAsneFY3t1YmTZ8atJQTj/gtKnKH+nloddbTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766920733; c=relaxed/simple; bh=GRVTmmcDoCG9ClW3xDmBuTQe7S6wyOdOCLlfZEbSI18=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=ZKb0EDhFQqInev25T0VOzR81BsJqxytj/GQOdeL9XfhJM5smGjLGE9KEdiIA9DW5iZP1Otzx7Z7Hj9cRV7PYylwFQ8EriYHLAjMUegEvTrt9/AMHpMf4MupZIQu5zlD7aNINsl/Z2NoYd/8xXIQJpL+hT7YoUuGJvgk6CW2Fi6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p6CMOcAC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p6CMOcAC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FD83C4CEFB; Sun, 28 Dec 2025 11:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766920732; bh=GRVTmmcDoCG9ClW3xDmBuTQe7S6wyOdOCLlfZEbSI18=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=p6CMOcACMr3nzMJOJph1eQZv4qUwu3VEju3ijRhTCizxX8AfVGXz3rtR5iZt89S2L 4n1OylE531WyTGlgU5i2Bq6G+27pde83BsUBset+PDq72azTJbrU1mlTSqXSkBKc4F 5Tu3S6Jsej6wArw6KACmdcZuoGGm13ykKXJQbQLG1nW5NmbHetTIfTif9/30KLdBoW TbeqxAJa8BLxRWwxQAXoQlb4lOvgF3igdLclx09HCh5gb95vWamOn94MQlQahld+yv sQMscTHGWeMSHzj9EC93pQICvJ1xRAtzZei1a5LiZZoUDpPOihvfCJWubC2wQIWolD iwmVITPw9YwBQ== From: Krzysztof Kozlowski To: zbr@ioremap.net, minimumlaw@rambler.ru, gregkh@linuxfoundation.org, Haoxiang Li Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20251218111414.564403-1-lihaoxiang@isrc.iscas.ac.cn> References: <20251218111414.564403-1-lihaoxiang@isrc.iscas.ac.cn> Subject: Re: [PATCH] w1: fix redundant counter decrement in w1_attach_slave_device() Message-Id: <176692073090.56515.4804717383085601959.b4-ty@kernel.org> Date: Sun, 28 Dec 2025 12:18:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Thu, 18 Dec 2025 19:14:14 +0800, Haoxiang Li wrote: > In w1_attach_slave_device(), if __w1_attach_slave_device() fails, > put_device() -> w1_slave_release() is called to do the cleanup job. > In w1_slave_release(), sl->family->refcnt and sl->master->slave_count > have already been decremented. There is no need to decrement twice > in w1_attach_slave_device(). > > > [...] Applied, thanks! [1/1] w1: fix redundant counter decrement in w1_attach_slave_device() https://git.kernel.org/krzk/linux-w1/c/cc8f92e41eb76f450f05234fef2054afc3633100 Best regards, -- Krzysztof Kozlowski