mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, sre@kernel.org,
	 bsp-development.geo@leica-geosystems.com,
	linux-pm@vger.kernel.org,  krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/3] dt-bindings: power: sbs-battery: add polling interval property
Date: Mon, 29 Dec 2025 04:36:04 -0600	[thread overview]
Message-ID: <176700456483.502292.1935553390982118898.robh@kernel.org> (raw)
In-Reply-To: <20251229085636.4082852-2-Qing-wu.Li@leica-geosystems.com.cn>


On Mon, 29 Dec 2025 08:56:35 +0000, LI Qingwu wrote:
> Add the optional sbs,monitoring-interval-ms property for SBS-compliant
> batteries to configure a periodic polling interval on systems without
> interrupt support. The driver periodically checks the battery status and
> notifies userspace of changes when this property is set, and ignores it
> when a GPIO interrupt is available.
> 
> The property defaults to 0 to preserve existing behaviour.
> 
> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> ---
>  .../bindings/power/supply/sbs,sbs-battery.yaml           | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml: properties:sbs,monitoring-interval-ms: '$ref' should not be valid under {'const': '$ref'}
	hint: Standard unit suffix properties don't need a type $ref
	from schema $id: http://devicetree.org/meta-schemas/core.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20251229085636.4082852-2-Qing-wu.Li@leica-geosystems.com.cn

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-12-29 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29  8:56 [PATCH V1 1/3] power: supply: sbs-battery: Fix false presence when registers read zero LI Qingwu
2025-12-29  8:56 ` [PATCH V1 2/3] dt-bindings: power: sbs-battery: add polling interval property LI Qingwu
2025-12-29  9:16   ` Krzysztof Kozlowski
2025-12-29  9:50     ` LI Qingwu
2025-12-29 12:47       ` Krzysztof Kozlowski
2025-12-30  9:40         ` LI Qingwu
2025-12-30  9:46           ` Krzysztof Kozlowski
2025-12-29 10:36   ` Rob Herring (Arm) [this message]
2025-12-29  8:56 ` [PATCH V1 3/3] power: supply: sbs-battery: Add optional status monitoring LI Qingwu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176700456483.502292.1935553390982118898.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Qing-wu.Li@leica-geosystems.com.cn \
    --cc=bsp-development.geo@leica-geosystems.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®