mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,  romain.perier@gmail.com
Subject: Re: [PATCH v2 1/8] dt-bindings: clk: mstar msc313 cpupll: Correct clock-cells value
Date: Wed, 31 Dec 2025 22:33:34 -0600	[thread overview]
Message-ID: <176724201428.245927.50135278414047771.robh@kernel.org> (raw)
In-Reply-To: <20260101034306.1233091-2-daniel@0x0f.com>


On Thu, 01 Jan 2026 12:42:59 +0900, Daniel Palmer wrote:
> clock-cells should have been 0 and causes warnings when
> validating devicetrees.
> 
> Fix the value and fix the binding example.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
>  .../devicetree/bindings/clock/mstar,msc313-cpupll.yaml       | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Lexical error: Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.example.dts:22.29-51 Unexpected 'MSTAR_MSC313_MPLL_DIV2'
FATAL ERROR: Syntax error parsing input tree
make[2]: *** [scripts/Makefile.dtbs:145: Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1565: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260101034306.1233091-2-daniel@0x0f.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-01-01  4:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-01  3:42 [PATCH v2 0/8] Sigmastar DT warnings fixing Daniel Palmer
2026-01-01  3:42 ` [PATCH v2 1/8] dt-bindings: clk: mstar msc313 cpupll: Correct clock-cells value Daniel Palmer
2026-01-01  4:33   ` Rob Herring (Arm) [this message]
2026-01-02 10:15   ` Krzysztof Kozlowski
2026-01-01  3:43 ` [PATCH v2 2/8] arm: dts: mstar: breadbee: Correct regulator names Daniel Palmer
2026-01-01  3:43 ` [PATCH v2 3/8] arm: dts: mstar: breadbee: Correct LED names Daniel Palmer
2026-01-01  3:43 ` [PATCH v2 4/8] arm: dts: mstar: breadbee: Switch from "activity" led trigger to "cpu" Daniel Palmer
2026-01-01  3:43 ` [PATCH v2 5/8] arm: dts: mstar: infinity: Correct opp table name Daniel Palmer
2026-01-01  3:43 ` [PATCH v2 6/8] arm: dts: mstar: infinity2m: ssd202d: Correct memory node name Daniel Palmer
2026-01-01  3:43 ` [PATCH v2 7/8] arm: dts: mstar: v7: Move the reboot node Daniel Palmer
2026-01-01  3:43 ` [PATCH v2 8/8] arm: dts: mstar: v7: Add sizes and ranges to sram Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176724201428.245927.50135278414047771.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romain.perier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®