mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Krzysztof Kozlowski <krzk@kernel.org>,
	devicetree@vger.kernel.org,
	 Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	 linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	 linux-bluetooth@vger.kernel.org,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Matthias Kaehlcke <mka@chromium.org>,
	linux-kernel@vger.kernel.org,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	 Marcel Holtmann <marcel@holtmann.org>,
	linux-wireless@vger.kernel.org,
	 Manivannan Sadhasivam <mani@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	 Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	 ath10k@lists.infradead.org
Subject: Re: [PATCH 00/14] power: sequencing: extend WCN driver to support WCN399x device
Date: Fri, 02 Jan 2026 08:43:32 -0600	[thread overview]
Message-ID: <176736452702.3671432.8334984298495582439.robh@kernel.org> (raw)
In-Reply-To: <20251231-wcn3990-pwrctl-v1-0-1ff4d6028ad5@oss.qualcomm.com>


On Wed, 31 Dec 2025 01:35:50 +0200, Dmitry Baryshkov wrote:
> Qualcomm WCN3950, WCN3988 and WCN399x families of WiFi/BT chips preceed
> the later WCN / QCA devices, but they still incorporate a very simple
> PMU on die. It controls internal on-chip power networks, but, most
> importantly, it also requires a certain start-up procedure (first bring
> up VDD_IO, then bring up other voltages). In order to further unify code
> supporting different families of QCA / WCN chips and in order to
> maintain the required power up sequence, properly represent these chips
> in DTs and modify drivers to use power sequencing for these chips.
> 
> Backwards compatibility with the existing DTs is retained by keeping the
> regulator&clock code in the drivers as a fallback.
> 
> As a part of the series I've converted only several boards, verifying
> that all known instances of WCN39xx family works (fixing the issues
> meanwhile). The rest of devices might follow the pattern later.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Dmitry Baryshkov (14):
>       regulator: dt-bindings: qcom,qca6390-pmu: describe PMUs on WCN39xx
>       Bluetooth: qca: enable pwrseq support for WCN39xx devices
>       Bluetooth: qca: fix ROM version reading on WCN3998 chips
>       wifi: ath10k: snoc: support powering on the device via pwrseq
>       power: sequencing: qcom-wcn: add support for WCN39xx
>       arm64: dts: qcom: qrb4210-rb2: Fix UART3 wakeup IRQ storm
>       arm64: dts: qcom: sdm845-db845c: drop CS from SPIO0
>       arm64: dts: qcom: sdm845-db845c: specify power for WiFi CH1
>       arm64: dts: qcom: sm8150: add uart13
>       arm64: dts: qcom: qrb2210-rb1: describe WiFi/BT properly
>       arm64: dts: qcom: qrb4210-rb2: describe WiFi/BT properly
>       arm64: dts: qcom: sda660-ifc6560: describe WiFi/BT properly
>       arm64: dts: qcom: sdm845-db845c: describe WiFi/BT properly
>       arm64: dts: qcom: sm8150-hdk: describe WiFi/BT properly
> 
>  .../bindings/regulator/qcom,qca6390-pmu.yaml       |  36 ++++++
>  arch/arm64/boot/dts/qcom/qrb2210-rb1.dts           |  60 +++++++--
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts           |  62 +++++++--
>  .../arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts |  66 ++++++++--
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts         |  75 +++++++++--
>  arch/arm64/boot/dts/qcom/sm8150-hdk.dts            | 141 ++++++++++++++++++++-
>  arch/arm64/boot/dts/qcom/sm8150.dtsi               |   9 ++
>  drivers/bluetooth/btqca.c                          |   2 +
>  drivers/bluetooth/hci_qca.c                        |  26 ++--
>  drivers/net/wireless/ath/ath10k/snoc.c             |  43 ++++++-
>  drivers/net/wireless/ath/ath10k/snoc.h             |   2 +
>  drivers/power/sequencing/pwrseq-qcom-wcn.c         | 130 ++++++++++++++++++-
>  12 files changed, 596 insertions(+), 56 deletions(-)
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20251229-wcn3990-pwrctl-cfa64f9d8167
> 
> Best regards,
> --
> With best wishes
> Dmitry
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251231-wcn3990-pwrctl-v1-0-1ff4d6028ad5@oss.qualcomm.com:

arch/arm64/boot/dts/qcom/qrb2210-rb1.dtb: wcn3950-pmu (qcom,wcn3950-pmu): 'vddch1-supply' is a required property
	from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
arch/arm64/boot/dts/qcom/qrb4210-rb2.dtb: wcn3988-pmu (qcom,wcn3988-pmu): 'vddch1-supply' is a required property
	from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml






      parent reply	other threads:[~2026-01-02 14:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30 23:35 Dmitry Baryshkov
2025-12-30 23:35 ` [PATCH 01/14] regulator: dt-bindings: qcom,qca6390-pmu: describe PMUs on WCN39xx Dmitry Baryshkov
2026-01-02 10:54   ` Bartosz Golaszewski
2026-01-02 12:23   ` Krzysztof Kozlowski
2025-12-30 23:35 ` [PATCH 02/14] Bluetooth: qca: enable pwrseq support for WCN39xx devices Dmitry Baryshkov
2026-01-02 10:57   ` Bartosz Golaszewski
2025-12-30 23:35 ` [PATCH 03/14] Bluetooth: qca: fix ROM version reading on WCN3998 chips Dmitry Baryshkov
2025-12-31 12:04   ` Konrad Dybcio
2025-12-31 15:02     ` Dmitry Baryshkov
2025-12-30 23:35 ` [PATCH 04/14] wifi: ath10k: snoc: support powering on the device via pwrseq Dmitry Baryshkov
2026-01-02 11:07   ` Bartosz Golaszewski
2026-01-02 15:09     ` Dmitry Baryshkov
2026-01-02 17:06       ` Bartosz Golaszewski
2026-01-02 23:24         ` Dmitry Baryshkov
2026-01-05 12:46           ` Bartosz Golaszewski
2025-12-30 23:35 ` [PATCH 05/14] power: sequencing: qcom-wcn: add support for WCN39xx Dmitry Baryshkov
2026-01-02 11:02   ` Bartosz Golaszewski
2025-12-30 23:35 ` [PATCH 06/14] arm64: dts: qcom: qrb4210-rb2: Fix UART3 wakeup IRQ storm Dmitry Baryshkov
2025-12-31 12:07   ` Konrad Dybcio
2025-12-30 23:35 ` [PATCH 07/14] arm64: dts: qcom: sdm845-db845c: drop CS from SPIO0 Dmitry Baryshkov
2025-12-31 12:07   ` Konrad Dybcio
2025-12-30 23:35 ` [PATCH 08/14] arm64: dts: qcom: sdm845-db845c: specify power for WiFi CH1 Dmitry Baryshkov
2025-12-31 12:09   ` Konrad Dybcio
2025-12-31 16:19     ` Dmitry Baryshkov
2025-12-31 16:20       ` Konrad Dybcio
2025-12-30 23:35 ` [PATCH 09/14] arm64: dts: qcom: sm8150: add uart13 Dmitry Baryshkov
2025-12-31 12:10   ` Konrad Dybcio
2025-12-30 23:36 ` [PATCH 10/14] arm64: dts: qcom: qrb2210-rb1: describe WiFi/BT properly Dmitry Baryshkov
2025-12-31 12:17   ` Konrad Dybcio
2026-01-02 10:51   ` Bartosz Golaszewski
2025-12-30 23:36 ` [PATCH 11/14] arm64: dts: qcom: qrb4210-rb2: " Dmitry Baryshkov
2025-12-31 12:18   ` Konrad Dybcio
2026-01-02 10:33   ` Bartosz Golaszewski
2025-12-30 23:36 ` [PATCH 12/14] arm64: dts: qcom: sda660-ifc6560: " Dmitry Baryshkov
2025-12-31 12:19   ` Konrad Dybcio
2025-12-31 16:20     ` Dmitry Baryshkov
2026-01-02 10:52   ` Bartosz Golaszewski
2025-12-30 23:36 ` [PATCH 13/14] arm64: dts: qcom: sdm845-db845c: " Dmitry Baryshkov
2025-12-31 12:20   ` Konrad Dybcio
2026-01-02 10:53   ` Bartosz Golaszewski
2025-12-30 23:36 ` [PATCH 14/14] arm64: dts: qcom: sm8150-hdk: " Dmitry Baryshkov
2025-12-31 12:16   ` Konrad Dybcio
2025-12-31 17:12     ` Dmitry Baryshkov
2025-12-31 17:13       ` Konrad Dybcio
2026-01-02 10:51   ` Bartosz Golaszewski
2026-01-02 14:43 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176736452702.3671432.8334984298495582439.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=ath10k@lists.infradead.org \
    --cc=brgl@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=mani@kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mka@chromium.org \
    --cc=quic_bgodavar@quicinc.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®