From: "tip-bot2 for Marco Elver" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Marco Elver <elver@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: locking/core] printk: Move locking annotation to printk.c
Date: Mon, 05 Jan 2026 15:54:13 -0000 [thread overview]
Message-ID: <176762845309.510.13863378320054723020.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20251219154418.3592607-34-elver@google.com>
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 8ec56d9aaba9667b0c6429de7aeb4ec691944a5e
Gitweb: https://git.kernel.org/tip/8ec56d9aaba9667b0c6429de7aeb4ec691944a5e
Author: Marco Elver <elver@google.com>
AuthorDate: Fri, 19 Dec 2025 16:40:22 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 05 Jan 2026 16:43:36 +01:00
printk: Move locking annotation to printk.c
With Sparse support gone, Clang is a bit more strict and warns:
./include/linux/console.h:492:50: error: use of undeclared identifier 'console_mutex'
492 | extern void console_list_unlock(void) __releases(console_mutex);
Since it does not make sense to make console_mutex itself global, move
the annotation to printk.c. Context analysis remains disabled for
printk.c.
This is needed to enable context analysis for modules that include
<linux/console.h>.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20251219154418.3592607-34-elver@google.com
---
include/linux/console.h | 4 ++--
kernel/printk/printk.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/console.h b/include/linux/console.h
index fc9f5c5..f882833 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -492,8 +492,8 @@ static inline bool console_srcu_read_lock_is_held(void)
extern int console_srcu_read_lock(void);
extern void console_srcu_read_unlock(int cookie);
-extern void console_list_lock(void) __acquires(console_mutex);
-extern void console_list_unlock(void) __releases(console_mutex);
+extern void console_list_lock(void);
+extern void console_list_unlock(void);
extern struct hlist_head console_list;
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 1d765ad..37d16ef 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -245,6 +245,7 @@ int devkmsg_sysctl_set_loglvl(const struct ctl_table *table, int write,
* For console list or console->flags updates
*/
void console_list_lock(void)
+ __acquires(&console_mutex)
{
/*
* In unregister_console() and console_force_preferred_locked(),
@@ -269,6 +270,7 @@ EXPORT_SYMBOL(console_list_lock);
* Counterpart to console_list_lock()
*/
void console_list_unlock(void)
+ __releases(&console_mutex)
{
mutex_unlock(&console_mutex);
}
next prev parent reply other threads:[~2026-01-05 15:54 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 15:39 [PATCH v5 00/36] Compiler-Based Context- and Locking-Analysis Marco Elver
2025-12-19 15:39 ` [PATCH v5 01/36] compiler_types: Move lock checking attributes to compiler-context-analysis.h Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 02/36] compiler-context-analysis: Add infrastructure for Context Analysis with Clang Marco Elver
2025-12-19 18:38 ` Bart Van Assche
2025-12-19 18:59 ` Marco Elver
2025-12-19 19:04 ` Bart Van Assche
2025-12-19 19:11 ` Marco Elver
2025-12-20 13:33 ` Peter Zijlstra
2026-01-05 15:53 ` [tip: locking/core] tags: Add regex for context_lock_struct tip-bot2 for Peter Zijlstra
2026-01-05 15:54 ` [tip: locking/core] compiler-context-analysis: Add infrastructure for Context Analysis with Clang tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 03/36] compiler-context-analysis: Add test stub Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 04/36] Documentation: Add documentation for Compiler-Based Context Analysis Marco Elver
2025-12-19 18:51 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 05/36] checkpatch: Warn about context_unsafe() without comment Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 06/36] cleanup: Basic compatibility with context analysis Marco Elver
2025-12-19 19:16 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-06 13:21 ` [PATCH v5 06/36] " Tetsuo Handa
2026-01-06 17:34 ` Marco Elver
2026-01-27 10:14 ` Lorenzo Stoakes
2026-01-27 10:17 ` Marco Elver
2026-01-27 10:21 ` Lorenzo Stoakes
2025-12-19 15:39 ` [PATCH v5 07/36] lockdep: Annotate lockdep assertions for " Marco Elver
2025-12-19 20:53 ` Bart Van Assche
2025-12-19 21:16 ` Marco Elver
2025-12-19 21:28 ` Bart Van Assche
2025-12-19 21:47 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 08/36] locking/rwlock, spinlock: Support Clang's " Marco Elver
2025-12-19 20:26 ` Bart Van Assche
2025-12-19 21:02 ` Marco Elver
2025-12-19 21:34 ` Bart Van Assche
2025-12-19 21:48 ` Marco Elver
2025-12-19 21:45 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 09/36] compiler-context-analysis: Change __cond_acquires to take return value Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 10/36] locking/mutex: Support Clang's context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-08 22:10 ` [PATCH v5 10/36] " Bart Van Assche
2026-01-08 23:26 ` Marco Elver
2026-01-09 6:02 ` Christoph Hellwig
2026-01-09 13:07 ` Steven Rostedt
2026-01-10 3:23 ` Marco Elver
2025-12-19 15:40 ` [PATCH v5 11/36] locking/seqlock: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 12/36] bit_spinlock: Include missing <asm/processor.h> Marco Elver
2025-12-19 20:38 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 13/36] bit_spinlock: Support Clang's context analysis Marco Elver
2025-12-19 20:47 ` Bart Van Assche
2025-12-19 21:09 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 14/36] rcu: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 15/36] srcu: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-26 17:31 ` [PATCH v5 15/36] " Bart Van Assche
2026-01-26 18:35 ` Marco Elver
2026-01-26 18:54 ` Bart Van Assche
2026-01-26 21:35 ` Peter Zijlstra
2026-01-26 23:46 ` Marco Elver
2025-12-19 15:40 ` [PATCH v5 16/36] kref: Add context-analysis annotations Marco Elver
2025-12-19 20:49 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 17/36] locking/rwsem: Support Clang's context analysis Marco Elver
2025-12-19 20:55 ` Bart Van Assche
2025-12-20 12:52 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 18/36] locking/local_lock: Include missing headers Marco Elver
2025-12-19 20:56 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 19/36] locking/local_lock: Support Clang's context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 20/36] locking/ww_mutex: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-09 20:16 ` [PATCH v5 20/36] " Bart Van Assche
2026-01-09 21:06 ` Marco Elver
2026-01-09 21:26 ` Bart Van Assche
2026-01-12 10:32 ` Maarten Lankhorst
2025-12-19 15:40 ` [PATCH v5 21/36] debugfs: Make debugfs_cancellation a context lock struct Marco Elver
2025-12-19 21:01 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 22/36] um: Fix incorrect __acquires/__releases annotations Marco Elver
2025-12-19 21:05 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 23/36] compiler-context-analysis: Remove Sparse support Marco Elver
2025-12-19 21:38 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 24/36] compiler-context-analysis: Remove __cond_lock() function-like helper Marco Elver
2025-12-19 21:42 ` Bart Van Assche
2025-12-20 12:51 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 25/36] compiler-context-analysis: Introduce header suppressions Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 26/36] compiler: Let data_race() imply disabled context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 27/36] MAINTAINERS: Add entry for Context Analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 28/36] kfence: Enable context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 29/36] kcov: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 30/36] kcsan: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 31/36] stackdepot: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 32/36] rhashtable: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 33/36] printk: Move locking annotation to printk.c Marco Elver
2026-01-05 15:54 ` tip-bot2 for Marco Elver [this message]
2025-12-19 15:40 ` [PATCH v5 34/36] security/tomoyo: Enable context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 35/36] crypto: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 36/36] sched: Enable context analysis for core.c and fair.c Marco Elver
2026-01-05 15:53 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-12 22:04 ` [PATCH v5 36/36] " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176762845309.510.13863378320054723020.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®