From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991012D97B9 for ; Mon, 5 Jan 2026 20:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644163; cv=none; b=cypaPxLqCBFMeXSMxcW3n6aLcIVVKey7XIv5QZ4O8QcbvhCqqcBsi6h3A2DBzyuUA0z1aKOEb7yng/VDno7xeFWQJKcu+VcxeBt3Z5D2Mp/PdCTF6729ZAejLa8//VadYUPscimHXzIePwTCbh5wUzGTzQwUpaLNVs5knzdNh8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767644163; c=relaxed/simple; bh=GlAGxw60887sAVyf2r1P8gsyI6ZDN3dTFENSsBfZeRc=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=FgJfdb3Dd8+E0nA/A2MHVIzyuZ9y3pvuZXxhEpWS6egZ5LLwsLhyLciVA3rYRnMf+pNTbqPrYT1M3gDf5BHOTVjSskx3G/VNN0JDUpeZv/3Pc2IO7x7C7iihvccK7TKFwAuOh1mg0/ZcVLq24phTR6oS9A2NXo5stMYPFlakQzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lrM8fBzg; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lrM8fBzg" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7a9c64dfa8aso294912b3a.3 for ; Mon, 05 Jan 2026 12:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1767644160; x=1768248960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kZSZZ0NcHIRuKJcx81Mh2IbInHyMIKpBF4sIqpjFN2E=; b=lrM8fBzg0mP8LvWc99uydqSvaZKMe4TXqcPBJR+PmMydhJ+yCbBV7QnqioTGPSF1E9 TQCBvW7cWFDkNzTfhG97dzIdVZjBm4AfuNyNH/k35DtfEROf9AXXSDfWQtypagGgeGvW D43xqTTuHnd8qnepmJiii4BdsnFTEe1vFTOvYc8qberS/TIunFh27eXdSz1oegL/zdzj YZ6klUjPsTjrxnGJjz6zz0sf0jkFBn7wk4i8Ok87gP+0BR29g0peMO7tD4s7BNVZ/Rx0 DZT2xEnzpZhw/MN2X4d62gjHJr0Y2kDiKgn9iMiYBvYwi7hVfm4BDXdrlXYorCs9eE+J 4xMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767644160; x=1768248960; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kZSZZ0NcHIRuKJcx81Mh2IbInHyMIKpBF4sIqpjFN2E=; b=GqT6GHOijxZ/ZzxFBtRIagTMQg8CzcSc70/3f6c5oACvZ/K1qUpdXVynbSS4tHLAjj E7pdzADmWVCd7tFqNI/zP6mxJIU5iNbi/smv/kB52xboExXbcB+sIsby7+Ayx0mYhu2i hg2F73LDo7APodizbXZf/gYs4t6K7wbU8yxvPpuIm/rT7NgrWZnovcdWuOFBLX3yR/yY xpXy3P2oQotAmUMjREVa/1wCKTgPBAKXI9H0tCQIGT1gQggl66yJP+kGslgLeFEUqwnP 7x4SBUcE+8DP9WCG2OdWEJ3Mv1LS/aWJmDYD79RqIvutfacBJ684u4y6q6alRC6hPTGN luiQ== X-Forwarded-Encrypted: i=1; AJvYcCVusOg4tGA9qllpR+PurjV9t+cjKPxDL1rgrN56hXDt1gEcs5HsoR/zB6lmF3ziBj22Gcf1k80FAx2rtoU=@vger.kernel.org X-Gm-Message-State: AOJu0YxdxUlu7H05Y7uwXG6y1Hlro0UDeeFhLVRHpGDnTdZIBBzoNJsl Z2oLOds1xyMVHEWhYaVy0TggP+iOVDoifrCULO+r7hddsxAvqsHDQc8xCwe94Cvfv88= X-Gm-Gg: AY/fxX5yI7oPa0K1g4g5pOkbHr2q+gMyRuga9Nx64Dn9pGKssvKC43R9b7O0oWl5oBp QLtcChKiyrEmFT6Hb1V8Lm7+M2Lxio/PD67H1KrjIOl1o947WtKqNSy0DNHjUHxkgeZXjfsj37d 8y3yoUrOc4w/s24fSiAJZKSTZqiy0WBlSIPnRePxLdCt3q9G26a7VZoQhaWRB7GGOnNeUonDMTG f3PBfcoj8EWmngE+oXyKmtNMjz2u9zUfVwXlaAi9s7t5e8Ui0WHPzeWsMYu4k14eKZX3vG46SOP ZbRsO90a3uhWDWiFz8nO+iI+vBBMCQDjy6SFSYlRJU0+bXApT48eKDbjwD/U+vNTe+k8OjOgxSK B9SMjaOecUeSKOf4t7kj19cHzHovwjxKbHxESvw9YtnYvqh/ujKaAY+Cp4rp+fbkJKIscKwnsue OfLle2zVh0 X-Google-Smtp-Source: AGHT+IEHjjpFYWzc2Wq0J1oiLBzWArBe54oz0YlfSqH0xF0+40Jt6FjOez5/4L3fR9/GkZAWrm4pOQ== X-Received: by 2002:a05:6a00:430b:b0:7e8:43f5:bd59 with SMTP id d2e1a72fcca58-81880383fddmr689923b3a.69.1767644160587; Mon, 05 Jan 2026 12:16:00 -0800 (PST) Received: from localhost ([71.212.208.158]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c5302c61sm22217b3a.42.2026.01.05.12.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 12:16:00 -0800 (PST) From: Kevin Hilman To: aaro.koskinen@iki.fi, andreas@kemnade.info, rogerq@kernel.org, tony@atomide.com, linux@armlinux.org.uk, Wentao Liang Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20251217142122.1861292-1-vulab@iscas.ac.cn> References: <20251217142122.1861292-1-vulab@iscas.ac.cn> Subject: Re: [PATCH] ARM: omap2: Fix reference count leaks in omap_control_init() Message-Id: <176764415968.2561401.11587667060875531413.b4-ty@baylibre.com> Date: Mon, 05 Jan 2026 12:15:59 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.15-dev-a6db3 On Wed, 17 Dec 2025 14:21:22 +0000, Wentao Liang wrote: > The of_get_child_by_name() function increments the reference count > of child nodes, causing multiple reference leaks in omap_control_init(): > > 1. scm_conf node never released in normal/error paths > 2. clocks node leak when checking existence > 3. Missing scm_conf release before np in error paths > > [...] Applied, thanks! [1/1] ARM: omap2: Fix reference count leaks in omap_control_init() commit: 93a04ab480c8bbcb7d9004be139c538c8a0c1bc8 Best regards, -- Kevin Hilman