From: "Rob Herring (Arm)" <robh@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH] of: property: stop creating callback for each pinctrl-N property
Date: Tue, 6 Jan 2026 10:27:09 -0600 [thread overview]
Message-ID: <176771682221.2176029.6949882881378864931.robh@kernel.org> (raw)
In-Reply-To: <20251219121811.390988-1-linux@rasmusvillemoes.dk>
On Fri, 19 Dec 2025 13:18:11 +0100, Rasmus Villemoes wrote:
> While not a lot in the grand scheme of things, this eliminates 8*2
> pointless function calls for almost every property present in the
> device tree (the exception are the few properties that were already
> matched). It also seems to reduce .text by about 1.5K - why gcc
> decides to inline parse_prop_cells() in every instantiation I don't know.
>
> Supporting double-digit suffixes would still require tweaking, but it
> does match pinctrl-9.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/of/property.c | 32 ++++++++++++++------------------
> 1 file changed, 14 insertions(+), 18 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2026-01-06 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 12:18 Rasmus Villemoes
2025-12-19 14:18 ` Rob Herring
2025-12-22 10:18 ` Rasmus Villemoes
2026-01-06 16:27 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176771682221.2176029.6949882881378864931.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®