From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20CE9253B42 for ; Wed, 7 Jan 2026 02:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767751853; cv=none; b=ulAYqWKZ72Du2pwjlRqFrTYFP+Qa8zKwZfJaZbh+j0v7pYe2un6k+ka+yqBfsZjngcM5kVte6EJZEE2SeRrFaksfbedaoLF41yIrwJCdOYG0LS9n/tQnGkwRbQpP4RTxlJ2EdFqKaAMP8uy4+JSn5cA1poAFk0gO6esGUzOWH08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767751853; c=relaxed/simple; bh=CaibCJhvL55waHquyt1b0Ro+XASHw/tKbBumUPMIUkY=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=lChMgliG57/NLtmnE6HiN7R2SK7WsXE779KQ7V+EJG/6pcq5g98ArVj4e1JVpCIp7oXAMJKiTntqLNFqKZ9/+AUVvDpwgCKXTL7H5XdgHX6j3CgW9NBfJXnxxPVxQTd3WRM7VMsSDVzvqTuZyVblxG8p75v0+n2EQMTV3eKY4Y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=rMw5Unk2; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="rMw5Unk2" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7c6d13986f8so331304a34.0 for ; Tue, 06 Jan 2026 18:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1767751850; x=1768356650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hGO9V6t38pWhRcUjuKcEmhXixM/ugRlM9F+VeEvQ1Sk=; b=rMw5Unk2NgEm31ZQKzkk3tj08RNE5jiLP9tkejreXq5KjLbri2Krbqp7knmt+FZzDx T+wesA9628SmVLzV7b/qqXT1kJunSWyV4Rq5eC8dBd74SSl5kBASAdlSP8/JOFG46YDp Qse/yVf0vUJVWwve2rXheUV8Heu1iLZF1ZLCRmka7Q1nSmR7kQxZ2uU2Yk+A4yfBRjBf V4KSdikeLEnceI97Suiwpy4UsQgd6I9Chk7+JQFKdvPgbr0nbhuyFNO+B2YKrY9vh6D9 rWjcp4IpOdquSQ86/WwWQYdiqNKUkWGPuN303azy17IdAJhuvZqk+I2pXWpQbzhLT1Z/ Er9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767751850; x=1768356650; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hGO9V6t38pWhRcUjuKcEmhXixM/ugRlM9F+VeEvQ1Sk=; b=b6L/CMtfdhW6HF8r0+doS7jlTPTXnmrxLRgTPN8Med5yB0whypQJhdnX8cqJkRnEE0 BAdm963gJAt3iCpwfVibLb4ObXfT9xG5/Sgn0+IqLULXA9DSuXt3bZudAtOWgw9W29Nc f1kWC0Ph9NmlZc81MgHE/LQxsJKHdC5s1LiK9m9reIUVtmrLOVt9KZ+K90Pr79CMRMEl P3V3daH+ZJjZtIuoCPwbHy9LvtpKuBJok6Xe5RGCbw4lJyvjdmoZy5LxW1qc5ikYMP6e HYZYtsSV84DJm7uHiqfnAKkXSxgCtIRIvG8C7k7WCpl1awacoNIDEz1gFJMM9stARSAv B7fw== X-Forwarded-Encrypted: i=1; AJvYcCV56POFI1hrh0EIhDR2AN2DGM6wfsCbArbYVxxuvkUaXiEsWxVlpR7XFH7BJRU46Cu8qZHjtx8XnxzyQzE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0gHZ8El5yASPEnxhDgJnQyunXAMk/sAc1WhWgGp9nZyRvvIz1 mgyqYOBMugvkK+o83NPn5VxZMW/iSU/EzAKxeYtUQpLPgPEjDTkMWY9j8rXJYamKPVQ= X-Gm-Gg: AY/fxX6A/a7p2xAJlJ1OT+TrcQqQGDmxDTBMM7HAS/t69CqU1uNZb88LoWZugqp5K+9 7DTCuO6RVxocvNzrzygxdeh7FaWk8oDx8rIk6AQVmdlG85KAQ7wXmfdU7Gz2AZGJD80jXT3wEJz WeKRB1x7BZHxFwUB2xjf2OFj7fXkbQad8xZt/5DGPheWEQM+R/F7rYejL3TPrf1oQeB8vCU9Cnl vk5B61X8xjGQ1SxRdFqFkKUlhTwVzto1uOG2NCF7u0HaJZ5LOLi0U8dC3X1lgKn2uz+jjcBULuY bwUVUElGq/HrZJQapSYhOuzv6IvxVltKyCHaGOH1+y+62uA9BhDObjWu1f9PCBruaRgHJBd+KIq 82+uwfvWssUzR/Ub//szBsujTI2WmGwUv9ibJLUFgyV97iWcywX5C0P4APvmjRJzb4fpvxIWz1d 9LnQk= X-Google-Smtp-Source: AGHT+IF1niecuKpR9e1VzWHOa/0aIml7CsgcQQ4j4j1BLPt+s7mJSiluFktoFQ0BrivFQkdNzmZpDw== X-Received: by 2002:a05:6830:1bed:b0:7ca:f4cd:db57 with SMTP id 46e09a7af769-7ce46d10370mr1904762a34.17.1767751850040; Tue, 06 Jan 2026 18:10:50 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ce478af8besm2460657a34.14.2026.01.06.18.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 18:10:49 -0800 (PST) From: Jens Axboe To: Caleb Sander Mateos Cc: Kanchan Joshi , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260106200838.152055-1-csander@purestorage.com> References: <20260106200838.152055-1-csander@purestorage.com> Subject: Re: [PATCH] block: don't merge bios with different app_tags Message-Id: <176775184888.14145.7372547504260204885.b4-ty@kernel.dk> Date: Tue, 06 Jan 2026 19:10:48 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Tue, 06 Jan 2026 13:08:37 -0700, Caleb Sander Mateos wrote: > nvme_set_app_tag() uses the app_tag value from the bio_integrity_payload > of the struct request's first bio. This assumes all the request's bios > have the same app_tag. However, it is possible for bios with different > app_tag values to be merged into a single request. > Add a check in blk_integrity_merge_{bio,rq}() to prevent the merging of > bios/requests with different app_tag values if BIP_CHECK_APPTAG is set. > > [...] Applied, thanks! [1/1] block: don't merge bios with different app_tags commit: 6acd4ac5f8f0ec9b946875553e52907700bcfc77 Best regards, -- Jens Axboe