From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757834AbbBEOqp (ORCPT ); Thu, 5 Feb 2015 09:46:45 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:52177 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756986AbbBEOqn (ORCPT ); Thu, 5 Feb 2015 09:46:43 -0500 From: "Rafael J. Wysocki" To: "mika.westerberg@linux.intel.com" , Ken Xue Cc: Andy Shevchenko , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V4] acpi:apd:add AMD ACPI2Platform device support for x86 system. Date: Thu, 05 Feb 2015 16:09:38 +0100 Message-ID: <1767774.KlJWFImEzb@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150205120214.GR18758@lahna.fi.intel.com> References: <1422928460.2528.16.camel@kxue-X58A-UD3R> <1423105637.18208.35.camel@kxue-X58A-UD3R> <20150205120214.GR18758@lahna.fi.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, February 05, 2015 02:02:14 PM mika.westerberg@linux.intel.com wrote: > On Thu, Feb 05, 2015 at 11:07:17AM +0800, Ken Xue wrote: > > >From d22789f089ee644413a144633f368f45cb0ac9d8 Mon Sep 17 00:00:00 2001 > > From: Ken Xue > > Date: Thu, 5 Feb 2015 11:04:44 +0800 > > Subject: [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86 system. > > > > This new feature is to interpret AMD specific ACPI device to > > platform device such as I2C, UART found on AMD CZ and later chipsets. It > > based on example intel LPSS. Now, it can support AMD I2C & UART. > > You are missing Signed-off-by here. > > Anyway looks good to me, > > Acked-by: Mika Westerberg Thanks! Ken, can you please resend this one with a sign-off? I can't apply it otherwise. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.