From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6DEC392B90 for ; Tue, 13 Jan 2026 14:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313622; cv=none; b=eo6pU29LaHDwecI8ed6Eiq+SG/2dopEEphoO8JvR/cQIfbg0lg7tDbEZLMk9FtIjntlZ1A1vmfecC2VgHT4ElRZoUajh8zihblatAaXNhrLTFM4mj4Fkp+2nsRKF4wrbYXg8ZBPYUZndMo5ZGD8mDtOXMZBoIGNQN0pnBDgOAM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313622; c=relaxed/simple; bh=oDqCvR7IsJAmRRTLHjAAa3Hoqe/2MFlmrsbV/ocJMOQ=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=udERd2AERI+AIeTGLqPoen59ZvzZZv+93zvu8zxAsIaKD/9KF60QwHZ2pqlA7YS7hsKE9lfgPhKvx8lBssZvNiHfawz87u5/4AM9oN1FpXZBVqNHgOt8kkVqGw4ZFSkfJdKrB/cokWOApyLL/qvLBpgXryai1kzRX2YCG4KYMuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bdC3XqnD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jTNuOO9C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bdC3XqnD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jTNuOO9C" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60DDsSX62071209 for ; Tue, 13 Jan 2026 14:13:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ndv2n8oUCWT237e8LXBbbygF+JhhCmzXmlYm0mT+iCY=; b=bdC3XqnDnxlCd66I m05wz2kOqP/mPTEXnNypBGvl4+h6BoM/mwxyhxSuhmZ/KyCwDNX7LFSee+KPGatr vwiAwcR6lIzwwxvfuE1tNgD0gZ0tx9Fg6un62vC1n3AA0oBmEGCjjYIswK+AXhbH vWG9+bYRhKFl8XpY8Rd+ZVs199usFTHafK5wSCoHthxkAX5i35PNBOj59WVR5VM5 ORTRQUnvXgk+zzb4gHhIdSkko79LyjNMWnSBa1gqUgQLE0f1u2YUe0CAnDAgZzI4 aLTcOj5MkOcQ9QDhr10ILhhfy1LERnKaChI73aIQ2FxxPjrtFt5Fg1QtzrcjuZ0E VDY5Ng== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnqbm81yb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 14:13:39 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-81f42368322so2479718b3a.3 for ; Tue, 13 Jan 2026 06:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768313619; x=1768918419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ndv2n8oUCWT237e8LXBbbygF+JhhCmzXmlYm0mT+iCY=; b=jTNuOO9C6q49Vs4M7WJYdb0Cqwq6sogyuYo52L+7+g/fBydziMq8wq+Fiqqf59sAU8 PlQ9upNmZ+mth0pkiMRhVUFqo7oZeXuwQfyUwey3K84vy6FheyBgg6heDUQlVQMhbmZa 2bJF6y42UuxIjx9la5j56EIpxJHE6D6ZGa/XKMZv20earpy2howcuhhaKhuKhLeM3a5n VlZrmydIC4gC3uSxNJZaGdYA5YidLMzc2BnW0tdwbU5ILwSVT9DEZjXpOjcgIz4u94NT xc9xLq4eN8tiaJ5b6rk+1UJaAU4UJ9cYC+elSsFOL/D2DD0rCCAv7ga+0htuv3Ezg1ft 7W+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768313619; x=1768918419; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ndv2n8oUCWT237e8LXBbbygF+JhhCmzXmlYm0mT+iCY=; b=bDsVxyTXVpYjt3yzo9b66YS42/mT/nh5TClyxqq6K6q1U5XYOCnw3hZFwGAIy50YyH jDSn+Iids1CqH5GHgnz0EyUWvYUexhlSVTF7a4ScIqGnanlTbiW+y3+SSAbPx4sKvQoL SwtSqsUpJY1tfEtnDLwPvMOsQl82xdTwP4MfF8R3CKmUOJVWRA1GTFcdZuOlJyRfwMcb zdLtd0KCgwkKPBht+n791AvViOfZbWS75ZTEc6oGX2IOtOhk+UwqNGVUTSu0Drp/Bceo OChvxZ3MvFEgYCFQBN5GAKpzH8c+km0FQyJoFojPWhdx14oxSmPTjkSU0UKYMeFuRbF1 Lhug== X-Forwarded-Encrypted: i=1; AJvYcCU09lCaPtK1FgGt/9WI5hlOmMahj+e7n1ZmdgdtvfmBIV7UCWiNiXsvI0mfP0m23I55tBu/AoIbYCxazHw=@vger.kernel.org X-Gm-Message-State: AOJu0YwSETvnqDV58bVxOkIWUg2ZGyCspWwvqZkuadSjAvGb5/esgYLz wxfZop+RlJq4P9zZNyNpuEPwvvRd8zSjuhBLokUFePl+396CNcQO0y7FibySiM6VsZ9kq7DwpfP JoNEBW7/MaaGjnTUMqoNuyHEzkHKwRR7Sw6Nuz9yMoKz6eB4okRMVy1iUwCClxaw5vhs= X-Gm-Gg: AY/fxX73LbYoxwy9bCcd1z0pRgs3TZd1bodosdd0pm6usGNbQ9bNffQh0ErkM75u5xt dRiYToCnaiVkItohcIfBVQ3rXsUjc8KGa9okkAQ/8MQyo8EFmty9rXPLYVQxUcKeVtip49+rGvH eTe/XmBxVooKHsZJhLqj3Rz9Xuie4/LM6NkfgM3QFPAKBBSWNNAuaMfdLVZgUlu8Ce74hdOM/T2 nzE4azNHslApm6V9hVHVuSIFWY6mIzXUejmHOaIeCQI4Vy5jCRILUOHpMiz7JhtGlDAPaVaEhSo QoHZBxWOS7pjyt+FcJUjbMNhjdaKGvhZihOtrh9KzvttALFRiZFsvevfjjLijye1bh4w/QTF5qK AemDeoyUZ X-Received: by 2002:a05:6a00:369b:b0:81f:528b:c091 with SMTP id d2e1a72fcca58-81f528bc64emr6862536b3a.22.1768313619138; Tue, 13 Jan 2026 06:13:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmc6xuC1gIdCjGMj7cp2G8pLlkDwrhLxGdH6YKup6ma/i0cgfS/kKcArYFf4CgBvDRuGZmPA== X-Received: by 2002:a05:6a00:369b:b0:81f:528b:c091 with SMTP id d2e1a72fcca58-81f528bc64emr6862504b3a.22.1768313618576; Tue, 13 Jan 2026 06:13:38 -0800 (PST) Received: from [192.168.1.102] ([120.60.62.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81c88628633sm15498035b3a.23.2026.01.13.06.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:13:38 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: Kevin Xie , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Liam Girdwood , Mark Brown , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Heinrich Schuchardt , E Shattow , Hal Feng Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20251218102149.28062-1-hal.feng@starfivetech.com> References: <20251218102149.28062-1-hal.feng@starfivetech.com> Subject: Re: [RESEND v1] PCI: starfive: Use regulator APIs instead of GPIO APIs to control the 3V3 power supply of PCIe slots Message-Id: <176831361429.497576.11439063740783860965.b4-ty@kernel.org> Date: Tue, 13 Jan 2026 19:43:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Proofpoint-GUID: hLW2aXbbNQE1O1DW2lLhvyf2v-KfKAjl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDExOSBTYWx0ZWRfX3mDkpd/m/3hW al2/ZPItHQ2qAEQMqreWekT2acwNYy1ODx9YtpFroEYxWnae0j3NFtYMlUNRmjFnuwJrm6XdkjO WLeAOAWxRv5AOwHi8QS6hJeexf1DO8+sENVogAGnqN6oMhrR1ZNcWyjfvJ+QL1It5kJHbQmPDcG edaPn3OGMH9yXIPKk9pCLoaIpaz0FQoImKqxrr+W3y2BIVo+NXwmOAWOZ9qldMOsaeMGNPrXaY2 Hev8/qgmPKC9RO4zoupTKVo3zSl9EFI23MmAmKT2o0IanGyiiLCaSfoLxDU2bQQJPCPNLHQSiqy VsHrWV0JwGfYoPxv3P9ebUYyErVxXdO0fW5nyD0Q9Qkds1S+2DalcsMeRl9YNoL0emAHPGKqNMW SME/ClZzkFSQm97ByxjS2P1RBYTai+5TTEzer5luEm3vHo3m/LfBQ545JeOAQTmEqlzSCfvPLFQ zEk5OwRBQJubXSzZS2Q== X-Proofpoint-ORIG-GUID: hLW2aXbbNQE1O1DW2lLhvyf2v-KfKAjl X-Authority-Analysis: v=2.4 cv=YdmwJgRf c=1 sm=1 tr=0 ts=69665313 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=tlgrONNCw2HA119KiuRAjA==:17 a=UQb8oz5x2ZoWVpge:21 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=W6VN3AnPqya3tQl1NnoA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130119 On Thu, 18 Dec 2025 18:21:49 +0800, Hal Feng wrote: > The "enable-gpio" property is obtained to control the 3V3 power supply > of PCIe slots but it is not documented in the dt-bindings and using > GPIO APIs is not a standard method to control PCIe slot power, so > use "vpcie3v3-supply" property and regulator APIs to replace them. > > This change will break the DTs which add "enable-gpio" or "enable-gpios" > property under the node with compatible "starfive,jh7110-pcie". > Fortunately, there are no such DTs in the upstream mainline, so this > change has no impact on the upstream mainline. > If you have used "enable-gpio" or "enable-gpios" property in your > downstream DTs, please update it with "vpcie3v3-supply" after applying > this commit. > > [...] Applied, thanks! [1/1] PCI: starfive: Use regulator APIs instead of GPIO APIs to control the 3V3 power supply of PCIe slots commit: 05a75df4182e301a1b0059606f77b65c74deaa9b Best regards, -- Manivannan Sadhasivam