mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
	Thomas Gleixner <tglx@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] time/sched_clock: Use ACCESS_PRIVATE() to evaluate hrtimer::function
Date: Tue, 13 Jan 2026 17:15:13 -0000	[thread overview]
Message-ID: <176832451368.510.9081222014514031930.tip-bot2@tip-bot2> (raw)
In-Reply-To: <875x95jw7q.ffs@tglx>

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     3db5306b0bd562ac0fe7eddad26c60ebb6f5fdd4
Gitweb:        https://git.kernel.org/tip/3db5306b0bd562ac0fe7eddad26c60ebb6f5fdd4
Author:        Thomas Gleixner <tglx@kernel.org>
AuthorDate:    Tue, 13 Jan 2026 17:47:37 +01:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Tue, 13 Jan 2026 18:08:57 +01:00

time/sched_clock: Use ACCESS_PRIVATE() to evaluate hrtimer::function

This dereference of sched_clock_timer::function was missed when the
hrtimer callback function pointer was marked private.

Fixes: 04257da0c99c ("hrtimers: Make callback function pointer private")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/875x95jw7q.ffs@tglx
Closes: https://lore.kernel.org/oe-kbuild-all/202601131713.KsxhXQ0M-lkp@intel.com/
---
 kernel/time/sched_clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c
index f391118..f3aaef6 100644
--- a/kernel/time/sched_clock.c
+++ b/kernel/time/sched_clock.c
@@ -215,7 +215,7 @@ void sched_clock_register(u64 (*read)(void), int bits, unsigned long rate)
 
 	update_clock_read_data(&rd);
 
-	if (sched_clock_timer.function != NULL) {
+	if (ACCESS_PRIVATE(&sched_clock_timer, function) != NULL) {
 		/* update timeout for clock wrap */
 		hrtimer_start(&sched_clock_timer, cd.wrap_kt,
 			      HRTIMER_MODE_REL_HARD);

  reply	other threads:[~2026-01-13 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  9:06 kernel/time/sched_clock.c:219:13: sparse: sparse: dereference of noderef expression kernel test robot
2026-01-13 14:01 ` [PATCH] time/sched_clock: Use ACCESS_PRIVATE() to evaluate hrtimer::function Thomas Gleixner
2026-01-13 16:46   ` Thomas Gleixner
2026-01-13 16:47   ` [PATCH v2] " Thomas Gleixner
2026-01-13 17:15     ` tip-bot2 for Thomas Gleixner [this message]
2026-01-14  8:56     ` Nam Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176832451368.510.9081222014514031930.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®