From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EAA43D349B for ; Thu, 15 Jan 2026 18:07:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768500480; cv=none; b=mQXuGLfodWZISqj7FdRFiLphVvY1gfAuUF0P69zwwvUPgcCQW3bwF8bo5g6jl9YaiklQiFmfaOmNuTsgE8duYzPnTmRUlsN/zveorqcpaJ34d62Blo7XX5cvsL/tlYj8U+IFYFz7cR8EEHDJpI6gfKtX9c0q3yEU4QJ5TU6ZkJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768500480; c=relaxed/simple; bh=boHXuFdfq1eZeeQ+Kw09uZN9fSSFb8/1/tOhIclkLZ8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IOECsYitly8ygYkEaCFS8RDiwiEgi8haybiKcgQyL9Xhvp1fVGo/mllceFKiZALHuTacQZtnUhTokJUkm5Pfjhoa6kMq8xRZ01XYhPLnHPvZ2ki6AE3Z9+xa4rz4p1Q7AF+MqU9FhhQMzmbd/C7M5ppUD2lFXQznKvXsN+tE3Lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aQiYAgTQ; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aQiYAgTQ" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c5539b9adc3so729326a12.1 for ; Thu, 15 Jan 2026 10:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768500478; x=1769105278; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=X1All7C7wDUzRYi0q94v+2h4Zkg3zXfCYN6C7icdLAI=; b=aQiYAgTQPapZDuB5rGnAf3RZv4UkIBhc16VIKRz0CDo/KBeHdR+whCdC1neVeTVTyZ o7bDapNz3ZAh/mZK8IYb1NxhXXKd27rweuhAKOq6I1MSLwf1gQo3Lm0NoHZt7lFZjLM2 nwRXkM3t56zhoRMDI4/psn369irMyg2IFLgycampJYdhvfZHDGgex9AIdm4sZgH/gTaS 7xFnN1fn9TaO7uArpm7XfPjLYlrPrVDPOXJHfUvPqMxDA6LFFUUAKVtavOP0K7DAoqsC kTycVYfzaHYMnMc2Vext2X1Ik/b3UVzAdIqN94gBkOXgnJSyDLT5O1Oy1/fP+6VoW7Ax pYog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768500478; x=1769105278; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X1All7C7wDUzRYi0q94v+2h4Zkg3zXfCYN6C7icdLAI=; b=sQGYVEd8oU4zg2xY1SSlHttFQKx2Oy9RWOqQ9rtTJngDSgwGN/o5t3q2mGte8V0eLa tpuuWXt4S4ocCnWh5+5DLtHHLC8oXQE/FVbKoDDWwyLTU7yleXA1BRIV+MmhxITlYcU4 vqdSRGG/QNN+Kk79DUv7jDjT8zhTC9QsK88oYgfhpmRSjFVZHJPKHcIMpt+1n3MO71px myxwuEsRkt+apCLdRg122obrwzsqOWumvHjsItWuUU5YMl44s0/cjukNIz74WmF72+oV zXQLY8psGFwRX4KkTFn02GQMCnjP/xqWfxPpZqhtL3s63Vdd12vHlLzSGe2fA08XIJwj fBHw== X-Forwarded-Encrypted: i=1; AJvYcCUOCzTmJPYUjHG9R1J0OE4+BMpO2knGCExp5CVG/IsBuqzf04dDpXuIM0K+xUwEYH3vAc1Y8JwW6YeTUdc=@vger.kernel.org X-Gm-Message-State: AOJu0YzS0I3oTqfrQ2Ylo6cHsBPPqSGby15b9cgLeIgBn5otfEWF2amp EIfbHxjBC5oSfHhdg1yQa1OCnUjD+EtDtgshZ1Eeoci39HH72p8v06pxFs0Wp2gjCW9ZMo9Omw9 k+mmC6A== X-Received: from pjbev7.prod.google.com ([2002:a17:90a:eac7:b0:34c:4419:4aa3]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:6da8:b0:38b:e759:c2ba with SMTP id adf61e73a8af0-38e00d1b92fmr30027637.41.1768500478359; Thu, 15 Jan 2026 10:07:58 -0800 (PST) Date: Thu, 15 Jan 2026 10:03:40 -0800 In-Reply-To: <20260113172807.2178526-1-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260113172807.2178526-1-yosry.ahmed@linux.dev> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <176849721787.705259.1172944415596561626.b4-ty@google.com> Subject: Re: [PATCH] KVM: nSVM: Drop redundant/wrong comment in nested_vmcb02_prepare_save() From: Sean Christopherson To: Sean Christopherson , Yosry Ahmed Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, 13 Jan 2026 17:28:07 +0000, Yosry Ahmed wrote: > The comment above DR6 and DR7 initializations is redundant, because the > entire function follows the same pattern of only initializing the fields > in vmcb02 if the vmcb12 changed or the fields are dirty, which handles > the first execution case. > > Also, the comment refers to new_vmcb12 as new_vmcs12. Just drop the > comment. > > [...] Applied to kvm-x86 svm, thanks! [1/1] KVM: nSVM: Drop redundant/wrong comment in nested_vmcb02_prepare_save() https://github.com/kvm-x86/linux/commit/f00ccdede3c8 -- https://github.com/kvm-x86/linux/tree/next