From: Stephen Boyd <sboyd@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Keerthy <j-keerthy@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Russ Dill <Russ.Dill@ti.com>,
Russell King <linux@armlinux.org.uk>,
Tero Kristo <t-kristo@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/3] clk: Move clk_{save,restore}_context() to COMMON_CLK section
Date: Thu, 15 Jan 2026 19:51:53 -0700 [thread overview]
Message-ID: <176853191353.4027.10879981541626027875@lazor> (raw)
In-Reply-To: <8066e45dbdd9acca29c0f9b578922a091a5c31fd.1764582057.git.geert@linux-m68k.org>
Quoting Geert Uytterhoeven (2025-12-01 02:42:26)
> The clk_save_context() and clk_restore_context() helpers are only
> implemented by the Common Clock Framework. They are not available when
> using legacy clock frameworks. Dummy implementations are provided, but
> only if no clock support is available at all.
>
> Hence when CONFIG_HAVE_CLK=y, but CONFIG_COMMON_CLK is not enabled:
>
> m68k-linux-gnu-ld: drivers/net/phy/air_en8811h.o: in function `en8811h_resume':
> air_en8811h.c:(.text+0x83e): undefined reference to `clk_restore_context'
> m68k-linux-gnu-ld: drivers/net/phy/air_en8811h.o: in function `en8811h_suspend':
> air_en8811h.c:(.text+0x856): undefined reference to `clk_save_context'
>
> Fix this by moving forward declarations and dummy implementions from the
> HAVE_CLK to the COMMON_CLK section.
>
> Fixes: 8b95d1ce3300c411 ("clk: Add functions to save/restore clock context en-masse")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511301553.eaEz1nEW-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Applied to clk-next
prev parent reply other threads:[~2026-01-16 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 9:42 [PATCH 0/3] clk: <linux/clk.h> fixes and improvements Geert Uytterhoeven
2025-12-01 9:42 ` [PATCH 1/3] clk: Move clk_{save,restore}_context() to COMMON_CLK section Geert Uytterhoeven
2025-12-01 9:42 ` [PATCH 2/3] clk: Merge prepare and unprepare sections Geert Uytterhoeven
2026-01-16 2:51 ` Stephen Boyd
2025-12-01 9:42 ` [PATCH 3/3] clk: Annotate #else and #endif Geert Uytterhoeven
2026-01-16 2:52 ` Stephen Boyd
2026-01-16 2:51 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176853191353.4027.10879981541626027875@lazor \
--to=sboyd@kernel.org \
--cc=Russ.Dill@ti.com \
--cc=geert@linux-m68k.org \
--cc=j-keerthy@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®