From: Marc Zyngier <maz@kernel.org>
To: "Oliver Upton" <oupton@kernel.org>,
"Joey Gouly" <joey.gouly@arm.com>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Zenghui Yu" <yuzenghui@huawei.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Kornel Dulęba" <korneld@google.com>
Cc: Bartlomiej Grzesik <bgrzesik@google.com>,
Tomasz Nowicki <tnowicki@google.com>,
Sebastian Ene <sebastianene@google.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: Fix error checking for FFA_VERSION
Date: Fri, 16 Jan 2026 09:48:14 +0000 [thread overview]
Message-ID: <176855688030.3828453.16084185280555582394.b4-ty@kernel.org> (raw)
In-Reply-To: <20251114-pkvm_init_noffa-v1-1-87a82e87c345@google.com>
On Fri, 14 Nov 2025 11:11:53 +0000, Kornel Dulęba wrote:
> According to section 13.2 of the DEN0077 FF-A specification, when
> firmware does not support the requested version, it should reply with
> FFA_RET_NOT_SUPPORTED(-1). Table 13.6 specifies the type of the error
> code as int32.
> Currently, the error checking logic compares the unsigned long return
> value it got from the SMC layer, against a "-1" literal. This fails due
> to a type mismatch: the literal is extended to 64 bits, whereas the
> register contains only 32 bits of ones(0x00000000ffffffff).
> Consequently, hyp_ffa_init misinterprets the "-1" return value as an
> invalid FF-A version. This prevents pKVM initialization on devices where
> FF-A is not supported in firmware.
> Fix this by explicitly casting res.a0 to s32.
>
> [...]
Applied to next, thanks!
[1/1] KVM: arm64: Fix error checking for FFA_VERSION
commit: 582234b0d8419e0b6cbfd87ae3f80568c8d0917e
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2026-01-16 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 11:11 Kornel Dulęba
2025-11-22 11:36 ` Marc Zyngier
2025-11-24 11:49 ` Kornel Dulęba
2025-11-24 13:22 ` Marc Zyngier
2025-11-25 13:54 ` Kornel Dulęba
2026-01-08 15:47 ` Will Deacon
2026-01-08 15:47 ` Will Deacon
2026-01-16 9:48 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176855688030.3828453.16084185280555582394.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=bgrzesik@google.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=korneld@google.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oupton@kernel.org \
--cc=sebastianene@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tnowicki@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®