mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Lorenzo Pieralisi" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/msi] PCI/MSI: Make the pci_msi_map_rid_ctlr_node() interface firmware agnostic
Date: Sun, 18 Jan 2026 10:09:20 -0000	[thread overview]
Message-ID: <176873096087.510.7580845794598387422.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260115-gicv5-host-acpi-v3-2-c13a9a150388@kernel.org>

The following commit has been merged into the irq/msi branch of tip:

Commit-ID:     93eb217ac06d13c1fda75553d220eac0b5ad9225
Gitweb:        https://git.kernel.org/tip/93eb217ac06d13c1fda75553d220eac0b5ad9225
Author:        Lorenzo Pieralisi <lpieralisi@kernel.org>
AuthorDate:    Thu, 15 Jan 2026 10:50:48 +01:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Sun, 18 Jan 2026 11:07:57 +01:00

PCI/MSI: Make the pci_msi_map_rid_ctlr_node() interface firmware agnostic

To support booting with OF and ACPI seamlessly, GIC ITS parent code
requires the PCI/MSI irqdomain layer to implement a function to retrieve
an MSI controller fwnode and map an RID in a firmware agnostic way
(ie pci_msi_map_rid_ctlr_node()).

Convert pci_msi_map_rid_ctlr_node() to an OF agnostic interface
(fwnode_handle based) and update the GIC ITS MSI parent code to reflect
the pci_msi_map_rid_ctlr_node() change.

Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20260115-gicv5-host-acpi-v3-2-c13a9a150388@kernel.org
---
 drivers/irqchip/irq-gic-its-msi-parent.c |  8 ++++----
 drivers/pci/msi/irqdomain.c              | 21 ++++++++++++++++-----
 include/linux/msi.h                      |  3 ++-
 3 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/drivers/irqchip/irq-gic-its-msi-parent.c b/drivers/irqchip/irq-gic-its-msi-parent.c
index 12f4522..4d1ad1e 100644
--- a/drivers/irqchip/irq-gic-its-msi-parent.c
+++ b/drivers/irqchip/irq-gic-its-msi-parent.c
@@ -104,7 +104,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
 static int its_v5_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
 				  int nvec, msi_alloc_info_t *info)
 {
-	struct device_node *msi_node = NULL;
+	struct fwnode_handle *msi_node = NULL;
 	struct msi_domain_info *msi_info;
 	struct pci_dev *pdev;
 	phys_addr_t pa;
@@ -116,15 +116,15 @@ static int its_v5_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
 
 	pdev = to_pci_dev(dev);
 
-	rid = pci_msi_map_rid_ctlr_node(pdev, &msi_node);
+	rid = pci_msi_map_rid_ctlr_node(domain->parent, pdev, &msi_node);
 	if (!msi_node)
 		return -ENODEV;
 
-	ret = its_translate_frame_address(msi_node, &pa);
+	ret = its_translate_frame_address(to_of_node(msi_node), &pa);
 	if (ret)
 		return -ENODEV;
 
-	of_node_put(msi_node);
+	fwnode_handle_put(msi_node);
 
 	/* ITS specific DeviceID */
 	info->scratchpad[0].ul = rid;
diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
index a329060..3a40386 100644
--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -376,23 +376,34 @@ u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
 }
 
 /**
- * pci_msi_map_rid_ctlr_node - Get the MSI controller node and MSI requester id (RID)
+ * pci_msi_map_rid_ctlr_node - Get the MSI controller fwnode_handle and MSI requester id (RID)
+ * @domain:	The interrupt domain
  * @pdev:	The PCI device
- * @node:	Pointer to store the MSI controller device node
+ * @node:	Pointer to store the MSI controller fwnode_handle
  *
- * Use the firmware data to find the MSI controller node for @pdev.
+ * Use the firmware data to find the MSI controller fwnode_handle for @pdev.
  * If found map the RID and initialize @node with it. @node value must
  * be set to NULL on entry.
  *
  * Returns: The RID.
  */
-u32 pci_msi_map_rid_ctlr_node(struct pci_dev *pdev, struct device_node **node)
+u32 pci_msi_map_rid_ctlr_node(struct irq_domain *domain, struct pci_dev *pdev,
+			      struct fwnode_handle **node)
 {
 	u32 rid = pci_dev_id(pdev);
 
 	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
 
-	return of_msi_xlate(&pdev->dev, node, rid);
+	/* Check whether the domain fwnode is an OF node */
+	if (irq_domain_get_of_node(domain)) {
+		struct device_node *msi_ctlr_node = NULL;
+
+		rid = of_msi_xlate(&pdev->dev, &msi_ctlr_node, rid);
+		if (msi_ctlr_node)
+			*node = of_fwnode_handle(msi_ctlr_node);
+	}
+
+	return rid;
 }
 
 /**
diff --git a/include/linux/msi.h b/include/linux/msi.h
index 94cfc37..fa41eed 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -703,7 +703,8 @@ void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 void pci_msi_mask_irq(struct irq_data *data);
 void pci_msi_unmask_irq(struct irq_data *data);
 u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev);
-u32 pci_msi_map_rid_ctlr_node(struct pci_dev *pdev, struct device_node **node);
+u32 pci_msi_map_rid_ctlr_node(struct irq_domain *domain, struct pci_dev *pdev,
+			      struct fwnode_handle **node);
 struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev);
 void pci_msix_prepare_desc(struct irq_domain *domain, msi_alloc_info_t *arg,
 			   struct msi_desc *desc);

  reply	other threads:[~2026-01-18 10:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  9:50 [PATCH v3 0/6] irqchip/gic-v5: Code first ACPI boot support Lorenzo Pieralisi
2026-01-15  9:50 ` [PATCH v3 1/6] irqdomain: Add parent field to struct irqchip_fwid Lorenzo Pieralisi
2026-01-15 12:17   ` Jonathan Cameron
2026-01-18 10:09   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2026-01-15  9:50 ` [PATCH v3 2/6] PCI/MSI: Make the pci_msi_map_rid_ctlr_node() interface firmware agnostic Lorenzo Pieralisi
2026-01-18 10:09   ` tip-bot2 for Lorenzo Pieralisi [this message]
2026-01-15  9:50 ` [PATCH v3 3/6] irqchip/gic-v5: Split IRS probing into OF and generic portions Lorenzo Pieralisi
2026-01-15 12:23   ` Jonathan Cameron
2026-01-18 10:09   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2026-01-15  9:50 ` [PATCH v3 4/6] irqchip/gic-v5: Add ACPI IRS probing Lorenzo Pieralisi
2026-01-15 12:30   ` Jonathan Cameron
2026-01-18 10:09   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2026-01-15  9:50 ` [PATCH v3 5/6] irqchip/gic-v5: Add ACPI ITS probing Lorenzo Pieralisi
2026-01-18 10:09   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2026-01-15  9:50 ` [PATCH v3 6/6] irqchip/gic-v5: Add ACPI IWB probing Lorenzo Pieralisi
2026-01-18 10:09   ` [tip: irq/msi] " tip-bot2 for Lorenzo Pieralisi
2026-01-18 11:00 ` [PATCH v3 0/6] irqchip/gic-v5: Code first ACPI boot support Lorenzo Pieralisi
2026-01-18 14:47   ` Thomas Gleixner
2026-01-19  8:19     ` Lorenzo Pieralisi
2026-01-19 13:54       ` Thomas Gleixner
2026-01-20 10:16         ` Lorenzo Pieralisi
2026-01-23  8:42           ` Lorenzo Pieralisi
2026-01-26 20:42             ` Rafael J. Wysocki
2026-01-27 14:34               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176873096087.510.7580845794598387422.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bhelgaas@google.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®