From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C112340B6E2; Tue, 20 Jan 2026 14:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919572; cv=none; b=UxORc7ctpQuI9gp7RrTtSuZLvf+Dq34QhAiRrFTvgz1bTGYdxRrPxVtXsAzEckHd/WpzEGZsXGNKILNwEFsWP41s97iZ8oUr1DnXMIIs9DPr9tnpFmYaMkDB1LgH7854SjHsjrfvtQgD4pY/+NwvJwJ5osMw+RD80s4KIrCMzEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919572; c=relaxed/simple; bh=uns2v8KH7FKm99rtF8K7XsF8bh+wgH8xOaw9xwuiFbY=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=NOWZUyCkQbVNZK8UnFKGrjtMXQAv7qQgOQ0RXAy76k0tLj01IMes8fJ144DOuQzS6JrX1pCIZSEkuk9aZLO1R9vWUTzuJwvwdwwFKGNI+QSW5PQij8JBYVA1IfUsn5qOuCtGtXW2YsDxuUk3N0p9igvq2Sqm6PHL/ju+k7N/uGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=IVXvK30T; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="IVXvK30T" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 34C011A2965; Tue, 20 Jan 2026 14:32:47 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0777B606AB; Tue, 20 Jan 2026 14:32:47 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0BCC610B6B3C2; Tue, 20 Jan 2026 15:32:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768919566; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=CnR4HH0qbA5JMdYprFWKRDPXqXPpkZ+LLXc3tQitS84=; b=IVXvK30TnSaepMj69bYNn55/lQxwgSv1HQzFNJJIZOQbbC4QqLAHwPsE44r8RFYo9uc7AL 1X47C3e+f4USmaWZ9TvXrF4Jluk+xG4bUi7Pdbpt7BhP1K2QZBjaWpwt+kif1ykOyWSU/B osFs2+I54bNKxMzJ0I7VCyqXKVY5NdoU+0FQz+MPUf98xintblaldXhpYdNBugVwN8sHBh ZLCjOnjo8qIiK8AfGbJBQdLGQJOKjAR9QrI4NVHW93vM+/jIC4LBL7aeO7WzZAxMiyYGbp UF+tiQmAUU0Yn1UdnQzF9KAy6qJjfU3O13QiG0ExWcIcQaPRAymf4dUG5290Eg== From: Luca Ceresoli To: Andy Yan , Osama Abdelkader Cc: stable@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: <20260102155553.13243-1-osama.abdelkader@gmail.com> References: <20260102155553.13243-1-osama.abdelkader@gmail.com> Subject: Re: [PATCH v3] drm/bridge: synopsys: dw-dp: fix error paths of dw_dp_bind Message-Id: <176891955882.652956.206927403017627596.b4-ty@bootlin.com> Date: Tue, 20 Jan 2026 15:32:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 On Fri, 02 Jan 2026 16:55:52 +0100, Osama Abdelkader wrote: > Fix several issues in dw_dp_bind() error handling: > > 1. Missing return after drm_bridge_attach() failure - the function > continued execution instead of returning an error. > > 2. Resource leak: drm_dp_aux_register() is not a devm function, so > drm_dp_aux_unregister() must be called on all error paths after > aux registration succeeds. This affects errors from: > - drm_bridge_attach() > - phy_init() > - devm_add_action_or_reset() > - platform_get_irq() > - devm_request_threaded_irq() > > [...] Applied, thanks! [1/1] drm/bridge: synopsys: dw-dp: fix error paths of dw_dp_bind commit: 1a0f69e3c28477b97d3609569b7e8feb4b6162e8 Best regards, -- Luca Ceresoli