From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C3F21D555; Wed, 21 Jan 2026 02:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768962659; cv=none; b=u2diEcKXtt/DFxVPM0kWbEhIbyD0yFdEnMfDN/WoqtDyBUJhlrkjLr/MVWHkCBGML0A8R4l5rU9WleRgU/yBDKIvuVPJ0UtweUWDvl6S9JLXhOQIHOiedLjIY+X9grspkYL2GnzQO42EOdCwlfMEkOJGcu+HtFhkn6Ozht8CK58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768962659; c=relaxed/simple; bh=kakUcG5SzcJJ04uD/Xh1SJIe/+0LTLNt11k19MhqLXM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VxJ0JK9sbc8Y1UUv+v39W1WP/rEM29EHQClVVXxzglbSMbmrOSD+3/A3G4y5/FAhzN1F35jRILMZPDZtsrfQ41FLmXY/6YlVuB7I/DObqgH7WGYoiwtwtFAXwyq00kprTYKg+yaAs3dpuuvnrGFI1tKsggl2puuSi09IwIwqdOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y/cGBS2Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y/cGBS2Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA226C16AAE; Wed, 21 Jan 2026 02:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768962658; bh=kakUcG5SzcJJ04uD/Xh1SJIe/+0LTLNt11k19MhqLXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y/cGBS2ZiYJku/rO/phS4zAT6dn8nNrdqI8u+hc6Y2meUr+Es7RsLp0+Rm7l87ziC C3NoqCyzyiNMNRzMrb+jVblUX2sl4m6KzPViOOYtIr0XrRQ5ON/zbpK6biDZ8PWiCw QoUfeKSuGNQtezWsH+OK1b8zo4AunmsDaIsZQKMgFpnXQpVwpOBk0C68LMLQo+2czv bVxOheQCsIgvu126fLB/oviuyBSovVh/Qi3dVWnXIsV9Q6/e/5o7+XtPgpKcFhJ4AQ xIDTYbuJSe5Xl1ehzqDAdsRVuicF1Nr7islS6eL5n9rNFYEtyIxOuKbKIXDLK4HgtG Ni0rpTqql6Avg== Date: Tue, 20 Jan 2026 20:30:58 -0600 From: "Rob Herring (Arm)" To: Gregory CLEMENT Cc: Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, Miquel Raynal , Richard Weinberger , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Thomas Petazzoni , =?iso-8859-1?Q?Th=E9o?= Lebrun , Conor Dooley , =?iso-8859-1?Q?Beno=EEt?= Monin , Vladimir Kondratiev , Linus Walleij Subject: Re: [PATCH v3 1/4] of: reserved_mem: Fix placement of __free() annotation Message-ID: <176896265605.1837058.2000534852582541394.robh@kernel.org> References: <20260107-mtd-memregion-v3-0-f9fc9107b992@bootlin.com> <20260107-mtd-memregion-v3-1-f9fc9107b992@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260107-mtd-memregion-v3-1-f9fc9107b992@bootlin.com> On Wed, 07 Jan 2026 14:04:52 +0100, Gregory CLEMENT wrote: > The __free() annotation was incorrectly placed before the variable > name instead of after it, which resulted in the following checkpatch > errors: > > ERROR: need consistent spacing around '*' (ctx:WxV) > + struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx); > ^ > WARNING: function definition argument 'idx' should also have an identifier name > + struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx); > > As part of this cleanup, also remove the useless return statement > flagged by checkpatch. > > Signed-off-by: Gregory CLEMENT > --- > drivers/of/of_reserved_mem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Applied, thanks!