From: "Rob Herring (Arm)" <robh@kernel.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: linux-kernel@vger.kernel.org, spacemit@lists.linux.dev,
Liam Girdwood <lgirdwood@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Paul Walmsley <pjw@kernel.org>, Alexandre Ghiti <alex@ghiti.fr>,
Lee Jones <lee@kernel.org>, Alex Elder <elder@riscstar.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
Yixun Lan <dlan@gentoo.org>, Albert Ou <aou@eecs.berkeley.edu>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties
Date: Thu, 22 Jan 2026 04:20:36 -0600 [thread overview]
Message-ID: <176907723670.1588257.5123730065899244337.robh@kernel.org> (raw)
In-Reply-To: <20260122-spacemit-p1-v1-2-309be27fbff9@riscstar.com>
On Thu, 22 Jan 2026 17:43:43 +0800, Guodong Xu wrote:
> Add supply properties that match the P1 PMIC's actual hardware topology
> where each buck converter has its own VIN pin and LDO groups share
> common input pins. Supply names are defined according to the pinout
> names in the P1 datasheet.
>
> This allows different boards to describe their actual
> power tree connections in devicetree rather than hardcoding supply
> relationships in the driver.
>
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
> .../devicetree/bindings/mfd/spacemit,p1.yaml | 58 +++++++++++++++++++++-
> 1 file changed, 56 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/mfd/spacemit,p1.example.dts:13.1-4 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:141: Documentation/devicetree/bindings/mfd/spacemit,p1.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1559: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260122-spacemit-p1-v1-2-309be27fbff9@riscstar.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-01-22 10:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 9:43 [PATCH 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree Guodong Xu
2026-01-22 9:43 ` [PATCH 1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators Guodong Xu
2026-01-22 9:43 ` [PATCH 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties Guodong Xu
2026-01-22 10:20 ` Rob Herring (Arm) [this message]
2026-01-22 12:23 ` Yixun Lan
2026-01-22 16:11 ` Rob Herring
2026-01-22 9:43 ` [PATCH 3/4] regulator: spacemit-p1: Update supply names Guodong Xu
2026-01-22 9:43 ` [PATCH 4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties Guodong Xu
2026-01-22 10:11 ` [PATCH 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree Yixun Lan
2026-01-22 11:27 ` Mark Brown
2026-01-22 12:12 ` Yixun Lan
2026-01-22 13:28 ` Mark Brown
2026-01-22 13:41 ` Yixun Lan
2026-01-22 14:55 ` Guodong Xu
2026-01-22 22:09 ` Yixun Lan
2026-01-23 8:23 ` Javier Martinez Canillas
2026-01-26 22:10 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176907723670.1588257.5123730065899244337.robh@kernel.org \
--to=robh@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=guodong@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®