mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Pritam Manohar Sutar <pritam.sutar@samsung.com>
Cc: alim.akhtar@samsung.com, conor+dt@kernel.org, krzk+dt@kernel.org,
	 linux-arm-kernel@lists.infradead.org, rosa.pila@samsung.com,
	 selvarasu.g@samsung.com, linux-samsung-soc@vger.kernel.org,
	 muhammed.ali@samsung.com, faraz.ata@samsung.com,
	 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	 dev.tailor@samsung.com
Subject: Re: [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC
Date: Thu, 22 Jan 2026 11:15:38 -0600	[thread overview]
Message-ID: <176910209177.2703219.7993114273484886473.robh@kernel.org> (raw)
In-Reply-To: <20260122130721.205664-1-pritam.sutar@samsung.com>


On Thu, 22 Jan 2026 18:37:18 +0530, Pritam Manohar Sutar wrote:
> This SoC has 2 USB typeC and 2 typeA ports those are DWC3 DRD
> controllers and among them, one single USB3.1 DRD combo phy and three
> USB2.0 only phy controllers. This patchset adds and enables USB and
> USB-PHY nodes in dts.
> 
> PMIC is not implemented yet, we rely on USB LDOs being enabled by the
> bootloader and used dummy regulators for now.
> 
> To drive vbus for host mode, it needs GPIO pin to enable vbus regulator.
> GPIO expander is present in the dts, we used it to enable the regulator
> using GPIO.
> 
> USB ports are configured as OTG, and default mode is configured as
> peripheral. It will be changed based on requirements.
> 
> changelog
> ----------
> Changes in v2:
> - As v1 was pushed 3 months back, resending this patchset.
> - Since dependencies are merged, removed links from coverletter.
>   link for v1: https://lore.kernel.org/linux-devicetree/20251024114845.2395166-1-pritam.sutar@samsung.com/
> 
> Pritam Manohar Sutar (3):
>   arm64: dts: exynos: ExynosAutov920: Add USB and USB-phy nodes
>   arm64: dts: exynos: ExynosAutov920: Add regulators for the USB
>   arm64: dts: exynos: ExynosAutov920: Enable USB nodes
> 
>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 160 +++++++++++++++++
>  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 162 ++++++++++++++++++
>  2 files changed, 322 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20260121 (exact match)
 Base: tags/next-20260121 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20260122130721.205664-1-pritam.sutar@samsung.com:

arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb-phy0 (usb-nop-xceiv): '#phy-cells' is a required property
	from schema $id: http://devicetree.org/schemas/usb/usb-nop-xceiv.yaml
arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb-phy1 (usb-nop-xceiv): '#phy-cells' is a required property
	from schema $id: http://devicetree.org/schemas/usb/usb-nop-xceiv.yaml
arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb-phy2 (usb-nop-xceiv): '#phy-cells' is a required property
	from schema $id: http://devicetree.org/schemas/usb/usb-nop-xceiv.yaml
arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb-phy3 (usb-nop-xceiv): '#phy-cells' is a required property
	from schema $id: http://devicetree.org/schemas/usb/usb-nop-xceiv.yaml






  parent reply	other threads:[~2026-01-22 17:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260122125130epcas5p4ac37f540c609f3016ff02f5708e897a2@epcas5p4.samsung.com>
2026-01-22 13:07 ` Pritam Manohar Sutar
     [not found]   ` <CGME20260122125132epcas5p32bb4d76dc0a08851d9acb77bfb005bdc@epcas5p3.samsung.com>
2026-01-22 13:07     ` [PATCH v2 1/3] arm64: dts: exynos: ExynosAutov920: Add USB and USB-phy nodes Pritam Manohar Sutar
     [not found]   ` <CGME20260122125134epcas5p36625b7ac70b8dfba9430831a11955682@epcas5p3.samsung.com>
2026-01-22 13:07     ` [PATCH v2 2/3] arm64: dts: exynos: ExynosAutov920: Add regulators for the USB Pritam Manohar Sutar
2026-01-22 13:34       ` Krzysztof Kozlowski
2026-02-12 11:37         ` pritam.sutar
2026-02-15  8:57           ` Krzysztof Kozlowski
2026-02-18  9:28             ` pritam.sutar
2026-02-18 19:54               ` Krzysztof Kozlowski
2026-03-04  7:46                 ` pritam.sutar
2026-03-04  8:08                   ` Krzysztof Kozlowski
     [not found]   ` <CGME20260122125136epcas5p2db0fa3d04671ddc915e60ae8c5bcfb98@epcas5p2.samsung.com>
2026-01-22 13:07     ` [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes Pritam Manohar Sutar
2026-01-22 13:35       ` Krzysztof Kozlowski
2026-01-23  7:29         ` Pritam Manohar Sutar
2026-01-23  7:59         ` Pritam Manohar Sutar
2026-01-23  8:05           ` Krzysztof Kozlowski
2026-02-12 11:40             ` pritam.sutar
2026-01-28  7:36           ` Krzysztof Kozlowski
2026-02-12 11:42             ` pritam.sutar
2026-01-22 17:15   ` Rob Herring [this message]
2026-01-23  6:23     ` [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC Pritam Manohar Sutar
2026-01-23  7:31       ` Krzysztof Kozlowski
2026-02-12 11:48         ` pritam.sutar
2026-01-28  7:38       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176910209177.2703219.7993114273484886473.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=dev.tailor@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faraz.ata@samsung.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=muhammed.ali@samsung.com \
    --cc=pritam.sutar@samsung.com \
    --cc=rosa.pila@samsung.com \
    --cc=selvarasu.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®