From: Valdis.Kletnieks@vt.edu
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408
Date: Sun, 24 Apr 2016 15:56:18 -0400 [thread overview]
Message-ID: <176911.1461527778@turing-police.cc.vt.edu> (raw)
In-Reply-To: <1461527202.5535.1.camel@edumazet-glaptop3.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said:
> >>> + return !debug_locks ||
> >>> + lockdep_is_held(&sk->sk_lock) ||
> Issue here is that once lockdep detected a problem (not necessarily in
> net/ tree btw), your helper always 'detect' a problem, since lockdep
> automatically disables itself.
"D'Oh!" -- H. Simpson
I thought this patch looked suspect, but couldn't put my finger on it. The
reason why I got like 41,000 of them is because I built a kernel that has
lockdep enabled, but I have an out-of-tree module that doesn't init something,
so I get this:
[ 48.898156] INFO: trying to register non-static key.
[ 48.898157] the code is fine but needs lockdep annotation.
[ 48.898157] turning off the locking correctness validator.
After which point, even with this patch, every time through it's still going to
explode.
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2016-04-24 19:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 0:30 Valdis Kletnieks
2016-04-21 7:42 ` Hannes Frederic Sowa
2016-04-21 9:05 ` Valdis.Kletnieks
2016-04-21 13:31 ` Eric Dumazet
2016-04-21 13:49 ` Hannes Frederic Sowa
2016-04-24 18:38 ` David Miller
2016-04-24 18:48 ` Hannes Frederic Sowa
2016-04-24 18:54 ` David Miller
2016-04-24 19:55 ` Eric Dumazet
2016-04-24 19:46 ` Eric Dumazet
2016-04-24 19:56 ` Valdis.Kletnieks [this message]
2016-04-24 21:00 ` Eric Dumazet
2016-04-24 21:13 ` Valdis.Kletnieks
2016-04-24 21:25 ` Eric Dumazet
2016-04-24 21:28 ` Eric Dumazet
2016-04-25 13:26 ` Hannes Frederic Sowa
2016-04-21 18:10 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176911.1461527778@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®