From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40C2137930; Sun, 25 Jan 2026 02:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769309205; cv=none; b=VLuJeGfx2aWVfzNW6tvrbRsnKQ4fo7PeDL1CFtGWmq1Qmtk4JR8jmwkBYSx1GB+atqUeFapczTeo5y+RvLr/DrZZN+xxmSxklCU681ZaNA5nC8X8hianv7+23Wcs5P6ZTh5jVWH7Om7fn1+a8VsxHo8u1vaBgLVBSnkM+y09hn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769309205; c=relaxed/simple; bh=Z4fkG7LSuae0RxuHVuzfycRmmyLAVqUABxHzAF7OhMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AP7BS8vHjHQLYCalmzQrI3kIN/GrkUOXdlONmpG/AoVJYlwqWtsf0KZqOzkM4rU98jITCVKMn+49cHiDFxFuO1DVTehxXHv1vc57WRAlm4cOca42yi12dzcRdHvj35GLEHXWclVoHanHPf0cBD69zZkt16BOUbh3bZMT8XFjJiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T6sSWjW4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T6sSWjW4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56739C116D0; Sun, 25 Jan 2026 02:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769309205; bh=Z4fkG7LSuae0RxuHVuzfycRmmyLAVqUABxHzAF7OhMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T6sSWjW4uvfWgOYMSqF7iHwEw0SnLa6sbAeQAmtkJG0ffdgEUXsNoQ2gHFSqSBzAD aX1QQVvrBz79OJv3Rp8y48YNVKnJgaH4YvTrQBvaD6EIHKzsop535t27aKS16KI+l1 ZeWRAXW3bgqBHyd3PmH8HSjfQvG1EQgz7zxdWzOfKJYjBett0+shptMYJ/XulwrBV6 W6FqmPdqGvp97xMVW6b/tWjU4hDVlwYX90Hbohoj1eiktG+yzJG98RtLq+hiptDl1C pvEDpf4uQ4dEjcCXik88anbE+jhyw67ZgkEUly6zPzbXIVG12/+6R4LVPbtYmIicyT vQljpj51iUVRQ== From: Chuck Lever To: Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Ryota Sakamoto Cc: Chuck Lever , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SUNRPC: Replace KUnit tests for memcmp() with KUNIT_EXPECT_MEMEQ_MSG() Date: Sat, 24 Jan 2026 21:46:41 -0500 Message-ID: <176930919420.23964.10388024129059199850.b4-ty@oracle.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260124-fix-gcc_krb5-memcmp-v1-1-4648cbbdc78b@gmail.com> References: <20260124-fix-gcc_krb5-memcmp-v1-1-4648cbbdc78b@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit From: Chuck Lever On Sat, 24 Jan 2026 14:17:19 +0900, Ryota Sakamoto wrote: > Replace KUnit tests for memcmp() with KUNIT_EXPECT_MEMEQ_MSG() to improve > debugging that prints the hex dump of the buffers when the assertion fails, > whereas memcmp() only returns an integer difference. > > Applied to nfsd-testing, thanks! [1/1] SUNRPC: Replace KUnit tests for memcmp() with KUNIT_EXPECT_MEMEQ_MSG() commit: 63c04545fa093cd399132519a974fca2f1e9aaea -- Chuck Lever