From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FDEE2FD69E; Tue, 27 Jan 2026 12:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769516363; cv=none; b=tg+bcMogRXU63UL3xiYlC+zy3tov0iqY6+UeP8jBcQNM3t3dd4fq24g7VxplYYVyLjjjefAKe3/KPuBgHF/q+S2naOTG3ZU4PQnkMewAlzuZ/1YJUKj7dBy+BAK/I4Jfi0Nf7lCr3klPJcY70mVQ/JYX6Ulk3ETbyljlf6h6T/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769516363; c=relaxed/simple; bh=rQCwqPRjnf0sF73dqDqtjnGlhCpJA0ASbwQRPJhgCy4=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=E7ygBltMS8miEqMLTbsgmqK7VF/IF2BH1zAcFscPUcFSRnKRu8soMPdAIyUG+9lwtVGO4CVy7dtpDxEdxZf+Eb9koXwqnQwK4IozFEoqX7DWXw+DHD3eMj+CgMhQP32km4uFW0cv01nWjyTKRVdZGeN0EEaD03M20+7Km44lcis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ipJeUGXH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ipJeUGXH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17668C116C6; Tue, 27 Jan 2026 12:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769516363; bh=rQCwqPRjnf0sF73dqDqtjnGlhCpJA0ASbwQRPJhgCy4=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=ipJeUGXHjTvkf+dK3RXqE6BfkkGafy5VkltFiWFLtMrsXPgFOUkFFWWVj7WQu8Ka/ x08w8beaEQcZZnaNcM9hQxjxsEhSwiRfJIhvO6JLofyklxAmQV5Xk6NqmAaIHvovWO LqKER0LuR7UdUIqBaWX1nukFj9dfqHbu2o45EDqr4nCrtOm3KAtN4Ph7NZPLBJDzeU Bk+5yJ78ywtODuOz28E3nKeyG+WndpSu3MncmXIhklPEagdq0JPi90E+yzudQoKIs0 arSYKtGrWUmNO4qI5uGL93jnGVyBQAmXiGIAKiMN5j8NQ3aqU9ISlSm2jsWHWPcgny ehvlOSBOoEqlw== Date: Tue, 27 Jan 2026 06:19:22 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: devicetree@vger.kernel.org, Bjorn Andersson , linux-gpio@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Linus Walleij , Srinivas Kandagatla To: Mohammad Rafi Shaik In-Reply-To: <20260127105511.3917491-1-mohammad.rafi.shaik@oss.qualcomm.com> References: <20260127105511.3917491-1-mohammad.rafi.shaik@oss.qualcomm.com> Message-Id: <176951636220.1230755.4335541729269457450.robh@kernel.org> Subject: Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl On Tue, 27 Jan 2026 16:25:11 +0530, Mohammad Rafi Shaik wrote: > Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM > pin controller, fully compatible with previous SM8450 generation > (same amount of pins and functions). > > Signed-off-by: Mohammad Rafi Shaik > --- > changes in [v3]: > - Removed the duplicate driver code patch as suggested by Krzysztof. > - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. > - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ > > changes in [v2]: > - Fixed dt-binding errors reported by Krzysztof and Rob. > - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. > - Documented Monaco compatible as suggested by Konrad. > - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ > --- > .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml: properties:compatible:oneOf:1: {'items': [{'enum': ['qcom,qcs8300-lpass-lpi-pinctrl', 'qcom,sa8775p-lpass-lpi-pinctrl']}, {'const': 'qcom,sm8450-lpass-lpi-pinctrl'}], 'minItems': 1, 'maxItems': 2} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml: properties:compatible:oneOf:1: {'items': [{'enum': ['qcom,qcs8300-lpass-lpi-pinctrl', 'qcom,sa8775p-lpass-lpi-pinctrl']}, {'const': 'qcom,sm8450-lpass-lpi-pinctrl'}], 'minItems': 1, 'maxItems': 2} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260127105511.3917491-1-mohammad.rafi.shaik@oss.qualcomm.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.