From: "Rob Herring (Arm)" <robh@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Yao Zi <ziyao@disroot.org>, Longbin Li <looong.bin@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Yixun Lan <dlan@gentoo.org>,
Quentin Schulz <quentin.schulz@cherry.de>,
Jakub Kicinski <kuba@kernel.org>,
devicetree@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Paul Walmsley <pjw@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Yanteng Si <siyanteng@cqsoftware.com.cn>,
spacemit@lists.linux.dev,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Richard Cochran <richardcochran@gmail.com>,
Shangjuan Wei <weishangjuan@eswincomputing.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Chen-Yu Tsai <wens@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Alexandre Ghiti <alex@ghiti.fr>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v3 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac
Date: Wed, 28 Jan 2026 04:52:29 -0600 [thread overview]
Message-ID: <176959754960.624625.3292309980701778789.robh@kernel.org> (raw)
In-Reply-To: <20260128072931.875041-2-inochiama@gmail.com>
On Wed, 28 Jan 2026 15:29:27 +0800, Inochi Amaoto wrote:
> The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
> MAC (version 5.40a) with some extra clock.
>
> Add necessary compatible string for this device.
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 2 +
> .../bindings/net/spacemit,k3-dwmac.yaml | 103 ++++++++++++++++++
> 2 files changed, 105 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@cac80000 (spacemit,k3-dwmac): compatible: ['spacemit,k3-dwmac', 'snps,dwmac-5.40a'] does not contain items matching the given schema
from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@cac80000 (spacemit,k3-dwmac): compatible: ['spacemit,k3-dwmac', 'snps,dwmac-5.40a'] does not contain items matching the given schema
from schema $id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@cac80000 (spacemit,k3-dwmac): Unevaluated properties are not allowed ('phy-handle', 'phy-mode' were unexpected)
from schema $id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260128072931.875041-2-inochiama@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-01-28 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 7:29 [PATCH net-next v3 0/3] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-01-28 7:29 ` [PATCH net-next v3 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-01-28 10:52 ` Rob Herring (Arm) [this message]
2026-01-28 7:29 ` [PATCH net-next v3 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-01-28 7:29 ` [PATCH net-next v3 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-01-28 9:16 ` Vivian Wang
2026-01-28 11:22 ` Inochi Amaoto
2026-01-28 10:43 ` Russell King (Oracle)
2026-01-28 11:19 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176959754960.624625.3292309980701778789.robh@kernel.org \
--to=robh@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=looong.bin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peppe.cavallaro@st.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quentin.schulz@cherry.de \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=siyanteng@cqsoftware.com.cn \
--cc=spacemit@lists.linux.dev \
--cc=weishangjuan@eswincomputing.com \
--cc=wens@kernel.org \
--cc=yong.liang.choong@linux.intel.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®