From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30EEA3502A3; Wed, 28 Jan 2026 12:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769604235; cv=none; b=OtqV4lm/eB/CqCmI2tPz98urlgNFGI/Hh/6jtbh27TcjpGxsSt/ZcldUWJVs7Yf1VNb+zYuSUIaVdmrZaQxqQCGpV0C7fQxKXSzgjOzP4cZG37I9yTIs+hPDr86zvuRIZ2xre2DsVHeNFsytunUm+fLeM7J+LohztgMyABZ55Js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769604235; c=relaxed/simple; bh=oMHuOisfzFZa/SspMgzHSAJ7KCfQNx6FWbCb53V78Kc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZK+FvM+4mFCSlj0RbdaICR3wVh0IKIYVsuFc1CsPBQ7yyMe1nahBOm0FXuMtaaCb5R6mPUso1hKVpxXa2jZQ3fazz+4fy3nI92qsM7EjULv0ApV/gXvKdzv5BINgUdUkSdmpgXHK89pmLBknqJz3h9hII1Qhj2vHxFNzo8AgzwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YczMVpYw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YczMVpYw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C78FDC4CEF1; Wed, 28 Jan 2026 12:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769604234; bh=oMHuOisfzFZa/SspMgzHSAJ7KCfQNx6FWbCb53V78Kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YczMVpYwGeQR/JzANd0TTmXgJOgr2gVaF/lmwtcANf+m2u8mZcQUL+SRNgcTWC3xu sJdf1nvdsAlouwdM861jTs9hkHdDoI9kAEi35kTHN8yfhZY4ltzT5lOKvrN90UPOBW JlJbsi0un1KaFOczXEmFQFWXYd2/HuThck/kV91xcHw2ULUnrjUMYPS0vjad29vUor uzVwA04GqRfCTna0yHdLTWzBFCdec+pArFM8mRqjmnjd8w4qmcxK36x6Piyi3hd9Vv BebmzG/Bzel3keuqlAkOxwgzxqLPHASewoFUoHnGMMK2gJNnjVJPvEeE/e/fsyoYUM B7INYod04iPjQ== From: "Christophe Leroy (CS GROUP)" To: ioana.ciornei@nxp.com, stuart.yoder@freescale.com, agraf@suse.de, German.Rivera@freescale.com, gregkh@linuxfoundation.org, Haoxiang Li Cc: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dan Carpenter , Su Hui Subject: Re: [PATCH v3] bus: fsl-mc: fix an error handling in fsl_mc_device_add() Date: Wed, 28 Jan 2026 13:43:32 +0100 Message-ID: <176960420088.2084129.13365764643328327479.b4-ty@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20260124102054.1613093-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260124102054.1613093-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=564; i=chleroy@kernel.org; h=from:subject:message-id; bh=lWZnn2tJcaNFkDUvVsOHuReTjNx23lTBLXZ5Xxh0drE=; b=owGbwMvMwCV2d0KB2p7V54MZT6slMWRWsZTxpuy6qqC+ZUGFmPFpb9W/kYlW+c8P+djzmb+6P e/R9kkvO0pZGMS4GGTFFFmO/+feNaPrS2r+1F36MHNYmUCGMHBxCsBEOmQY/gdaMj0LCS/9kTGf UfXDEwUfhQNrf71vqtjYp7bdy3dq3C5GhoN2BTr9i19rTZi30rl5knjk4jsvUuZwnrgapvOUVXn 1Hg4A X-Developer-Key: i=chleroy@kernel.org; a=openpgp; fpr=10FFE6F8B390DE17ACC2632368A92FEB01B8DD78 Content-Transfer-Encoding: 8bit On Sat, 24 Jan 2026 18:20:54 +0800, Haoxiang Li wrote: > In fsl_mc_device_add(), device_initialize() is called first. > put_device() should be called to drop the reference if error > occurs. And other resources would be released via put_device > -> fsl_mc_device_release. So remove redundant kfree() in > error handling path. > > > [...] Applied, thanks! [1/1] bus: fsl-mc: fix an error handling in fsl_mc_device_add() commit: 52f527d0916bcdd7621a0c9e7e599b133294d495 Best regards, -- Christophe Leroy (CS GROUP)