From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B351E350A0E for ; Fri, 30 Jan 2026 15:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769786141; cv=none; b=E3Z9IkSaBFLxtq37sZtpYrXj7+VXSXSayaUNhTyP7lrOzvmRmVSX06HsP3ufpE1h47lr5NWHcanmuaGwd6KNokRMQwbqweSkVZ+R/ttxMxGeBxUl1/uL2sOEBVI6uwIOwtecNuttQdtSLc2I2qyKUnDIEo3fvL7Y2i4K9y3cQrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769786141; c=relaxed/simple; bh=xq8N5rkWJosi1QCZTkRqp4ARpm4m9Vn7+on7SBNNI9E=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=A9cVTwtvdyAKJSn6vIJUSPQGTAs/vY4kP6C5U4yQyjaYAxuKEXgI7AGFpqz9BG7uA/TGiXJ++pFjptkrBNQjxpZ/99y37aY55ACSygPh5H3lWBU3qf8Qwa4clzSqAQnO7tPd0JMof++/5rvclRPj0dlmI9M2TlAUq51bYoULZxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XEnPMAAh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OtUaZ61w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XEnPMAAh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OtUaZ61w" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UAnigk1022128 for ; Fri, 30 Jan 2026 15:15:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AvR+veMNXUN9kD5s1VOKjCZx6VF0YVbXKpl5oiQlJqU=; b=XEnPMAAhFkGB9oau aRnjV3x10vn2TpqZ7rJHykFaWXzSDf+1h6QZfeFSbVhZiVwbdAnr95f2NGlX9rpm 8rUVMU+vFqYKyOK35fCBIwgu+dm+NWyoxuNEFbHfca14i9bXMS04Mabef8dD89sk 4qYJ3f5d8Bf65KIIgUf5lAh5/HqBpxGr8Me0cDVBUfPIj3UhgyRUsFb98ZkdoXap sXr2Lk+T/APvmbFGIofq3JNMLFW7siUJnr+9gc0Y+zgENee2UsfRrVtsSLXaS3Ci TlZv7NJwUG5HWyrYIV+c4CnzYHdsRsPf/tyQknP4Se+BL3i0zcI8eD+4SwLKp/8m hEdMJg== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0e3kb20p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 15:15:38 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2b71041d135so2244158eec.1 for ; Fri, 30 Jan 2026 07:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769786137; x=1770390937; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AvR+veMNXUN9kD5s1VOKjCZx6VF0YVbXKpl5oiQlJqU=; b=OtUaZ61wkQT7wT8UHAnFQ7MgHixC3VPzZMUpRkYqE7qpfG7HMCXWPA808VquAg9F1x CZ/QPxBrTTU+xKoO3Oa5ravPpozFnEzpGWy+ySh8AEOi5y31iMn07x7pGObqYI8U3LiA cdxFaNrfGSIK9jb7+E0tknUDRzCW2njSnYYFskE6A87B8+dF+lP3xr7saKp1ttDFUkZY /hDM4Oo433Xl1aVjxA54opD0VU28nyDDGWRSrY79SEof+dFUKO8SoReHgsR55g8s7Udt IcRe46kbBPdK++FFt9I8S5RtyYoO+cRdSccqPONQrVZ1zCMFTyJRprVxir/bFr2YjjQ1 J1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769786137; x=1770390937; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AvR+veMNXUN9kD5s1VOKjCZx6VF0YVbXKpl5oiQlJqU=; b=dGLsE7PXTTABzyQAb3qERyxvpaJryOTojgt+gaDexB/VIfyrnKI3T1mKajBOgNsltA 8Xs2ofwXyV7JfoeWFp6ZPqHpU46EGINK5caFVnrobPQpCwvTncAN9n2eRA3Oq8+nPZE4 UvItDg9hkqo2dHKyyLXIFxVzcQ4DJrkOgOoiJ/AxjfE5o7zbgOdx7rPUfShlxlB483MP OlaIYL6eA4NsoE5z+0btfbOv9t9hAJm1zjl3ylHLdcGfy+AaFH6+bVNY4VBn9fHnytEi OwRnm6q65E2+6BqxmHWxLOOITPg11Q7U+G6FSwKUGqedebhhlr3SGRCUamGDuTcPlIA+ 1ItA== X-Forwarded-Encrypted: i=1; AJvYcCXNq98pVp97MRHiNHhNDTpxfJaAplib96BtM4x3gXn7wOcgaWr5NJaopgI8a5D6Ijx3HZfkY3ihtEm/4IA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3kOvjCRi+f2nh/pA5y6oYITbAllxenHVPIou62GEZr+W0q74v 13ddLIJ8F/sHrwmyeZBoEU+bHTlnpenZHnqepdwJcDiQ5pmBkuljP66pOVGz5vdsC53soUYuz0v fWgzpRurOrTmBZHEOdoXleCoukM4CLQGYbEtgGScn1cOTQ6/h20T+KDKWRZAP94qNTHdC3H6X8n o= X-Gm-Gg: AZuq6aIytMBA7KYgy/ljMyFBT9XkNA0Djf8V4Gk/Y6IacnIvPVFj1fSbL7OgzznP7sy i09J4vwFMAWjJVrBKKdPHm7hJ6XAgehQVMr77BYk+UlPtQIE6VnfbmytU+XfsHQfUjQfSsLXASs un+qD+E0MtVnwwTbkzrobCm8Muc7BMhe61TV+c6OBJpa9WODEG+m0kaz+jaStCD3Eviuhp3GmX1 MF5u6n9DFjURhMcQM3jK5KHpF9XVdWpyw8ZRV9vF+RdFHSMKklFTM4+ojsWIVzbTnzm4LI/CyTi ft569nGhK23tYY5co+U2oQ4izOIZ9Bx6X70SJ00KPe2HHdB3VfmyH67JKVHW0duMmQ1+6zS9J6m biJX3UE5LfnBloG/ozYClum2gFfpIcc1Cb++ukQSm/DC9z5pvfEf9uhsk0q4BNpIL X-Received: by 2002:a05:7022:1285:b0:11f:19f9:c5f9 with SMTP id a92af1059eb24-125c19cd9fcmr1148395c88.12.1769786137216; Fri, 30 Jan 2026 07:15:37 -0800 (PST) X-Received: by 2002:a05:7022:1285:b0:11f:19f9:c5f9 with SMTP id a92af1059eb24-125c19cd9fcmr1148376c88.12.1769786136559; Fri, 30 Jan 2026 07:15:36 -0800 (PST) Received: from hu-jjohnson-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d7f95asm10252849c88.7.2026.01.30.07.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 07:15:36 -0800 (PST) From: Jeff Johnson To: Jeff Johnson , Ziyi Guo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20260123175611.767731-1-n7l8m4@u.northwestern.edu> References: <20260123175611.767731-1-n7l8m4@u.northwestern.edu> Subject: Re: [PATCH v2] wifi: ath10k: fix lock protection in ath10k_wmi_event_peer_sta_ps_state_chg() Message-Id: <176978613592.3951544.9728416314683408699.b4-ty@oss.qualcomm.com> Date: Fri, 30 Jan 2026 07:15:35 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-Authority-Analysis: v=2.4 cv=VI3QXtPX c=1 sm=1 tr=0 ts=697ccb1a cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ng9WqdB7omV95QdvlpsA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-GUID: oHZJKObKVT-_OKxFUcs5-73y4LCC6dTs X-Proofpoint-ORIG-GUID: oHZJKObKVT-_OKxFUcs5-73y4LCC6dTs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDEyNSBTYWx0ZWRfXz0XgqfH06f6l f97tgOB6E3W9Z3JeNwGyPm9d/Nlxnyze2jnlB6nZW2nn7+2n4vK/mKP3kNYPzu1telLDVQvgHRk ayeGmhGMO2BUH/XG1JUAVsYc/cEcaI5W6PUjDQYMVc2hR6/UJIeoU/681MWWSfQ6k7KOU1MCm5h h7rCgiyL2fSY3CZcGAoa/t+erVabq8VfHaNnBBLRyXnCpES0PMJdtR7x+TT3YBtelVADRZS8pjA nHoI2IpQesFD/2Rx/H12uMxNZzBIhSSF9xGyVbbSzAMkT3CZkccIM3xcRTYlZ5iTq3QN2ZFJ9PE Kq/h23AY2Eb9ZFK5OtGcoJa3p53NNW4xXPwUFKgmqsyujTqLHIu1ny7+cW8FTy8wBJsGIQt3rOL x7ecG7m/KOUqAI1YHCJTnwRllOpjIbz7sISDyY1eRgL0vaJyG+Q8DtTl9NFQ5wuSZJ5vrImMMHL j+KFOkR2ZeMO8WJrw2g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_02,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300125 On Fri, 23 Jan 2026 17:56:11 +0000, Ziyi Guo wrote: > ath10k_wmi_event_peer_sta_ps_state_chg() uses lockdep_assert_held() to > assert that ar->data_lock should be held by the caller, but neither > ath10k_wmi_10_2_op_rx() nor ath10k_wmi_10_4_op_rx() acquire this lock > before calling this function. > > The field arsta->peer_ps_state is documented as protected by > ar->data_lock in core.h, and other accessors (ath10k_peer_ps_state_disable, > ath10k_dbg_sta_read_peer_ps_state) properly acquire this lock. > > [...] Applied, thanks! [1/1] wifi: ath10k: fix lock protection in ath10k_wmi_event_peer_sta_ps_state_chg() commit: 820ba7dd6859ef8b1eaf6014897e7aa4756fc65d Best regards, -- Jeff Johnson