From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 938B522B8B6 for ; Sat, 31 Jan 2026 13:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769867351; cv=none; b=Qdyi2LRB1bzHQCZVEEIcL4DATczHGqMc1UYnHzncibuoiT65tvosNLtupwkcrijQaC2N4h/HEgEF08EGT5wPYveYHOi/85lvTb766PPz3P0nVEe3kmpA/itaEGSKXuOhEa5j99DjmTsAMUGku9w/3dwQD/Gz466FHaA7PyMg5Pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769867351; c=relaxed/simple; bh=/gOFXD9nThQ0vLPPYxOy2VEWy0lENVXv1tENI9CtWF8=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=lfFJgCGmXxVJ2CSOzkjGkzjon/0080zramP6jJVU381NmjbE/v5xNxJ4bQdMUdqj8bHGmkB3+fWUAZI5NzerbeF5La/DS1ESaaTaGWMR74uG7Nscqmlalh5PYnBdPWZdrrK0nvIZbl+nhzOxRBG7/vMaooelgMtbPhbtccNLy48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=a7cRz+rS; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="a7cRz+rS" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-3f9ebb269c3so1447154fac.3 for ; Sat, 31 Jan 2026 05:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1769867348; x=1770472148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R2jyQzt8IRTDPBUvo6K1XygSmaxOASgA/JR84N4qE18=; b=a7cRz+rSnt17WFGwP924FgAtjfCCmmvVvxntq/WVWlKq3dwZKUxytt+aVENZo2D39y KYBy/1U25e/OnvKdYEIChsIk/dF6nlI3ya7U9DKztivpEH6c5KAA2Vky7IJ/vk+NMPWK xUbI8NWFcYhymJ2UffrEk568XEd2BJa8/ukh2T7k8x0YtJ8Cm3tifuLJmBi80Hp6mskn sqaAOfvWrcYf7dI7kgXtdp91VVy2icOcHSgB03b7To1AMm0Ja8IaQiC5WG8rOR7hY9z/ D0gYmYFhWXVddh04Cx9cZay8jQwAydbnD/i5g0xwEPa3Uj3q65ddlV4fQ3MiHcFONYsJ +e8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769867348; x=1770472148; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R2jyQzt8IRTDPBUvo6K1XygSmaxOASgA/JR84N4qE18=; b=XM8J7n3E3ED+dmFV8eae6CXL7UZtpZjgPEsGKl5mtTSDBQkwFFuy/uohHf95AeZsmo wzCr2ADifuBJ2rmuosueErrTEtefBKsS1J68Q8bki+pJl/92PW0p9eltU18UVgs8PJL3 IvSXLAE7MFaGxX3k1M9OytT6zBNzYwPfaaCxIfRgl/vCnNM+iPFu/mKaxE+QWgSGVrsM dKTCMnK+J5pYJvL0rWkU4sm+5QT19GMYb0DFG/XpMcSz0ZfJfD9MjJcaHpQYhNbswuTu pL+y6isrnca5PS8OjbB7iwTMZLhliLd7BzMaYcWy0vgDaXPoBZ4F5/qb6AA9KL+Me1KY FlmQ== X-Forwarded-Encrypted: i=1; AJvYcCX9NAhQh+tb96nG0w5rxHzteVWPzaj5zasqT5hxgebDIjmK2+HXfmAUdQ4QVmGPo5WXophbhXcoU1+ukP0=@vger.kernel.org X-Gm-Message-State: AOJu0YyMrX8ru76oWYHx3zhnV3qOHY7ZV2pAgQjuq1dIZD8y0QWfhCKe BkhsFOOpRLgime0ZDfB/xkg4MW5/rrYlEeP90kov8ISQ/D4d04C3R8ff0bVDsFlUPYI= X-Gm-Gg: AZuq6aKcq01CC1bET0G1sFPcmSk+T4CBwqWBqcWxtsB1vbxIfYEzfMXsZ7Z/Ae3OS17 9UFyvpuhEf5ThCaWtLhiNM7Z4vdd5lPXr1iYb/Na1uljvPuSNkDD9tk83d+LWEqaI9IlrIa02n3 nnzA6dRkLrdrvxRYsdLnC0NrvJKK50sfyXS0/HDWRf1wnQLoCv39H/1ol84pwId+7zBLu1o4Nh6 J8l6Q16PNZei7mlnr5knMpmeT0HRrk/scO478pgDw/oPmEfFWy48L9Fuj98DG1VTUPUkY1bmM6s XliIDHvhottGsquLFAzTPjZidk8Dlni3Wt4+LTr55UEdv/F8B8kRGQa2dMdMYSG6R9sBemOZFFP Iwb2YDUQeyyKpQbw8wTtwBONtD0FLxL1UfQHBQnbiq6KJXTApMQ/C3cJjAgyy9vr6wXwHhoKuTk zrar11RBl35RHvqtKEpXp9aCW6qyeWNuLJBNquO3HxTKXsmOKVF+CVddcONpLNISl2 X-Received: by 2002:a05:6820:4d4b:10b0:663:f65:1c97 with SMTP id 006d021491bc7-6630f651d43mr2115238eaf.63.1769867348020; Sat, 31 Jan 2026 05:49:08 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-662f9a19cb4sm6575789eaf.9.2026.01.31.05.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 05:49:07 -0800 (PST) From: Jens Axboe To: Ming Lei , Caleb Sander Mateos Cc: Govindarajulu Varadarajan , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260130171414.1376543-1-csander@purestorage.com> References: <20260130171414.1376543-1-csander@purestorage.com> Subject: Re: [PATCH v2 0/3] ublk: fix struct ublksrv_ctrl_cmd accesses Message-Id: <176986734625.961362.7129018676090960172.b4-ty@kernel.dk> Date: Sat, 31 Jan 2026 06:49:06 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Fri, 30 Jan 2026 10:14:11 -0700, Caleb Sander Mateos wrote: > struct ublksrv_ctrl_cmd is part of the io_uring_sqe. Since commit > 87213b0d847c ("ublk: allow non-blocking ctrl cmds in IO_URING_F_NONBLOCK > issue") allowed some commands to be handled in the non-blocking issue, > the SQE may lie in userspace-mapped memory. Validate that the SQE size > is the expected 128 bytes before dereferencing it. Use READ_ONCE() to > copy the ublksrv_ctrl_cmd from the SQE to a local variable. This avoids > data races if userspace writes to the SQE concurrently. > > [...] Applied, thanks! [1/3] ublk: Validate SQE128 flag before accessing the cmd commit: da7e4b75e50c087d2031a92f6646eb90f7045a67 [2/3] ublk: use READ_ONCE() to read struct ublksrv_ctrl_cmd commit: ed9f54cc1e335096733aed03c2a46de3d58922ed [3/3] ublk: drop ublk_ctrl_start_recovery() header argument commit: 373df2c0255da77f0842368708afce771e1330ca Best regards, -- Jens Axboe