From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D82B322753 for ; Sat, 31 Jan 2026 13:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769867353; cv=none; b=WK5ef9g7I3mWg2QYLGh63Of4oZfhrCTJJqq4DIM/KQwtda+tito6yfFVF4M43pAIssoXrPtQptkmI7vsg9uaRF4vEk/8fFookiVnWnIs0v09jahjkYC2Qrzo/rsqYGvD1bnQI7gSyDZL/ajWAt8FNxEJZtlSwBoXPdIfNwIXpvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769867353; c=relaxed/simple; bh=PIuQwJICRkdXwKlZJc2OOqIS3RqDS1HMvtT/iqeO/qM=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=AyMCxzWwTZ2VkKm2U8t7TRffqEahxG4Ae3n00uBaK/yUl5XLDW6ue1zyjBPGdQsnBSeoYsMgS1D8mwUE+sGAUFRc7sA6PxJ1QF9u0SOVHK3+d8Q6wM9RMBkRqP1Cr3YB23WLBZR0B6Pz3jlTASWSW7s0n9V2qS+kPQsXNBZwxX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=qE6zNfCJ; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="qE6zNfCJ" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-662f65c7d8cso1686819eaf.2 for ; Sat, 31 Jan 2026 05:49:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1769867351; x=1770472151; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EjuuAT4RnNe5hWPU5ljQ0ilmliBzevq8hmX9YQy/wrQ=; b=qE6zNfCJ4fj47PVpAhZoHqB9SWEzAtLTFTP1qLpgX14l+bcCP3eSPZfEojUgc1V0pX DIZ9GePwZLnm515bO2k6PANKFieX/F3wUawe+kmkLws8Ma29f0rvZPwCFfq0qcsZfiai 2X6e+TXZ6ROhbeX9Np1ubukshK3rUyc3izcG2lHawjKShUqp0r1DXxCiXuhysfStF6Py 5pE6c+KPhHMoH+J048UVa+rUveXeCiPEetAWrYcL7Q38SS4r8Ls9a7O6SwhNRvkAw0wD TSAThCZ75L1nU47AbpGUgbuubRXqweP8/cn4LClhnptz24MBt7vG0xqxMaIceSjJsF0f YPgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769867351; x=1770472151; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EjuuAT4RnNe5hWPU5ljQ0ilmliBzevq8hmX9YQy/wrQ=; b=d7mx2OiNIj58gssKqd7siKuwEkGXhUbG0ETZj70cb1j5p9VdX1sY4OCMi+IZud0hop cmgZgx01wbVi9aB3Y75O6GUK89S6LyRhLVTZoC+YuicgsWA14ednRKO9oyXsiYq/uTFt ptS0/lUsAcoBws8lDZA4CIDFDOB8sl98t5QTbKCwl658xlxx97KxOt8gYodtVTLAw8Oa NmpXvteIr9QFHZOw8JCF5/EKZIMvevuaG0NfBgpQIdXgzyLX1rVQ5I8oBFHAgdrI/qmw tn0E7UarIE0nenlvh1M6HTNFHHaq6hdMIJOEkn9sG2+kH5iFl81gzU89dVrzybYcbde9 KR+w== X-Forwarded-Encrypted: i=1; AJvYcCWL9zaYvSDxPrMWhSy8X2EGy81v+jbnNN8V94tCjMSlYfjev/XDbDNi0BclnICYYMm1hS4msFNWjh0DmMg=@vger.kernel.org X-Gm-Message-State: AOJu0YwXUvPaL28MfRvV7RdSX3BkwdX7Og3m+APAP0+O/RqgbBj6OvHS SWeSmIt15Fv71ncUgTSIKqkbxKRcM0sLnMRBzD9FwkRufdUKhsrdex2+8h51IpVPibY= X-Gm-Gg: AZuq6aKc6IaS2Qr4MPDzff9ilHCARVcds2uVibMrwBp/boP+HxwP8Jou4LbDipXR1mT gjhsfwWr2f0f54F5/339RBokYqOKF0s8BPdq0jOkorOI4vVCoHkR62VZYJqUL5rcSYOkG2xWlWp 46D3tg9Dtn7Ns4b2DJTZxOLgXPs7mWwZs5ZPS7Gjz0TxtgQdUK4xSwPbTlrFslwCKGO7iLjYcbT XpWa066DqzGXyg0Zn3vMojBrRlJHJbPe9eSRP4ocgLnVeWMEv3B2ZE/WnMV9z2zqZaWzhGzUYY0 ddc2IcC+cZHomx/4cmDS4r0sCqtccmOFzJynENfCMUP+mC9bWOdkOeAT7r7RJf0ppfp9fLYcKsQ qDcs5iMiaYLSxs4vxOjFWEeiM/q0vM+4s/pjQrwvtj5UcQo2x2zqob+wnEilvWZ1Z8HFKaZzzXR 4Fb4bkGqe3u6m5XLJQ/BhZvNf3xc8QSFTXa67DYSEQymaGBmY+iJpyPicd/7M82eiO X-Received: by 2002:a05:6820:60f:b0:65e:f0f9:aa7c with SMTP id 006d021491bc7-6630f00a07amr3069502eaf.4.1769867351276; Sat, 31 Jan 2026 05:49:11 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-662f9a19cb4sm6575789eaf.9.2026.01.31.05.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 05:49:10 -0800 (PST) From: Jens Axboe To: Ming Lei , Caleb Sander Mateos Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260130152531.1274646-1-csander@purestorage.com> References: <20260130152531.1274646-1-csander@purestorage.com> Subject: Re: [PATCH] ublk: remove "can't touch 'ublk_io' any more" comments Message-Id: <176986734954.961362.1910133026196372474.b4-ty@kernel.dk> Date: Sat, 31 Jan 2026 06:49:09 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Fri, 30 Jan 2026 08:25:30 -0700, Caleb Sander Mateos wrote: > The struct ublk_io is in fact accessed in __ublk_complete_rq() after the > comment. But it's not racy to access the ublk_io between clearing its > UBLK_IO_FLAG_OWNED_BY_SRV flag and completing the request, as no other > thread can use the ublk_io in the meantime. > > Applied, thanks! [1/1] ublk: remove "can't touch 'ublk_io' any more" comments commit: 491af20b3c6d5baedb96357d4b12232ae490cbe7 Best regards, -- Jens Axboe