From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
Han Gao <rabenda.cn@gmail.com>, Han Gao <gaohan@iscas.ac.cn>
Subject: Re: [PATCH 5/7] riscv: dts: spacemit: Update PMIC supply properties for OrangePi RV2
Date: Sun, 01 Feb 2026 00:18:01 -0500 [thread overview]
Message-ID: <176992308158.607015.980372835663972481@lemur> (raw)
In-Reply-To: <485bf9935397707158529bb7c0eec6cb20ffbcc3.1769895215.git.gaohan@iscas.ac.cn>
On Sun, 01 Feb 2026 05:38:12 +0800, Han Gao <gaohan@iscas.ac.cn> wrote:
> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> index d8d0baaec731..c0a0c96f2ac4 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> @@ -134,7 +134,15 @@ pmic@41 {
> compatible = "spacemit,p1";
> reg = <0x41>;
> interrupts = <64>;
> - vin-supply = <®_vcc_4v>;
> + vin1-supply = <®_vcc_4v>;
> + vin2-supply = <®_vcc_4v>;
These per-rail supply properties (vin1-supply through dldoin2-supply)
are not declared in the spacemit,p1.yaml binding, which only has
vin-supply. With unevaluatedProperties: false on the PMIC node, these
will cause dtbs_check failures. The binding needs to be updated to
match, or these should remain as the single vin-supply.
--
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
next prev parent reply other threads:[~2026-02-01 5:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 21:38 [PATCH 0/7] riscv: dts: spacemit: Add PMIC regulators usb pcie Han Gao
2026-01-31 21:38 ` [PATCH 1/7] riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2 Han Gao
2026-01-31 21:38 ` [PATCH 2/7] riscv: dts: spacemit: Define fixed regulators " Han Gao
2026-02-01 11:31 ` Yixun Lan
2026-01-31 21:38 ` [PATCH 3/7] riscv: dts: spacemit: Define the P1 PMIC " Han Gao
2026-02-01 5:18 ` Konstantin Ryabitsev
2026-01-31 21:38 ` [PATCH 4/7] riscv: dts: spacemit: Enable USB3.0 on " Han Gao
2026-01-31 21:38 ` [PATCH 5/7] riscv: dts: spacemit: Update PMIC supply properties for " Han Gao
2026-02-01 5:18 ` Konstantin Ryabitsev [this message]
2026-01-31 21:38 ` [PATCH 6/7] riscv: dts: spacemit: Add a PCIe regulator " Han Gao
2026-02-04 13:50 ` Chukun Pan
2026-01-31 21:38 ` [PATCH 7/7] riscv: dts: spacemit: PCIe and PHY-related updates " Han Gao
2026-02-04 14:06 ` Chukun Pan
2026-03-10 9:03 ` Yixun Lan
2026-03-14 7:50 ` Chukun Pan
2026-02-01 5:18 ` [PATCH 0/7] riscv: dts: spacemit: Add PMIC regulators usb pcie Konstantin Ryabitsev
2026-02-01 7:54 ` Vivian Wang
2026-02-01 15:10 ` Konstantin Ryabitsev
2026-02-01 11:26 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176992308158.607015.980372835663972481@lemur \
--to=konstantin@linuxfoundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=gaohan@iscas.ac.cn \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®