From: Markus Elfring <Markus.Elfring@web.de>
To: Jiping Ma <jiping.ma2@windriver.com>,
linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
Bruce Ashfield <bruce.ashfield@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Will Deacon <will.deacon@arm.com>,
Yue Tao <yue.tao@windriver.com>, Zhe He <zhe.he@windriver.com>
Subject: Re: [PATCH v2] perf: perf can not parse the backtrace
Date: Sat, 9 May 2020 13:15:38 +0200 [thread overview]
Message-ID: <1769b8a4-fc93-c3d7-2dab-9406ea1eb491@web.de> (raw)
> Record PC value from regs[15], it should be regs[32] in REGS_ABI_32 mode,
> which cause perf parser the backtrace failed.
I suggest to improve also this commit message.
* The patch subject was not succinct.
Should any information be moved into the change description?
* Please avoid wording weaknesses.
* Would you like to add the tag “Fixes”?
Regards,
Markus
reply other threads:[~2020-05-09 11:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1769b8a4-fc93-c3d7-2dab-9406ea1eb491@web.de \
--to=markus.elfring@web.de \
--cc=bruce.ashfield@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=jiping.ma2@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=will.deacon@arm.com \
--cc=yue.tao@windriver.com \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®