From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3783261B96 for ; Thu, 12 Mar 2026 12:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773318897; cv=none; b=p6znbrTBF0OESQ+We3d1uCq3Wf/0CecxFAV+7vmY2xcBr5lCJepFAtDR0Rh5BwKBNy1ms6sWFmyVut5zD/IslevjZTROAriPSIq3IRPAhKKg8W819sDbuKpq2Yt3gZ+aAQ0byp9VkwVMqaOGweh0LTMDgqzQp24B+6UTTnqeWx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773318897; c=relaxed/simple; bh=8anETn248/lbpRrxYoLNFCBodOwdNOa+FNpgk5FB/H4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NEtDzpDnzcmPLmlQ3BiyaaotuU4b/NC/wiAiUo129tXKUahPMV1ZrWPe3yWjSAUOt7F0sFWXiwkEggt9hPRpopt2R0jQvmIbo9DD8bJOnyEMn0o3PWWSJxM32MNVH6Sb8XKApZVMd21N/t61M18dUaXdHzI4KxnKife3Dq3Vfmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hjhAY+2O; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hjhAY+2O" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ab46931cf1so16166225ad.0 for ; Thu, 12 Mar 2026 05:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773318895; x=1773923695; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iY6qluq0Nn+wzWD7asAwkfwR02cHSUhgsW/DTGcOm9M=; b=hjhAY+2O7OrxXlpu/debEIVH7KJ9jxuZrjCiiUZ9yUT5SsQ8PfNCTEn6MHCcT8uagc M6260xCdi/y+sBK3e+JiFu2ZamxmDusDE5wCC1Is0xgkkQtH5OJKBSh9JjiR2uvJ5BMz x3ijeDUdLZe9LtxV+9fvWkQujGeVuXqf88FbLZ8FO5b40OdatYtqENbvalgTe+i/CssQ p/k8+mQKAkUI2WGyIUN8AghzP7nqzsTZOd16NYGl1CMKBvQDn97EJmMF44rsDbfn4yU4 1w8dI0vLID8SdC8qzZcVMp3BT64hynZ13866gpX1KPqKjcW+2E8IqfYT5KIkJb+CQeGK gasQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773318895; x=1773923695; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iY6qluq0Nn+wzWD7asAwkfwR02cHSUhgsW/DTGcOm9M=; b=cQG662aSoSHafOOjehQk1JfSATZRQo/7chYdvjvEILr7mWyja6AN8dxahjdsCOfU6A DNXSc82HrKRFaqnOaCeH5gN4jaOkrwLg3xbPmV+igONm8DbMM6yqvxJZT5cx4ZdSjt2K el+4sWQUofKk6O3mjrPvKZs5yhurITEbWEhMgnu9peg9TUrFyMg22HDNh4xqOVbYr2yd abUHDVHo49BbSELgzxMhA/4QI+TVjt97D7ksGYriflL0IDvQ4y/hsZUu2l73GOMVVjT5 EHyEklqRu9qTxU/PTJtJ0IMi40/QYoUcKhm1iI9Sbr3piZlwZ5xhTNSzb+SkgvJOnzeI QnQA== X-Forwarded-Encrypted: i=1; AJvYcCVJdYsLjN8YJl31kMAvqPSuMdwxhNFCkV8jNvJvQ1m8zSlHS8181/LcWookBfh7Efpo8Z1f5L5IABl2lJQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8TSDTbvXA8oXInQ4mYY6EQhi5oqUjdYHqfI+b9c9VwLXtXdxG huXINgmUeI53nXYXcGChFwZO3ghAT+UbKMaYxhkVkRZtmkLVD47hfe6V X-Gm-Gg: ATEYQzynBVw4tLWfG7785pcL70APLlfpR5yYAsrB2T7g8pG/ZqOLU3m/tHb9OLGVyz/ Q3hyOE3y0rzu+P75TwzN18xK0+gBL3QRq6ibFe/TAPjpFNrmyBPdjw0g+VBqeKAnCFYXLR1AYss ZAreOgp6NPsqnHiwm3GksS/L1k7ZRkQwwziV1j7QQChFa6Ev87Swr3pYSfGJ2GyhzTF8tGCFYs3 AU9U24naEp6pF//meuQaxo7NlSCR7jt62X52oIpj2g4cDEhqV5pxGIGXaYorRwOHn4CHcKq7fIW K6vF15I8viwqCu+/ut80qrS1/+6dSTg4/BNgWrgi87AUDjTVxuxoho7XENIi4YQRQwji5FS4sa7 GCIuxuk5j5ZgLk9hrTzkXBSvoymEOejGZ3hiv0AVtZ+Mavu/k12KhGR56bJUBarLV7gPuGxz+uR lH2TpIwSJLKwqA9+1+6N6j1gnWSR9yA30= X-Received: by 2002:a17:903:37c4:b0:2ae:7f85:33d1 with SMTP id d9443c01a7336-2aeba2e60d8mr31496605ad.0.1773318895227; Thu, 12 Mar 2026 05:34:55 -0700 (PDT) Received: from [172.16.20.13] ([136.226.252.245]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae2228easm55925065ad.3.2026.03.12.05.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 05:34:54 -0700 (PDT) Message-ID: <176ed865-11a6-42de-89e0-06951b59a430@gmail.com> Date: Thu, 12 Mar 2026 18:05:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support To: Marek Vasut , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Luca Ceresoli Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, valentin@compulab.co.il, philippe.schenker@toradex.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260312043743.261475-1-tessolveupstream@gmail.com> <9f694b2d-44bc-46ad-8aa3-b464c2f0da13@nabladev.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: <9f694b2d-44bc-46ad-8aa3-b464c2f0da13@nabladev.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12-03-2026 10:35, Marek Vasut wrote: > On 3/12/26 5:37 AM, Sudarshan Shetty wrote: >> Hi all, >> >> This patch series improves dual-link LVDS support in the SN65DSI83 >> DSI-to-LVDS bridge driver. >> >> Currently the driver programs identical horizontal timing parameters >> for both single-link and dual-link LVDS modes. According to TI >> documentation, when operating in dual-link mode the horizontal timing >> values must be divided by two before being programmed into the device. >> Without this adjustment, some panels fail to light up or produce >> corrupted output. >> >> TI also provides recommended register settings for dual-link LVDS >> operation. This series adds support for an optional DT property >> ti,dual-link-video-mode that enables the required configuration >> in the driver. >> >> When the property is present, the driver applies the recommended >> register settings and uses a simplified DSI video mode configuration >> to ensure correct dual-link LVDS operation. >> >> Summary: >>   - Add DT binding for ti,dual-link-video-mode >>   - Add driver support to enable dual-link LVDS configuration >>   - Apply recommended register settings for dual-link operation >>   - Adjust DSI mode flags when dual-link mode is enabled >> >> Changes in v2: >>   - Introduce ti,dual-link-video-mode DT property >>   - Add DT binding documentation for the new property >>   - Update driver to read the DT property and apply dual-link >>     configuration conditionally >>   - Adjust DSI mode flags when dual-link video mode is enabled >>   - Update commit messages >> >> Thanks, >> Anusha >> >> Sudarshan Shetty (2): >>    dt-bindings: display: bridge: ti,sn65dsi83: Add dual-link video mode >>      property >>    drm: bridge: ti-sn65dsi83: Add support for dual-link LVDS video mode >> >>   .../bindings/display/bridge/ti,sn65dsi83.yaml |  9 ++++ >>   drivers/gpu/drm/bridge/ti-sn65dsi83.c         | 52 +++++++++++++++++-- >>   2 files changed, 57 insertions(+), 4 deletions(-) > +CC Luca > > You might want to look at recently posted: > > [PATCH 2/3] drm/bridge: ti-sn65dsi83: halve horizontal syncs for dual LVDS output Thanks for pointing this out. I tried applying the patch “[PATCH 2/3] drm/bridge: ti-sn65dsi83: halve horizontal syncs for dual LVDS output” on top of the current tree and removed the changes that I had previously added in the driver. However, with this patch applied, I am currently seeing only the backlight turning on and no image on the LVDS panel. For reference, the LVDS panel used on our platform is G133HAN01.1 and the DSI-to-dual-link LVDS bridge is SN65DSI84ZXHR. During our earlier debugging, we went through several trial-and-error iterations and also received support from TI. According to TI, when operating in dual-link mode the horizontal timing parameters must be divided by two before being written to the device. Without this adjustment, the panel either does not light up or shows corrupted output. TI also shared a set of recommended register settings for dual-link mode, which were derived using the TI DSI-Tuner tool. These settings helped us get the panel working on our hardware during testing. For reference, the register configuration suggested by TI is as follows: regmap_write(ctx->regmap, REG_RC_LVDS_PLL, 0x05); regmap_write(ctx->regmap, REG_RC_PLL_EN, 0x00); regmap_write(ctx->regmap, REG_DSI_CLK, 0x53); regmap_write(ctx->regmap, REG_LVDS_FMT, 0x6f); regmap_write(ctx->regmap, REG_LVDS_VCOM, 0x00); regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_DISPLAY_SIZE_LOW, 0x00); regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_DISPLAY_SIZE_HIGH, 0x00); regmap_write(ctx->regmap, REG_VID_CHA_HSYNC_PULSE_WIDTH_LOW, 0x10); regmap_write(ctx->regmap, REG_VID_CHA_HORIZONTAL_BACK_PORCH, 0x28); regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_BACK_PORCH, 0x00); regmap_write(ctx->regmap, REG_VID_CHA_HORIZONTAL_FRONT_PORCH, 0x00); regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_FRONT_PORCH, 0x00); If it would help, we can test any proposed changes on our hardware. Please let me know if incorporating these register settings or additional adjustments would be the right direction for supporting dual-link LVDS in this driver. Is the current patch expected to fully support dual-link LVDS, or are there additional changes planned for the SN65DSI84 driver?