From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E12623368AC for ; Tue, 28 Jul 2026 19:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268429; cv=none; b=jNEkUjCTnZ+uaNdMOopljxBRGUFmR86YIWO9nMw4jQjHLqOXDRLssvhrHUzdiRFzFH4JlA6v6UdgV7Il1zzE6s7rX7xst73xwe0xmPdDvasjUQowCrY0WJkZ3NkZ3c1AYIPuME62eO2HHA3WgNKMLD8oGUCL7DMDDtus7S90iCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268429; c=relaxed/simple; bh=pOCc5KHFW5q0Mst1x++Sl8Mr3M3l5xNuWsT/idlKrus=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=HQASoVdirj6AUJpEqSJ3dLoK/qqVVoz65wtWCOr6ToVdo5wVbKXkFIiAzgLKVz5wpFnTm3H9V72vITiIJ4U7OGFX3aOXguLb/2z18mwcoTbBT+eZrf7gHSf0ZeNab/1omv7PmA97LWJARvtpM9tOmzcuB4Qq73kh7GxFRFBqkoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=AdUmedqT; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="AdUmedqT" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-9305a2121a1so18904485a.2 for ; Tue, 28 Jul 2026 12:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1785268427; x=1785873227; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nlIY1L+o2+XzlIosk/mnO5oYFQNniFpsDQXDhKoVxg4=; b=AdUmedqTYF9Vw1cncq2VrSVwcHUgsB2TIadX3QN3STImfZNK3LIeGnrd1ysT2y0SqM WkTPWYK6s3OOMfEs2Vs6NllfBbw8s94WzUtkKOIN946FRHT+o9CYydYFAxepfs8B5kOV 8FH6spBJUN4dcjoKxhEMugU5ZCaCDDTUjF2no/31exldu2dUP4aknbVOjKEXSxBFoQxY eBgzAsUFBFWu4q5WS/UR+2P2jdaNGL1/9NsQVAwzPIlqNL2y3URFu7Gk9XEXQsuH3yD2 5bqwg40oQAAG2nVimjmpKJo3ZTUqrLTin/n+YXmse8HwQHSvz6bUJ3ybw/1FeOdn7yAh y08A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785268427; x=1785873227; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nlIY1L+o2+XzlIosk/mnO5oYFQNniFpsDQXDhKoVxg4=; b=i9Jf7HgfyUjPnAWfuki72ewD54LSlg02YkAsxOrPU5TfaltWNNFJSEVCbdxy/xIWv9 W0+QKL70vduJpQHe6f9ZP0b1Ys2pXtAitEtIKgeCWA0b75MgUYhUn6tdFU1jzulcyNQL g+FiSe/lBjrjrUJXGdYU7fDnmF6nKQj+2EYWobRZrQoEAAH40OsP/OPaexOhYGylNh0U l+ad+bC+LyMPW3p0KKyJyKeVsS7DvWGbpH+Q1oagYAllCI+Nq6jSmy0D2utVLotzfNHc OHXsD2dfOlgH3xXXUYLAscmeyQKqXa/Xtr3NGFe+CAAKUmxx+KU6loieBORoYLAt0fFZ zQjQ== X-Forwarded-Encrypted: i=1; AHgh+RrfNBpFAygq98+fJS5JYwhnyoWjDsKWdb0ppS8u21k5j6JuAlm6y3aztMK4U0qkU+KzjZsqgzZVpzq1UtY=@vger.kernel.org X-Gm-Message-State: AOJu0YxSTUb01tBLBjT2rYbQnFhmPoL9DAUvrAvuBGWDJuUoQTscVl5W ybkrBHN/WxCBruEmcVOhfhsK7wzQpkBkj7ldFRXWdFcQ+/XaPO0iqUpC7/S65kGFqg== X-Gm-Gg: AR+sD10G+crzgMRJjhKIUh8qWx3cNaAZKIG6iNl3hk40SBNUqbl7zcuCb7AthcF1hh0 cC38xEkwOxiiOVm7cTaMn4oCW8gPjwV8kKxAJ28JRXpkwlFwiFgiAjKgZRLyc9mPEDeqe9JrotW zkrUe5jFE8foNCgzHTyuRF2zQtwfw42ZYKw2oiPL0RThK+fwfCxD01v2fu1X6r9msq5qwyhb8hu A0AsQPxKAQP4uaiHSEdjla4lIwzIqtdUC5Bqr3FmgjMBvD1KgneU2bkjKyxCrNhap8H817rOo6b ZEymEr6mJp4w4PaWCOyKU60M6GKdxtrP635ijrqpFiKwATiUCzeJycYQNlty1KqUnZxs2A+Td81 wFMJNFUZVGW54ElwLEF0tjY22dpdCHtk8XGFqCZZheQ9S+xPHOQcRPWAa9+dmc8xkWU+jgxfwu2 hWH7tqmA8JVUxIm8msRokYm7B0sw/rVS0pAU66xSMjcrJ/st13s3L48GTRvT6/mUgl72fjVtINa Y3zZY18y+VKjTkcHAE6y+nLnmp6logZpg== X-Received: by 2002:a05:620a:84c2:b0:92e:62d8:1faa with SMTP id af79cd13be357-933026d2e90mr369668085a.46.1785268426765; Tue, 28 Jul 2026 12:53:46 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id af79cd13be357-933e7361dc2sm5194985a.43.2026.07.28.12.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:53:46 -0700 (PDT) Date: Tue, 28 Jul 2026 15:53:45 -0400 Message-ID: <176efbd2097ef7b8a25b09b5e1f7b2de@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260727_1648/pstg-lib:20260728_1147/pstg-pwork:20260727_1648 From: Paul Moore To: Ricardo Robaina , audit@vger.kernel.org, linux-kernel@vger.kernel.org Cc: eparis@redhat.com, Ricardo Robaina Subject: Re: [PATCH 1/2] audit: drop BUG_ON() from audit_add_to_parent() References: In-Reply-To: On Jul 28, 2026 Ricardo Robaina wrote: > > The BUG_ON(!mutex_is_locked(&audit_filter_mutex)) check in > audit_add_to_parent() will panic the kernel if the mutex is not held, > which is too severe for this situation. > > Replace it with lockdep_assert_held(), instead. > > Signed-off-by: Ricardo Robaina > --- > kernel/audit_watch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged into audit/dev, thanks. -- paul-moore.com