From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660E221CA13 for ; Tue, 3 Feb 2026 20:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770150551; cv=none; b=gjTp9PYQWS0Ae9tQ/5SkzSV40c0riog4ftaIN+joKnU8n83bW+5/7jbEnBZiy5wJoTjswLVEFB1o3kRAjMJH7OIC2EC9x7MEtOegWrcvQOn9Z0wC0FF+3D1hxJQhQGYfXLc/qo+OLYDFWu3yD7Y2hxhCP7giL3GRWu4V4JlGtu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770150551; c=relaxed/simple; bh=2jT+yoL7oQ1u8yM1fI3W/rQ/BqB1ZdxgWwSBN4k1IRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hi4NtquPhg26JCjhZuvAVKEbT4HI3WsyOceeTLAicIIcnHKcEWZMiGF9eJ078/QXZhii2gOBVU1cxR5JnNTDn+07LK8oRBKiRi7mAnIJl21h05yzlad0E2u19yRC5nsi04tye29st/EqhL3gg3/WPBJWIg9HR3ZDBFt9DSIie/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n5vh1XS8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n5vh1XS8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CC6CC116D0; Tue, 3 Feb 2026 20:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770150551; bh=2jT+yoL7oQ1u8yM1fI3W/rQ/BqB1ZdxgWwSBN4k1IRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n5vh1XS8l9T8ddsQL3ODS+DYsWzjBrF9loRh+ZnKwwR+SLWPVxIpU108z46LgDro5 a6at0JZcapEIWGAM61G27qFL+gPaIQKnY7TelJg5/GFnDBWSuCShja55MHEtB5WmWd F3SRnFovLxLC7MhB7vHhffakNCm0/K1Trn6eN8TjaKPxtcX+rDg4etuvmGqXhi7NjZ 2P4ckkC7hkE2BX9jSPtIT6wQkfaMsmE96ANTViZbEMaOv2rqy7m/tFrn8kWZsw3YK3 X2f8DsBiOtg8inlpxjqHT9jy2XkgFnCEqrNDAD9PgvReBJfVivxfUtUe8l7MzcWr8W pqnTybeui3jmw== From: Will Deacon To: Catalin Marinas , Thiago Jung Bauermann , Mark Brown , Breno Leitao Cc: kernel-team@android.com, Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2] arm64/gcs: Fix error handling in arch_set_shadow_stack_status() Date: Tue, 3 Feb 2026 20:29:01 +0000 Message-ID: <177011102209.2472980.4751215527771350608.b4-ty@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260202-arm64_cgs-v2-1-e6a837edf021@debian.org> References: <20260202-arm64_cgs-v2-1-e6a837edf021@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 02 Feb 2026 10:32:51 -0800, Breno Leitao wrote: > alloc_gcs() returns an error-encoded pointer on failure, which comes > from do_mmap(), not NULL. > > The current NULL check fails to detect errors, which could lead to using > an invalid GCS address. > > Use IS_ERR_VALUE() to properly detect errors, consistent with the > check in gcs_alloc_thread_stack(). > > [...] Applied to arm64 (for-next/core), thanks! [1/1] arm64/gcs: Fix error handling in arch_set_shadow_stack_status() https://git.kernel.org/arm64/c/53c998527ffa Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev