From: Jai Luthra <jai.luthra@ideasonboard.com>
To: Chen Ni <nichen@iscas.ac.cn>,
dave.stevenson@raspberrypi.com, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Chen Ni <nichen@iscas.ac.cn>,
stable@kernel.org
Subject: Re: [PATCH] media: i2c: imx219: Check return value of devm_gpiod_get_optional() in imx219_probe()
Date: Wed, 04 Feb 2026 06:26:56 +0530 [thread overview]
Message-ID: <177016661698.9154.10184896089971298930@freya> (raw)
In-Reply-To: <20260202024024.3911367-1-nichen@iscas.ac.cn>
Quoting Chen Ni (2026-02-02 08:10:24)
> The devm_gpiod_get_optional() function may return an error pointer
> (ERR_PTR) in case of a genuine failure during GPIO acquisition,
> not just NULL which indicates the legitimate absence of an optional
> GPIO.
>
> Add an IS_ERR() check after the function call to catch such errors and
> propagate them to the probe function, ensuring the driver fails to load
> safely rather than proceeding with an invalid pointer.
Good catch, maybe a fixes tag is appropriate so this gets backported to
stable kernels.
Fixes: 1283b3b8f82b ("media: i2c: Add driver for Sony IMX219 sensor")
with that,
Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/media/i2c/imx219.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index fee63bc106d9..7da02ce5da15 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -1218,6 +1218,9 @@ static int imx219_probe(struct i2c_client *client)
> /* Request optional enable pin */
> imx219->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_HIGH);
> + if (IS_ERR(imx219->reset_gpio))
> + return dev_err_probe(dev, PTR_ERR(imx219->reset_gpio),
> + "failed to get reset gpio\n");
>
> /*
> * The sensor must be powered for imx219_identify_module()
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2026-02-04 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 2:40 Chen Ni
2026-02-02 11:52 ` Dave Stevenson
2026-02-04 0:56 ` Jai Luthra [this message]
2026-02-04 2:48 ` [PATCH v2] " Chen Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177016661698.9154.10184896089971298930@freya \
--to=jai.luthra@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®