From: richard offer <offer@sgi.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: unitialized variable in 2.4.7 (sym53c8xx, dmi_scan)
Date: Wed, 25 Jul 2001 13:43:41 -0700 [thread overview]
Message-ID: <177030000.996093821@changeling.engr.sgi.com> (raw)
Compiling with -Werror to catch my development mistakes gives.
sym53c8xx.c:6994: warning: `istat' might be used uninitialized in this
function
dmi_scan.c:161: warning: `disable_ide_dma' defined but not used
The following fixes these issues.
8<--------------------------------------------------------------
===== arch/i386/kernel/dmi_scan.c 1.3 vs edited =====
--- 1.3/arch/i386/kernel/dmi_scan.c Wed Jul 18 02:43:27 2001
+++ edited/arch/i386/kernel/dmi_scan.c Wed Jul 25 13:41:59 2001
@@ -157,6 +157,7 @@
* corruption problems
*/
+#if 0 /* commented out until its used in dmi_blacklist[] */
static __init int disable_ide_dma(struct dmi_blacklist *d)
{
#ifdef CONFIG_BLK_DEV_IDE
@@ -169,6 +170,7 @@
#endif
return 0;
}
+#endif
/*
* Some machines require the "reboot=b" commandline option, this quirk
makes that automatic.
===== drivers/scsi/sym53c8xx.c 1.6 vs edited =====
--- 1.6/drivers/scsi/sym53c8xx.c Thu Jul 5 04:28:16 2001
+++ edited/drivers/scsi/sym53c8xx.c Wed Jul 25 13:37:10 2001
@@ -6991,7 +6991,7 @@
static void ncr_soft_reset(ncb_p np)
{
- u_char istat;
+ u_char istat=0;
int i;
if (!(np->features & FE_ISTAT1) || !(INB (nc_istat1) & SRUN))
8<--------------------------------------------------------------
next reply other threads:[~2001-07-25 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-25 20:43 richard offer [this message]
2001-07-25 21:25 ` Alan Cox
2001-07-25 21:58 ` richard offer
2001-07-26 19:49 ` Gérard Roudier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177030000.996093821@changeling.engr.sgi.com \
--to=offer@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®