From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6663EBF05 for ; Fri, 6 Feb 2026 07:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770362696; cv=none; b=BcwgLFsqEvLi7/r0pIpAsxxN5RxDPUsiBx3jk3UscpZnQfjLt+bf4DIf4OOUHCMlpJiuJNZATYYsRWN2dp6c2qBNjRTo3TQUzHrMZ2posX2DNeWy3Ap+2MqeWMlS0RQGSimxdIIbb2DAc4NHUieJpYMt07ctlR6Wkwx8jS+aEtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770362696; c=relaxed/simple; bh=P0NhoGMuk6PH5jP7ZeN3aTohFrPPtEmPqpM83aqZXaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uFguXb8pGFulGk1Omu58h/ubSn3Hq/lzujt7+Gwx0VKVhfYW2izxinQjylFBady0iZkltuWamqIvpelM5NL0TFdJZlQ92+q7rHqJz+zbrvXXO5iyssOJu0Glo/xmNXbaqgO+dxXhdAswKlLjIepNehPvOyY/+H+ejl6zRdXfdxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sbREU9Fb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sbREU9Fb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9EE4C116C6; Fri, 6 Feb 2026 07:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770362696; bh=P0NhoGMuk6PH5jP7ZeN3aTohFrPPtEmPqpM83aqZXaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sbREU9FbWU9quRswUeOLIUKRE/bDm8Dd898bYIyaKd6lRBhYQJrYLNlmiR48w5HJ4 jX2mqq8d3PeteEFqF774P+9ph6+X/ttO5jVW3/leuQnp2Jkb0k+apFaCiR1vmuBbHv wdSXX/rzHb3FF+wJzpgK9mwJBFG0hcpwtPoS32pMdOAuAJBAgg8vP5Y36F4MhMdjS4 GK/WQ6rbmR5Nhf/5eHsddDblCy+bEzTIDoiQWnWkGcB7Ji873P2pFFlVovIO9gQxAH 8Y1UacvCmVaf0inBJTc5/wMA3qGIO6P7gYyKMPCVvA2vsQmNsrxMw0uAUTbiZoYT4Z 3z9sYGgzA7RNg== From: "Christophe Leroy (CS GROUP)" To: CHAMPSEIX Thomas , Marco Crivellari , Kees Cook , Roy Pledge , Claudiu Manoil , Scott Wood , Richard Genoud Cc: Christophe Leroy , Thomas Petazzoni , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: fsl: qbman: fix race condition in qman_destroy_fq Date: Fri, 6 Feb 2026 08:24:38 +0100 Message-ID: <177036249397.3323736.12618812589949729211.b4-ty@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251223072549.397625-1-richard.genoud@bootlin.com> References: <20251223072549.397625-1-richard.genoud@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1195; i=chleroy@kernel.org; h=from:subject:message-id; bh=s/9qncZXkiRO4FXncL0CjHqdtLNJ8JipcvT2jBzGz1A=; b=owGbwMvMwCV2d0KB2p7V54MZT6slMWS2Tre68l9pplRo+duDR+4UMDO8TeRLrLGK//YjganWS DFS53JRRykLgxgXg6yYIsvx/9y7ZnR9Sc2fuksfZg4rE8gQBi5OAZjIbz5GhuNlWybsF21xr89T cmaMu/Z3Y0n5hGaNlvP13jG8coZ8pQx/ZS5NcztynVX7xYaddo7idenxPOsU3yycyzuvWt4kNSe REwA= X-Developer-Key: i=chleroy@kernel.org; a=openpgp; fpr=10FFE6F8B390DE17ACC2632368A92FEB01B8DD78 Content-Transfer-Encoding: 8bit On Tue, 23 Dec 2025 08:25:49 +0100, Richard Genoud wrote: > When QMAN_FQ_FLAG_DYNAMIC_FQID is set, there's a race condition between > fq_table[fq->idx] state and freeing/allocating from the pool and > WARN_ON(fq_table[fq->idx]) in qman_create_fq() gets triggered. > > Indeed, we can have: > Thread A Thread B > qman_destroy_fq() qman_create_fq() > qman_release_fqid() > qman_shutdown_fq() > gen_pool_free() > -- At this point, the fqid is available again -- > qman_alloc_fqid() > -- so, we can get the just-freed fqid in thread B -- > fq->fqid = fqid; > fq->idx = fqid * 2; > WARN_ON(fq_table[fq->idx]); > fq_table[fq->idx] = fq; > fq_table[fq->idx] = NULL; > > [...] Applied, thanks! [1/1] soc: fsl: qbman: fix race condition in qman_destroy_fq (no commit info) Best regards, -- Christophe Leroy (CS GROUP)