From: Kees Cook <kees@kernel.org>
To: ruipengqi <ruipengqi3@gmail.com>
Cc: Kees Cook <kees@kernel.org>,
tony.luck@intel.com, gpiccoli@igalia.com,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pstore: ram_core: fix incorrect success return when vmap() fails
Date: Fri, 6 Feb 2026 16:51:37 -0800 [thread overview]
Message-ID: <177042549530.3947477.12730856527038867205.b4-ty@kernel.org> (raw)
In-Reply-To: <20260203020358.3315299-1-ruipengqi3@gmail.com>
On Tue, 03 Feb 2026 10:03:58 +0800, ruipengqi wrote:
> In persistent_ram_vmap(), vmap() may return NULL on failure.
>
> If offset is non-zero, adding offset_in_page(start) causes the function
> to return a non-NULL pointer even though the mapping failed.
> persistent_ram_buffer_map() therefore incorrectly returns success.
>
> Subsequent access to prz->buffer may dereference an invalid address
> and cause crashes.
>
> [...]
Applied to for-next/pstore, thanks!
[1/1] pstore: ram_core: fix incorrect success return when vmap() fails
https://git.kernel.org/kees/c/05363abc7625
Take care,
--
Kees Cook
prev parent reply other threads:[~2026-02-07 0:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 2:03 ruipengqi
2026-02-07 0:51 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177042549530.3947477.12730856527038867205.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruipengqi3@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®