From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34503277017 for ; Tue, 10 Feb 2026 03:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770693396; cv=none; b=K8APW+M6IPAgWKztCC1sQsjrFKVVHpnQVHBpZgxMreshxjPUQQ8UEzuOHmgGXXVaECjY84k5gvcmMOv+f2nVeo+Og76JZwYS/L7QBQF1DWu/ZBNJ6zHPCcWvDou5lI+r0ihPVpIkMHKxkFjR9rmTlmIkhMI9gj8KQV85+Ci51rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770693396; c=relaxed/simple; bh=19QF1yrbFGEPExVaP3vDmbuugkpv3B39Mgras0qSQB8=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=ElqWAhovDenT9a8xehvRfGmFPF4DcWTvD6BqNYnvyWptNLaCXnL+nGvF50yHxfVIuTW8RppIt3XSgk0f0qajKY/ad8SJkmrhVIwFPfyT0vuxiwEoFvTHStFT3zup2CKSTOtHRtSpJm88asD3fHtZ7NdDkmwXeSoNRclKkekNfW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=B167zbVX; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="B167zbVX" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-662fe3ff6f6so2698554eaf.0 for ; Mon, 09 Feb 2026 19:16:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1770693393; x=1771298193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UatjcoVxwf6eOeo4yvNkidW3e6786jLoKxEjLNDCB94=; b=B167zbVX7/GAC5/UvRWJA586OSKKlTuIaFiEW0mggjONC0cnNyBKX15D93WhuEj8dk 3TP+rUi+5vUIkTG3HvPRxB4AlkzAre4J2mLMrHcXB0bmcgONNuQCY+/KtK6ATyqhzY2Q gpeb7mB8w8MoLakNiBY4PYV/Hx5mseVENBBfkO4D/1jRgAwdnwPvUwRsuS92w6SetVDs 0i1sFcnF+LAygZc1Rvk32O4p2S4Lqi3uPSEMKJiCkQZE8ZklamDm2bpmtgbkznspw54w +1+PwXw285uqxajB8XYfU2i67AyMwHEA+SXVmSMwMWn72kuvB6cRd1dUfQT9PQxFB0z7 t5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770693393; x=1771298193; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UatjcoVxwf6eOeo4yvNkidW3e6786jLoKxEjLNDCB94=; b=ikmBYsfuAKG/pzRy/1s24dcPZoqDdM4G9fSTJer6cEtJID+Q4OZg8CEJKFog5c+B0M OquyXWwZBjaNqqOqIzNbsAT6gl1vNg3ILZKrQwaSImCdy5SzPos48ramcy7X/U1LXoy0 hCslLitthloS1k2Mqa0XQISdVrxVVem4ANHjcPPMnCotG0DjvkwrxJpVYxtCdCLQajVb O3w971lvhiQeqazJZxsWJ/FNw5lCpfN0nDKjEZzx/M3BgukrBAyxNakquEdOHu/FQ7yR XrMKS4QHwcQUdRAhPd5VhCqAAvdru5/hTTCP/Lo7DWSHW+Gxr18XaSv/PCM9dMaQDxyh Zrwg== X-Forwarded-Encrypted: i=1; AJvYcCVURIIsO258K35SBO3Tx77TWivSxh8UfwQQ1S5CFwti1PqXSEWy2BxLx/86mwon2BmxXOUlab/Av09elQk=@vger.kernel.org X-Gm-Message-State: AOJu0YxYBpUCH5XMieWDWXeWptXGkYQMP9TxLazSutuTTr13co2Wyk38 Ce5HeXx8ihxiVZtOG7/AJkWk4dzIGBoouGEjyiNoghSvtYr8qmpWUHFs+VOCkKNsQLhLrjKsFpe tDNmohwI= X-Gm-Gg: AZuq6aJaM/LnUTPS6GPt4Ca1WnPLZAmz/XwLgamQwzIPnPeONBUXobofCyHI/zMxsQV SEEbXnyWt1XCot6yv3JhLW7mLGR4P1vMb6VDgtVxdH/Yk0Ud7ZhIB4xy8EgeRg3FjRwwTcZ4tqF Yfcve7r/pnzjrINB4jsBHcv3/6v4Y3WDSG9t01xon59ilHOQCKLbb5Cz+JDPZabGv2lo6aJjytZ RmWBcur/0/Due2UWzsWG/zMFf3HfB/CWFdpDRjS2wEg9ZLGzUuNP0IzM6FnwBxm2HBBmDaSJCyh j2xsyFCwet6Q0klHzPsirYyRcutpgsWaOZLKP69xMWTFvZDufsdtS99Z4KHhK0PdcioSgm3BbaP qdxY/xoO9C2i1etur2w26TJ4jlB/PjIsCuvev8A1+j1wA2vVKlON8r0EBF2xJOOVxFdFK2MtBw2 dlSVNK0f4B1VMlJZ4+DyLbMLuS8LBPXDCjAiAV0mjYvFjr3JeYGejAaFby4aul0UR+p/goZT4ZH RXS X-Received: by 2002:a05:6820:2106:b0:663:2b12:1500 with SMTP id 006d021491bc7-672ff550affmr288529eaf.76.1770693393520; Mon, 09 Feb 2026 19:16:33 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-66d3adcaa9csm7545605eaf.11.2026.02.09.19.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 19:16:32 -0800 (PST) From: Jens Axboe To: Caleb Sander Mateos Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260206215806.1637548-1-csander@purestorage.com> References: <20260206215806.1637548-1-csander@purestorage.com> Subject: Re: [PATCH] io_uring: simplify IORING_SETUP_DEFER_TASKRUN && !SQPOLL check Message-Id: <177069339234.478075.3124286738158436259.b4-ty@kernel.dk> Date: Mon, 09 Feb 2026 20:16:32 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Fri, 06 Feb 2026 14:58:04 -0700, Caleb Sander Mateos wrote: > io_uring_sanitise_params() already rejects flags that include both > IORING_SETUP_SQPOLL and IORING_SETUP_DEFER_TASKRUN. So it's unnecessary > to check IORING_SETUP_SQPOLL in io_uring_create() when > IORING_SETUP_DEFER_TASKRUN has already been checked. Drop the > !(ctx->flags & IORING_SETUP_SQPOLL) check for the task_complete case. > > > [...] Applied, thanks! [1/1] io_uring: simplify IORING_SETUP_DEFER_TASKRUN && !SQPOLL check commit: 7cb3a68376da0bc0afab8157223cb479c97de9ff Best regards, -- Jens Axboe