From: Paul Mackerras <paulus@samba.org>
To: greg@kroah.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Why is device_create_file __must_check?
Date: Tue, 10 Oct 2006 14:32:33 +1000 [thread overview]
Message-ID: <17707.8801.395100.35054@cargo.ozlabs.ibm.com> (raw)
I am seeing a bunch of warnings about not checking the return value
from device_create_file() for code like this (from
arch/powerpc/kernel/pci_64.c):
static ssize_t pci_show_devspec(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct pci_dev *pdev;
struct device_node *np;
pdev = to_pci_dev (dev);
np = pci_device_to_OF_node(pdev);
if (np == NULL || np->full_name == NULL)
return 0;
return sprintf(buf, "%s", np->full_name);
}
static DEVICE_ATTR(devspec, S_IRUGO, pci_show_devspec, NULL);
void pcibios_add_platform_entries(struct pci_dev *pdev)
{
device_create_file(&pdev->dev, &dev_attr_devspec);
}
What bad thing could happen if device_create_file fails, other than
that the "devspec" file doesn't appear in sysfs? I don't see how the
error could lead to any null pointer dereference later on or anything
like that. If some bad thing could happen, how do I avert that? If
nothing bad will happen, why does device_create_file have __must_check
on it?
Paul.
next reply other threads:[~2006-10-10 4:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 4:32 Paul Mackerras [this message]
2006-10-10 4:49 ` Andrew Morton
2006-10-10 5:04 ` Greg KH
2006-10-10 5:14 ` Paul Mackerras
2006-10-10 5:26 ` Andrew Morton
2006-10-10 7:03 ` Paul Mackerras
2006-10-10 5:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17707.8801.395100.35054@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®